From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9751EC433EF for ; Thu, 2 Dec 2021 04:44:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QyFq+Z6yCdFmCheJg/RPC5NP9mliVOJB/9kGSaMy6Co=; b=38UCj7uFrXFm9G MEzRO1LCq6sUtkZhwmtALhcfbyP6rAdfCl3WYwe9CL8vxJQPXUplG5PfrIr+rmUl1UY7H+MNS8we9 ErN8MJR0ZvKCJdcuh3G1hiWMJC46cWsvjUIJOCe/afEBuGP3PDOyyUDjlYRW9t7AQY/t3p9IoFOmI +h3/mbdaPA/2jFHNP1vn7fx1grras3zLpIY2jZdr6EkdW/mhY+F7gAYb8vVflosB8QiI9Y3GKj6AP RaFsdpvHGpbgIfqeh1az1v8WHkuG098+JXBX0v0DMjkrF2LxQSsXPa6HNSH4AYQcu6hMIgOdxUNp/ w+sOMNKQbkwINK7yTeHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msdvU-00Av7l-1E; Thu, 02 Dec 2021 04:42:32 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msdvQ-00Av6k-9v for linux-arm-kernel@lists.infradead.org; Thu, 02 Dec 2021 04:42:29 +0000 Received: by mail-pf1-x434.google.com with SMTP id b68so26757826pfg.11 for ; Wed, 01 Dec 2021 20:42:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QPV306Cl1hLkT1aLm/ztTcGSxnCGdiyQM9JvOmh+VBI=; b=E13BrctyEiJmk8QUej4+qBU++tdSGEmKsrgPFCfx4zr+AVn8a28NmmgnY75romMi89 U7ILmdqSDi4IqU1FQskq+DfQT48XCLWbZJLMOpXKWLcwy2RD/8q48vl9tFE+2fXPsZVR +ZI+StjehXpNDVvQ5L0pIKJzXtyXOPfQ4mivaLwcwCFo1KCxzlZAizfhCRjTso+t4G+L wJgw60wiDhYBTdWf9RshLHW31L2CmL6O4QuDIZMQeurga3UCgV1R1Yyffw6RafTgFsrC Vo2cHqAgDqh1KK0SqqfwDrOZ9Uix5RsQYB+cLuVHGj1NDgJE3P7oVXFxcHf73VIjQ65p T/ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QPV306Cl1hLkT1aLm/ztTcGSxnCGdiyQM9JvOmh+VBI=; b=3lCjUy2b8+y9W54Qk/ks+IYjuTFRHL2IQkqwq2LwUSgU62Ozns0jkZyWz/JGMqdaIF ECGBxcEzlYealzlUGSkWJpmPyJ5vpT+lO/Us2tP0BT6cHJTQ7zhhpsXs+ZmCVofJIV0X B3Csk938E8BCLJTia2H3aZgzWFiOWBb+q24XePuc/b7Cp74OUjylmxrPAGl2TszM4Xxs KrCDB75mNdqr46sBRB18cPnfsaWuvCjz/NzTVJWqtW5ea/ucJ6JHQ3ExoZ6047mGhN8i izi1dJE1v+f5m3yyURz7vO1kjmy1EZeftvrDWnb326GxiKRe05LrZzxatuOPtMjPHebC qtGA== X-Gm-Message-State: AOAM531/Jc/rkTwB4gYlvW6Jdo60AGlUJYFC3ArMuQnBQalx2z4No4hQ Xz39FksxTkF4Q8Te0dYGdjUPsw== X-Google-Smtp-Source: ABdhPJyChYJegnkY59sNvTlcAnuBxHuEZK8rD2ydV4fBqk/D+T3tW0FLAm3x803r/bwHx62jIBYF4g== X-Received: by 2002:a63:d17:: with SMTP id c23mr7912840pgl.207.1638420143063; Wed, 01 Dec 2021 20:42:23 -0800 (PST) Received: from google.com ([2401:fa00:1:10:ce4d:ddd8:41f4:d987]) by smtp.gmail.com with ESMTPSA id p43sm1426664pfw.4.2021.12.01.20.42.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Dec 2021 20:42:22 -0800 (PST) Date: Thu, 2 Dec 2021 12:42:18 +0800 From: Tzung-Bi Shih To: "allen-kh.cheng" Cc: Mark Brown , Rob Herring , Matthias Brugger , Jassi Brar , Linux-ALSA , cujomalainey@google.com, Pierre-Louis Bossart , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta , Jaroslav Kysela , Takashi Iwai , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, sound-open-firmware@alsa-project.org Subject: Re: [PATCH v9 3/3] mailbox: mediatek: add support for adsp mailbox controller Message-ID: References: <20211201075604.27864-1-allen-kh.cheng@mediatek.com> <20211201075604.27864-4-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211201075604.27864-4-allen-kh.cheng@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_204228_374919_232832F7 X-CRM114-Status: GOOD ( 10.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 01, 2021 at 03:56:04PM +0800, allen-kh.cheng wrote: > diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c [...] > +static const struct mbox_chan_ops adsp_mbox_chan_ops = { > + .send_data = mtk_adsp_mbox_send_data, > + .startup = mtk_adsp_mbox_startup, > + .shutdown = mtk_adsp_mbox_shutdown, > + .last_tx_done = mtk_adsp_mbox_last_tx_done, > +}; To be consistent, s/adsp_mbox_chan_ops/mtk_adsp_mbox_chan_ops/. With that, Reviewed-by: Tzung-Bi Shih _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel