linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, Rui Miguel Silva <rmfrfs@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-media@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: media: nxp, imx7-mipi-csi2: Drop bad if/then schema
Date: Fri, 3 Dec 2021 00:43:40 +0200	[thread overview]
Message-ID: <YalMHPsLzQ02v5uO@pendragon.ideasonboard.com> (raw)
In-Reply-To: <CAL_Jsq+u=Hr8_2WdqDEnu+wT8zZjngepY1-JqTrt7pazGFCTpQ@mail.gmail.com>

Hi Rob,

On Thu, Dec 02, 2021 at 04:26:23PM -0600, Rob Herring wrote:
> On Thu, Dec 2, 2021 at 3:06 PM Laurent Pinchart wrote:
> > On Wed, Dec 01, 2021 at 08:30:21PM -0600, Rob Herring wrote:
> > > The if/then schema for 'data-lanes' doesn't work as 'compatible' is at a
> > > different level than 'data-lanes'. To make it work, the if/then schema
> > > would have to be moved to the top level and then whole hierarchy of
> > > nodes down to 'data-lanes' created. I don't think it is worth the
> > > complexity to do that, so let's just drop it.
> >
> > Fair enough, but then shouldn't there be a comment in the data-lanes
> > property to tell that i.MX7 only supports up to 2 data lanes ?
> 
> I'll add this to data-lanes:
> 
> description: Note that 'fsl,imx7-mipi-csi2' only supports up to 2 data lines.

Looks good to me.

> I assume it is 1 or 2 and not only 2, right?

Correct.

-- 
Regards,

Laurent Pinchart

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2021-12-02 22:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02  2:30 [PATCH] dt-bindings: media: nxp, imx7-mipi-csi2: Drop bad if/then schema Rob Herring
2021-12-02 13:58 ` Rob Herring
2021-12-02 22:21   ` Laurent Pinchart
2021-12-02 21:05 ` Laurent Pinchart
2021-12-02 22:26   ` Rob Herring
2021-12-02 22:43     ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YalMHPsLzQ02v5uO@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=rmfrfs@gmail.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).