From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21FF0C433F5 for ; Fri, 10 Dec 2021 11:59:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SDYWGEwdPwOGr4qTOEUu1AKnCuDOOGl9FInRu+N7ULU=; b=D/DYY/zCsiDK2z X2VtDzRVwhoIQdLfNV4yYW5xrP3WJ3VSACWnaFt3+BQrxPFwxvNvDqhSDKgIFEn5L9qq9BpwThRdD pj0cE2yKyNkNoxA4iDZIL53lcm8L9Tik/5ZKo7YImm2lLptqCE9CXZnv/t2BI6V7/SIqZLVxnAmRb ggH0OByH71xIDjaX6txf/n2amGqKLfO5hkNJTBxZFLZipJ6uV2qYw7BQtIEtbcZKAb9GHGTjMHTET Vnrq7RHChM6ahB2lUBiPk0Ev87Lt5ylVJ210ssyUqTevU0nFT9X/28jB/CUDqneCM98IZ1Di/zRM8 xO3g2kyOniJ3nknC4GNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mveX7-001kfs-J8; Fri, 10 Dec 2021 11:57:49 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mveX3-001keW-Lx for linux-arm-kernel@lists.infradead.org; Fri, 10 Dec 2021 11:57:46 +0000 Date: Fri, 10 Dec 2021 12:57:42 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1639137463; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e1vgqxQf/HEi/380wsVHeIa9ywtiqHCGTo+cLrBRCS8=; b=M06WG2fjZg8Q7s/v74qppLMukNLwKMvoskcPaBE+u0RABP+0hnmX1ucoBrvIcdc2ONks3i xZE6b5nRkbka6yd8uj6I5EyaY6fh2d4xuSmoCGI9mBYeiyY1PmdQCOtu7EDJbZXiea2rrM vdcfjawEaBaRyLWeF/E7Hg/hlAoDZnyh304ebFxSlPKzlyQA1fIZZSol8a8Y1Y4BPxpPYm k6ulRdzVbUJgYaTenybJ5jI4LH7+NRH4/oJMFn7B9dCGilW8iPh6+u9K/Q7c4bng4Zz1C0 VhIuhmuZGMqq2gMBAbDmoGtlhwtI+u2nF6dosyq4Nhqp8Uc3vrOWussg4eWwNg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1639137463; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e1vgqxQf/HEi/380wsVHeIa9ywtiqHCGTo+cLrBRCS8=; b=rsc5nRk9sbKctQ/ZB7AeRdGtNr25bxJmH09axXoE00yDptL0jMq7ZL992/bFEo7MIiqUsc 2ysWQSGF6MWYVgCQ== From: Sebastian Andrzej Siewior To: Kurt Kanzenbach Cc: Ong Boon Leong , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin , alexandre.torgue@foss.st.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next 2/2] net: stmmac: add tc flower filter for EtherType matching Message-ID: References: <20211209151631.138326-1-boon.leong.ong@intel.com> <20211209151631.138326-3-boon.leong.ong@intel.com> <87fsr0zs77.fsf@kurt> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87fsr0zs77.fsf@kurt> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211210_035745_885302_EE8FBEAA X-CRM114-Status: UNSURE ( 5.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-12-10 11:10:04 [+0100], Kurt Kanzenbach wrote: > > + if (match.mask->n_proto) { > > + __be16 etype = ntohs(match.key->n_proto); > > n_proto is be16. The ntohs() call will produce an u16. While at it, could we be please remove that __force in ETHER_TYPE_FULL_MASK and use cpu_to_be16() macro? > Thanks, > Kurt Sebastian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel