From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAC1BC433F5 for ; Fri, 10 Dec 2021 13:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CxVK1vHS7FoDiGfegZZauIJ3MbdgxjWlSViizsVlnNc=; b=sC9RiJabFKffgd dUy9gBfcMMyh8aCdPipjMKoZLGXYWLoehlhvaieN5C1iRoamaIsWCAc6o0/chkK8gIv6A4UYdbrW8 wUXauEi1/3HMnGyUcjV7IV689z/IrmyksgXA+IA0QUs8Z6MUPFt7SxafRa6NruiRN9CTA9ZPOMtPU +4o2nuKV6viScJA2mBTN9Q/xPO0HXUyo9JjzKiiHEm6rRbNU5tKUccKoZb7SXKAmwmi1HMyrH4Hgw bDZGGzieO+VAnHd8dgZLySOhKrLdhQr14aKmwrkFFXL8TFA/C74xNa2u63LZI/AnWXVC2YG0iXMw3 F3sVEtIvNN+UwH1liIZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvg5h-0021Yj-5d; Fri, 10 Dec 2021 13:37:37 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvg5P-0021Lt-EI for linux-arm-kernel@lists.infradead.org; Fri, 10 Dec 2021 13:37:21 +0000 Received: by mail-wr1-x42f.google.com with SMTP id o13so14911068wrs.12 for ; Fri, 10 Dec 2021 05:37:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UMyDDswc1FZItAV+NSBPgTMyKyf2+D9Oge1wredtc7c=; b=Hd1kuvSf5n0DrJQqp7698lcVKXaMe/TLA/TGhOMfEQB+SDBrEZSfhys+1IT/Y9TNyo FL8OV6pI6tCoxkvRHdGU1Yb0vpUYv9NpLbrYPsFAhL0emDoOlMJ8koYvMmkU1N1c+g/o a+6RuJ+GeMiN9MGhCLm4Xe5H2oksD2RfUEfIT0cDRa47DtJrc6B/2rirhTiqEnjLknZg Edm9SBItDyelahvSPfyZd7mfbz0+0T4ipL34oS5YwSFmZOS+jm+2AstTmdnupYqn7yS4 bXnwlWddpKU7TKBOqNuxT+m/f+GADIey098ZH+N1FWcJiCWqUTlDRfdOZ5imoUiEH2mt F4hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UMyDDswc1FZItAV+NSBPgTMyKyf2+D9Oge1wredtc7c=; b=8RsGLWE/u9cnkCKnQwUFN6MbbE3llMZ/X6PW6aEYiucEAL4CAfV9xjSsNz9JcNTOY9 9wxqFDGW8toS+OwANvdE2Klc5THEMeQrZM2J3OCiylFnL8ZM1XTOhIqPNJjGckEko+M2 DmzonsyoXOCL/HtOO4+KGYyOVe5QaQqYWC/jy3CShQl6z2NHDPZuWipBp4tnTEaqki3D xcPo6xbbD2f0zz3gTwgZqaWuZB05sJgfEUoiiD/yWAzAswit6qqxrL5LiJyRDokbNuzG s51WRxhcTsFAMnGQd0ka7FCzHN3uCEDejt1Qb/uFjN/twZXR1KGRNMjyW4XKcswlqrAW fWHg== X-Gm-Message-State: AOAM532wTsakK0PYywH+i4VmfsNGHxZWL6xB7AxNxOWbJsyjPtPVeela 77chIMQIXv0b6OPAp9FgAf9INw== X-Google-Smtp-Source: ABdhPJyK1FJ33ENKdaCNwdVJ8F5MUTfJNljKx5SySODi49ZDvjnWhgaYlWH5OSJlvG5ocohi1ih2Ow== X-Received: by 2002:adf:d1e3:: with SMTP id g3mr14499141wrd.3.1639143436764; Fri, 10 Dec 2021 05:37:16 -0800 (PST) Received: from google.com ([2a00:79e0:d:210:76c1:fb36:1e22:8677]) by smtp.gmail.com with ESMTPSA id a1sm3408752wri.89.2021.12.10.05.37.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Dec 2021 05:37:16 -0800 (PST) Date: Fri, 10 Dec 2021 13:37:12 +0000 From: Quentin Perret To: Will Deacon Cc: Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v3 01/15] KVM: arm64: Check if running in VHE from kvm_host_owns_hyp_mappings() Message-ID: References: <20211201170411.1561936-1-qperret@google.com> <20211201170411.1561936-2-qperret@google.com> <20211209101053.GA1833@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211209101053.GA1833@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211210_053719_530830_E9335675 X-CRM114-Status: GOOD ( 21.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thursday 09 Dec 2021 at 10:10:54 (+0000), Will Deacon wrote: > On Wed, Dec 01, 2021 at 05:03:55PM +0000, Quentin Perret wrote: > > The kvm_host_owns_hyp_mappings() function should return true if and only > > if the host kernel is responsible for creating the hypervisor stage-1 > > mappings. That is only possible in standard non-VHE mode, or during boot > > in protected nVHE mode. But either way, non of this makes sense in VHE, > > so make sure to catch this case as well, hence making the function > > return sensible values in any context (VHE or not). > > > > Suggested-by: Marc Zyngier > > Signed-off-by: Quentin Perret > > --- > > arch/arm64/kvm/mmu.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > > index 326cdfec74a1..f8f1096a297f 100644 > > --- a/arch/arm64/kvm/mmu.c > > +++ b/arch/arm64/kvm/mmu.c > > @@ -239,6 +239,9 @@ void free_hyp_pgds(void) > > > > static bool kvm_host_owns_hyp_mappings(void) > > { > > + if (is_kernel_in_hyp_mode()) > > + return false; > > This looks identical to: > > https://lore.kernel.org/r/20211208152300.2478542-7-qperret@google.com Yep, I figured it made more sense in the other series as it's not strictly related to this one, so ... :) Cheers, Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel