From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06119C433F5 for ; Fri, 10 Dec 2021 15:04:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tbdkcFWZpBqfv9F9w+PpVfKcVy3JFLcE8mKfkTMg6zc=; b=o6ifIcl5v2ePDU PgbVs3AhSyp49XgHY18f4yjPhlNgwJYX4Y6pbyYywfhwoiZc3Fyf82Uy4vjJa/gIYhKtVCSa+oEUL B/AA9OrQTTLIcBUxHgYY5qylg2nM136+z4hBLdS/cykkqLw6G/ExcD1s7ayccru1vxCXOLaEOK7RM PXK3RoeaXZZuIZvIlx7zbiPfKKs5Ir6zZpOcY4faJfm6FvE3eMRC+c/yOiVhTvnI+4iAIkqFa5XRb iwVami3Cg0DC3BZ+CdgFusioRZ9sgTGQTqKvrMbHpQKlLQpogRK0V1SJ2t7yxicPibyyYfleokz1B JJ8F32acAD5frw0/HtJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvhQW-002IRy-Gh; Fri, 10 Dec 2021 15:03:12 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvhQS-002IQj-RQ for linux-arm-kernel@lists.infradead.org; Fri, 10 Dec 2021 15:03:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id CB1DECE2B81; Fri, 10 Dec 2021 15:03:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79BA9C00446; Fri, 10 Dec 2021 15:03:02 +0000 (UTC) Date: Fri, 10 Dec 2021 15:02:59 +0000 From: Catalin Marinas To: Mark Rutland Cc: linux-kernel@vger.kernel.org, ardb@kernel.org, bp@alien8.de, broonie@kernel.org, dave.hansen@linux.intel.com, jpoimboe@redhat.com, jslaby@suse.cz, linux-arm-kernel@lists.infradead.org, maz@kernel.org, mingo@redhat.com, peterz@infradead.org, tabba@google.com, tglx@linutronix.de, will@kernel.org Subject: Re: [RFC PATCH 4/6] arm64: clean up symbol aliasing Message-ID: References: <20211206124715.4101571-1-mark.rutland@arm.com> <20211206124715.4101571-5-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211206124715.4101571-5-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211210_070309_110111_A1BFF5D8 X-CRM114-Status: GOOD ( 20.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 06, 2021 at 12:47:13PM +0000, Mark Rutland wrote: > Now that we have SYM_FUNC_ALIAS() and SYM_FUNC_ALIAS_WEAK(), use those > to simplify and more consistently define function aliases across > arch/arm64. > > Aliases are now defined in terms of a canonical function name. For > position-independent functions I've made the __pi_ name the > canonical name, and defined other alises in terms of this. > > The SYM_FUNC_{START,END}_PI(func) macros obscure the __pi_ name, > and make this hard to seatch for. The SYM_FUNC_START_WEAK_PI() macro > also obscures the fact that the __pi_ fymbol is global and the > symbol is weak. For clarity, I have removed these macros and used > SYM_FUNC_{START,END}() directly with the __pi_ name. > > For example: > > SYM_FUNC_START_WEAK_PI(func) > ... asm insns ... > SYM_FUNC_END_PI(func) > EXPORT_SYMBOL(func) > > ... becomes: > > SYM_FUNC_START(__pi_func) > ... asm insns ... > SYM_FUNC_END(__pi_func) > > SYM_FUNC_ALIAS_WEAK(func, __pi_func) > EXPORT_SYMBOL(func) > > For clarity, where there are multiple annotations such as > EXPORT_SYMBOL(), I've tried to keep annotations grouped by symbol. For > example, where a function has a name and an alias which are both > exported, this is organised as: > > SYM_FUNC_START(func) > ... asm insns ... > SYM_FUNC_END(func) > EXPORT_SYMBOL(func) > > SYM_FUNC_ALAIAS(alias, func) > EXPORT_SYMBOL(alias) > > For consistency with the other string functions, I've defined strrchr as > a position-independent function, as it can safely be used as such even > though we have no users today. > > As we no longer use SYM_FUNC_{START,END}_ALIAS(), our local copies are > removed. The common versions will be removed by a subsequent patch. > > There should be no functional change as a result of this patch. > > Signed-off-by: Mark Rutland > Cc: Ard Biesheuvel > Cc: Catalin Marinas > Cc: Mark Brown > Cc: Will Deacon Acked-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel