From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5E8DC433F5 for ; Fri, 10 Dec 2021 15:06:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U5QdQ82QO5UKReQDgadpuy445ZmeHR6DSe7pkHGDzJ0=; b=14Wpax7ZR2hEY0 u9ZCjTyqPVnHPy+upG4Sa38o6OvuTCl8wwGEX1nX0etRC/RrUeq3OV+WD0KPneBcT1U1OLE6FLBXj 7Vh3WB1aFVJ3tpgkd31qr1FEzaRWirENtqUwijqOXw0DXAgPiba5bGbzHDjIUqrxNnIlKGv1ICbbF VA41nqnMF8hFW1BxdYRVJZSeWYk9xKi/Z6BZe0/euR3G4kZ61QUWF0ZLYjkqnb5ESaGdvVozYHyWy CsHhzWdWix689tiJDWbIJmjmYsJFikQsYwYunJyLCWaR4HpDjJs+dYzjrbwlX/N2hyBaxgoXroVxZ kHx7IiJ1yaUFwf92Ry6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvhSE-002J2f-Um; Fri, 10 Dec 2021 15:04:59 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvhSA-002J0j-Qg for linux-arm-kernel@lists.infradead.org; Fri, 10 Dec 2021 15:04:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 1A8D4CE2B80; Fri, 10 Dec 2021 15:04:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADB2CC00446; Fri, 10 Dec 2021 15:04:48 +0000 (UTC) Date: Fri, 10 Dec 2021 15:04:45 +0000 From: Catalin Marinas To: Mark Rutland Cc: linux-kernel@vger.kernel.org, Borislav Petkov , Jiri Slaby , Josh Poimboeuf , Peter Zijlstra , ardb@kernel.org, broonie@kernel.org, dave.hansen@linux.intel.com, linux-arm-kernel@lists.infradead.org, maz@kernel.org, mingo@redhat.com, tabba@google.com, tglx@linutronix.de, will@kernel.org Subject: Re: [RFC PATCH 0/6] linkage: better symbol aliasing Message-ID: References: <20211206124715.4101571-1-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211206124715.4101571-1-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211210_070455_090959_95933195 X-CRM114-Status: GOOD ( 17.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 06, 2021 at 12:47:09PM +0000, Mark Rutland wrote: > This series aims to make symbol aliasing simpler and more consistent. > The basic idea is to replace SYM_FUNC_START_ALIAS(alias) and > SYM_FUNC_END_ALIAS(alias) with a new SYM_FUNC_ALIAS(alias, name), so > that e.g. > > SYM_FUNC_START(func) > SYM_FUNC_START_ALIAS(alias1) > SYM_FUNC_START_ALIAS(alias2) > ... asm insns ... > SYM_FUNC_END(func) > SYM_FUNC_END_ALIAS(alias1) > SYM_FUNC_END_ALIAS(alias2) > EXPORT_SYMBOL(alias1) > EXPORT_SYMBOL(alias2) > > ... can become: > > SYM_FUNC_START(name) > ... asm insns ... > SYM_FUNC_END(name) > > SYM_FUNC_ALIAS(alias1, func) > EXPORT_SYMBOL(alias1) > > SYM_FUNC_ALIAS(alias2, func) > EXPORT_SYMBOL(alias2) > > This avoids repetition and hopefully make it easier to ensure > consistency (e.g. so each function has a single canonical name and > associated metadata). > > I'm sending this as an RFC since I want to check: > > a) People are happy with the idea in principle. > > b) People are happy with the implementation within . > > ... and I haven't yet converted the headers under tools/, which is > largely a copy+paste job. I'm happy with the approach and acked the arm64 patches for the record. Not sure how/when this series will get into mainline. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel