From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FF76C433EF for ; Fri, 10 Dec 2021 18:50:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QGoIUcd0Z0KRh+WUF4M5RUVOj1RCT0kCd2YbUaOio00=; b=P9wesAaRBkaT2O AKpFjyatak9S7VK13vjxpoHgHAI3nWSrJ/kbDLvRBjMcGn7IbQcdauT2e2sj75CFUAFzZ0RlIvB83 /OXp8dRLPFhSRbhSzDHoUPlXx6/LsVgMZ8219rSck2d8aBFaeIevo2UcZnTF4yE/1UBUEBXV7fMU0 vtoFRyAfxx10v4S1UBE4IjRVW8emUqsQVGklNK90mpn5ObI+zpvQWyR4RMu2DpntO3eFcTJE2oIdc 6BmMHLv3MlGSJeRw7jBNBrqcU+L5k/HBzRtvoU36RMeUFmvVOJFxxxYWSCoOJVXY/w49WYNz2sgxO ntCoTX6IGrCFbePbPBbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvkwR-003HFe-HS; Fri, 10 Dec 2021 18:48:24 +0000 Received: from mail-oi1-f175.google.com ([209.85.167.175]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvksH-003FNi-Ny; Fri, 10 Dec 2021 18:44:07 +0000 Received: by mail-oi1-f175.google.com with SMTP id t23so14448955oiw.3; Fri, 10 Dec 2021 10:44:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rlreThK0Sey0EGMizq9uyfo3hzBqI9k/YwHzDsxWXlI=; b=uEHociM4blPI3vqkPxCgG8wJSvXNnKUCyBy/sTS+/pBeQhjyLNbzq8vsYFVcNC6R6h P6jaSzZ4KpXCtSmGRLNzU7v4Ma14IZDJq1B869Ecjugob410QnHcMx4i5UktGUuA4ayp mt2ptKHlz/L2jyhhcCa0NRjSK9CGw7NRgXNPXN54/7Wwrbt4sNqMqAaJMwInIYUNO85R f5RbStxlqGL5Aq4gGSwzzBsdtFgQncxbZl114FAprG5GjaWcBgo6cl6CPvZvAKWeRJRJ cS59ftquCbSNDeVNkvKYU/xRYJSsQxxyBk7yIDLj/TjH4BpSka0+N1W5w57cwx7hKGl2 XwZQ== X-Gm-Message-State: AOAM53134RkVuUoj0Issm58lBMEFzE71BpnL6gbCxJXiyCx+04TMrz/o KvUpkr2V5hAseKmEFQ87Cw== X-Google-Smtp-Source: ABdhPJyp/UbVF+mB50ua6SkSEbILc6yqej1hsUMidJLzHaqYNUkPeNuWk9tk1mgGwLLU2y+Yg7NaCQ== X-Received: by 2002:a05:6808:15a:: with SMTP id h26mr13549366oie.36.1639161845115; Fri, 10 Dec 2021 10:44:05 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id m22sm768027ooj.8.2021.12.10.10.44.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Dec 2021 10:44:04 -0800 (PST) Received: (nullmailer pid 1681795 invoked by uid 1000); Fri, 10 Dec 2021 18:44:03 -0000 Date: Fri, 10 Dec 2021 12:44:03 -0600 From: Rob Herring To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Bjorn Helgaas , Nicolas Saenz Julienne , Mark Brown , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Saenz Julienne Subject: Re: [PATCH v10 0/7] PCI: brcmstb: root port turns on sub-device power Message-ID: References: <20211209211407.8102-1-jim2101024@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211209211407.8102-1-jim2101024@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211210_104405_815941_48F00300 X-CRM114-Status: GOOD ( 17.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 09, 2021 at 04:13:58PM -0500, Jim Quinlan wrote: > v10 -- Bindings commit example: in comment, refer to bridge under > controller node as a root port. (Pali) > -- Bindings commit example: remove three properties that are not > appropriate for a PCIe endpoint node. (Rob) > > v9 -- Simplify where this mechanism works: instead of looking for > regulators below every bridge, just look for them at the > bridge under the root bus (root port). Now there is no > modification of portdrv_{pci,core}.c in this submission. > -- Although Pali is working on support for probing native > PCIe controller drivers, this work may take some time to > implement and it still might not be able to accomodate > our driver's requirements (e.g. vreg suspend/resume control). > -- Move regulator suspend/resume control to Brcm RC driver. It > must reside there because (a) in order to know when to > initiate linkup during resume and (b) to turn on the > regulators before any config-space accesses occur. You now have a mixture of 'generic' add/remove_bus hooks and the host controller suspend/resume managing the regulators. I think long term, the portdrv is going to be the right place for all of this with some interface defined for link control. So I think this solution moves sideways rather than towards anything common. Unfortunately, the only leverage maintainers have to get folks to care about any refactoring is to reject features. We're lucky to find anyone to test refactoring when posted if done independently. There's a long list of commits of PCI hosts that I've broken to prove that. So it's up to Lorenzo and Bjorn on what they want to do here. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel