From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56F58C433EF for ; Mon, 13 Dec 2021 09:11:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=afI2jCRLPMe6HHpvmiRa4CiX4ZiFlM9nEPPwGshnhHQ=; b=Qz7gSEjtyedy95 F8hH/5ebdw/JNx9fhNtj2EhZj+A0Av1JC7g6bMzzARtMOLuBDo9Af38BL4yfTXNeeoxsylJtauafv lmgr9s1tKW6LAZkHeLakZzbYEDzEPkkIs+p7PgtTaXSltz6sQ6egL6XJrdeeAh+1ZEtn+94GQJJPe r3iU32HZ7gXTf8kyQpgzvkZER4SJVtSndZ7rrO3u/V0LvdkcJ2/tEYPssuM8zRfPxcYp09szdVNQf xebCzGh//3iFsNx6Ujy0jHaKM90lILY9z+pVNgsXaYvNCeQ6mIxha1NCZzbDYcFfQM1rHw/h9BD2S +EUEg4NBTyFP6O+MpbHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwhKu-008WiX-6Q; Mon, 13 Dec 2021 09:09:33 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwhCg-008TNG-U9 for linux-arm-kernel@lists.infradead.org; Mon, 13 Dec 2021 09:01:06 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 016DECE0E21; Mon, 13 Dec 2021 09:01:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B490C00446; Mon, 13 Dec 2021 09:00:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639386059; bh=hButX0q6t1vsQ+TQR+Yf2PEiS5o8boeQPJjchkqIOmQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uQFAWkGNgeRG7enrJi2t9toOGBctSALvB/as4JgfmBuVfA5h4G/yybNPd4XM2pUSN iH2hfJdlcEhT8FAXfRhXPEAVmf8h1E2FAi8tteVw6VJAIYf3ZVh/Y5VlzPWh3i+wTD JxGJQRPiVnawRtAgkzzxShceU//ZtC4rfKWunPVUu+Nf8b/+vHTMJqo75y8qj90JCP WOgLPw5Ra7yaZAnQl3mbW7dccj7FeMxf+GcUuPCqHXsNSt2kkUqA8FFHKh3gaoZP5z X/D982jaXirojiKTBvAhxLIhYQr0aqlcfG+q8atoW67E/hG5zy2gV/lOM7JzK5eIp3 NqqNcYANxmgqA== Date: Mon, 13 Dec 2021 14:30:55 +0530 From: Vinod Koul To: Tudor.Ambarus@microchip.com Subject: Re: [PATCH v2 08/13] dmaengine: at_xdmac: Move the free desc to the tail of the desc list Message-ID: References: <20211125090028.786832-1-tudor.ambarus@microchip.com> <20211125090028.786832-9-tudor.ambarus@microchip.com> <8523ca32-d36f-6e0b-0115-5e07553396f1@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_010104_927909_0C1FCD03 X-CRM114-Status: GOOD ( 23.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, richard.genoud@gmail.com, gregkh@linuxfoundation.org, mripard@kernel.org, linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com, linux-serial@vger.kernel.org, dmaengine@vger.kernel.org, jirislaby@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13-12-21, 14:29, Vinod Koul wrote: > On 13-12-21, 08:51, Tudor.Ambarus@microchip.com wrote: > > Hi, Vinod, > > > > On 12/13/21 10:07 AM, Vinod Koul wrote: > > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > > > > > On 25-11-21, 11:00, Tudor Ambarus wrote: > > >> So that we don't use the same desc over and over again. > > > > > > Please use full para in the changelog and not a continuation of the > > > patch title! > > > > Ok, will add a better commit description. Here and in other patches where > > your comment applies. > > Great! > > > > > > > and why is wrong with using same desc over and over? Any benefits of not > > > doing so? > > > > Not wrong, but if we move the free desc to the tail of the list, then the > > sequence of descriptors is more track-able in case of debug. You would > > know which descriptor should come next and you could easier catch > > concurrency over descriptors for example. I saw virt-dma uses > > list_splice_tail_init() as well, I found it a good idea, so I thought to > > follow the core driver. > > Okay, I would be good to add this motivation in the change log. I am > sure after few you would also wonder why you did this change :) Also, pls submit serial patches to Greg separately. I guess he saw the title and overlooked those... -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel