linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Andrej Picej <andrej.picej@norik.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	soc@kernel.org, kernel@pengutronix.de, shawnguo@kernel.org,
	leoyang.li@nxp.com, krzysztof.kozlowski@canonical.com,
	linux@rempel-privat.de, festevam@gmail.com, arnd@arndb.de,
	linux-imx@nxp.com, y.bas@phytec.de
Subject: Re: [PATCH 1/4] dt-bindings: arm: fsl: add PHYTEC phyGATE Tauri i.MX6 ULL
Date: Mon, 13 Dec 2021 13:15:48 -0600	[thread overview]
Message-ID: <Ybeb5I/mP3JFrDsQ@robh.at.kernel.org> (raw)
In-Reply-To: <20211201125327.3704500-2-andrej.picej@norik.com>

On Wed, Dec 01, 2021 at 01:53:24PM +0100, Andrej Picej wrote:
> Add devicetree bindings for phyGATE Tauri board with phyCORE-i.MX6 ULL.
> 
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 0b595b26061f..9c37f22b6c61 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -602,6 +602,15 @@ properties:
>            - const: phytec,imx6ull-pcl063  # PHYTEC phyCORE-i.MX 6ULL
>            - const: fsl,imx6ull
>  
> +      - description: i.MX6ULL PHYTEC phyGATE-Tauri
> +        items:
> +          - enum:
> +              - phytec,imx6ull-phygate-tauri-emmc
> +              - phytec,imx6ull-phygate-tauri-nand
> +          - const: phytec,imx6ull-phygate-tauri # PHYTEC phyGATE-Tauri with i.MX6 ULL

Is there really a need for 2 compatibles here? Either 
phytec,imx6ull-phygate-tauri is specific enough (as nand/emmc can be 
described elsewhere) or you need 
phytec,imx6ull-phygate-tauri-emmc/phytec,imx6ull-phygate-tauri-nand.


> +          - const: phytec,imx6ull-pcl063        # PHYTEC phyCORE-i.MX 6ULL
> +          - const: fsl,imx6ull
> +
>        - description: i.MX6ULL Boards with Toradex Colibri iMX6ULL Modules
>          items:
>            - enum:
> -- 
> 2.25.1
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-12-13 19:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-01 12:53 [PATCH 0/4] PHYTEC i.MX 6UL/ULL devicetree patches Andrej Picej
2021-12-01 12:53 ` [PATCH 1/4] dt-bindings: arm: fsl: add PHYTEC phyGATE Tauri i.MX6 ULL Andrej Picej
2021-12-13 19:15   ` Rob Herring [this message]
2021-12-16  8:45     ` Andrej Picej
2021-12-01 12:53 ` [PATCH 2/4] ARM: dts: imx6ull: Add support for PHYTEC phyGATE-Tauri-S with i.MX 6ULL Andrej Picej
2021-12-01 12:53 ` [PATCH 3/4] ARM: dts: imx6ul: phycore: Change USB LDO voltage for usb compliance Andrej Picej
2021-12-01 12:53 ` [PATCH 4/4] ARM: dts: imx6ul: peb-av-02: move to 3 cell pwm Andrej Picej
2021-12-13 16:13 ` [PATCH 0/4] PHYTEC i.MX 6UL/ULL devicetree patches Arnd Bergmann
2021-12-16  7:13   ` Andrej Picej

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ybeb5I/mP3JFrDsQ@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=andrej.picej@norik.com \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux@rempel-privat.de \
    --cc=shawnguo@kernel.org \
    --cc=soc@kernel.org \
    --cc=y.bas@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).