From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CEE33C433F5 for ; Tue, 14 Dec 2021 05:58:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X5Tk9ZNBuvjQlmuzuIuxOM0+bkHAH26nnZspWv5hR74=; b=e5GFL3Yuu5tol/ VFD5N3vRz3d6XZhLz7WZnJfXaKAhp8V9wzKsLsV+vapTxj0/MbiyB5upryK8uEq8xj51iFzFyI1GC oP0H6H9m/NrJ0VnpnTEPzCsLLdeI3pdW3AMXKf0hrPzvi1UYpxmYlrVV3PoEUfWILb0UChoRm2J+I 7/0H/wN8q9VrRTdoVRaJcoxEvxP9BeLLpNm2D6HS2w1gKYqVQbE0PCJ7XZQvt3EipXD9BfmLPSnSG 0NCVkXh3vLNrMTCnV2UufKBKk4nT2IbqwuhvmfWCJDKlIkJLIMR5ejSoW/2HNmUl40oxKmGAb1Tec fKbuqImLwFHSMJAx/I1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx0oE-00CgPn-BA; Tue, 14 Dec 2021 05:57:06 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx0oA-00CgOZ-Eg for linux-arm-kernel@lists.infradead.org; Tue, 14 Dec 2021 05:57:03 +0000 Received: by mail-pj1-x1031.google.com with SMTP id r34-20020a17090a43a500b001b0f0837ce8so233733pjg.2 for ; Mon, 13 Dec 2021 21:57:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WfE+wbkqI+wZX/Nt24yen2hhvEvQ62avzsLaxrCH6po=; b=LX/rZ2XNoZ8aZDADViviPIV7fUNYgAFRpeK6fHXvu0+OKM29oi66PUKjvjKsb41T/Q 8Y2qf0mU4AXnfyH7xyyp5lWq7K8csvLN3LOJC9sdfFlL0op4MgGFC2l3WfRkX3NosmYw HXAmou7os73kBsBNZga4lvnIst4vksdkmkSS9tNQ4pWgZI6d9Evg0q9pkfjLofJa1/VN 0hn+Fm9lGMRNUIw6NgpqwaukQvtIrWfnDYR397xwDDSZMmpQJcqy7mfdk5jmQw4HHJ2y o0uaW0i6P3PngX9yXjB168q/cCa5Taxwl7gx0FlVlr8x6CNxJjlGhGT4DtrTu0t/ftat 4a4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WfE+wbkqI+wZX/Nt24yen2hhvEvQ62avzsLaxrCH6po=; b=ohozoZc2Czy9Bzaig+Y0ShMhRiYvGESdC3+niRjV9nXRJc6H5V/SC/hsIXhJWPohoI 4xuZbMZjgi8zMVnFK+ccjKIik3FDtS9vpvsFXhppxn97BHxqIFEV4/t89u2OVnGHQiuW 7+l3HdNZSQrQO4/nMmtU6s+q02DoGZ3dR0KKJoRUEZqaNCPrJRGdR9vaGfoHldcmy9aA LgEg8GqfCmz1To2j+DsYSMoIxGKbOObzaWTSlFoM2rn6VuErw6oVIJEOSc39Xp0olDse WQIP0VtQeI7BVyaWolXQAivnqfnlY4xqkATS5j0lEzO7L60Mp7KP/Q5PRQNKfRnziy7H jrIQ== X-Gm-Message-State: AOAM533GFdlJB5a9B1H5gsw2bu9Fx2/JCL5AXzZE6gJ3UwvQcwkyKkx8 LQHuaTB4U0PUBsbBq4c3s58= X-Google-Smtp-Source: ABdhPJzUmbQbD/etyqZzwo4+YKtCeADyU5CmvMU6nfCUIlCCyuPHtKpfnsqlS9l0fgqHq9Vxn0wnig== X-Received: by 2002:a17:902:da8e:b0:141:fa9d:806d with SMTP id j14-20020a170902da8e00b00141fa9d806dmr3267729plx.26.1639461421243; Mon, 13 Dec 2021 21:57:01 -0800 (PST) Received: from localhost ([110.141.142.237]) by smtp.gmail.com with ESMTPSA id k18sm16155735pfc.155.2021.12.13.21.56.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Dec 2021 21:57:00 -0800 (PST) Date: Tue, 14 Dec 2021 16:56:57 +1100 From: Balbir Singh To: Leo Yan Cc: "David S. Miller" , Jakub Kicinski , Leon Romanovsky , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Alexander Shishkin , Jan Harkes , coda@cs.cmu.edu, Paul Moore , Eric Paris , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, codalist@coda.cs.cmu.edu, linux-audit@redhat.com Subject: Re: [PATCH v2 6/7] audit: Use task_is_in_init_pid_ns() Message-ID: References: <20211208083320.472503-1-leo.yan@linaro.org> <20211208083320.472503-7-leo.yan@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211208083320.472503-7-leo.yan@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_215702_520236_5DAAAA1C X-CRM114-Status: GOOD ( 16.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 08, 2021 at 04:33:19PM +0800, Leo Yan wrote: > Replace open code with task_is_in_init_pid_ns() for checking root PID > namespace. > > Signed-off-by: Leo Yan > --- > kernel/audit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/audit.c b/kernel/audit.c > index 121d37e700a6..56ea91014180 100644 > --- a/kernel/audit.c > +++ b/kernel/audit.c > @@ -1034,7 +1034,7 @@ static int audit_netlink_ok(struct sk_buff *skb, u16 msg_type) > case AUDIT_MAKE_EQUIV: > /* Only support auditd and auditctl in initial pid namespace > * for now. */ > - if (task_active_pid_ns(current) != &init_pid_ns) > + if (!task_is_in_init_pid_ns(current)) > return -EPERM; > > if (!netlink_capable(skb, CAP_AUDIT_CONTROL)) > -- > 2.25.1 > Acked-by: Balbir Singh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel