linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	llvm@lists.linux.dev
Subject: Re: [PATCH v2] arm64/xor: use EOR3 instructions when available
Date: Tue, 14 Dec 2021 11:36:24 +0000	[thread overview]
Message-ID: <YbiBuI0XvpWXqbki@arm.com> (raw)
In-Reply-To: <CAMj1kXGadU-_dM9OtXzy6OqKqReYyzEB-F6NVwDOEodpzwtemw@mail.gmail.com>

On Tue, Dec 14, 2021 at 12:05:34PM +0100, Ard Biesheuvel wrote:
> On Tue, 14 Dec 2021 at 09:19, Ard Biesheuvel <ardb@kernel.org> wrote:
> >
> > + Arnd
> >
> > On Tue, 14 Dec 2021 at 03:37, Nathan Chancellor <nathan@kernel.org> wrote:
> > >
> > > Hi Ard,
> > >
> > > On Mon, Dec 13, 2021 at 03:02:52PM +0100, Ard Biesheuvel wrote:
> > > > Use the EOR3 instruction to implement xor_blocks() if the instruction is
> > > > available, which is the case if the CPU implements the SHA-3 extension.
> > > > This is about 20% faster on Apple M1 when using the 5-way version.
> > > >
> > > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> > >
> > > Our CI reported that this patch as commit ce9ba49a2460 ("arm64/xor: use
> > > EOR3 instructions when available") in the arm64 tree breaks
> > > allyesconfig:
> > >
> > > https://github.com/ClangBuiltLinux/continuous-integration2/runs/4514540083?check_suite_focus=true
> > >
> > > I also see this when building with GCC 11.2.0:
> > >
> > > WARNING: modpost: EXPORT symbol "xor_block_inner_neon" [vmlinux] version ...
> > > Is "xor_block_inner_neon" prototyped in <asm/asm-prototypes.h>?
> > > aarch64-linux-gnu-ld: arch/arm64/lib/xor-neon.o: relocation R_AARCH64_ABS32 against `__crc_xor_block_inner_neon' can not be used when making a shared object
> >
> > I suspect this is another genksyms crash, preventing the
> > __crc_xor_block_inner_neon symbol from ever being emitted.
> >
> > This is a recurring annoyance and I am not sure how to address this
> > properly. Arnd might have some thoughts on the matter as well.
> 
> I managed to reproduce this: it's not a crash but definitely a bug in
> genksyms, as it simply fails to produce the output containing the
> assignment of __crc_xor_block_inner_neon.
> 
> Moving the definition of xor_block_inner_neon as below works around the issue.
> 
> Catalin: would you like me to spin a v3? Or do your prefer to just
> fold this into the existing one?

I'll fold it in. Thanks.

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-12-14 11:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13 14:02 [PATCH v2] arm64/xor: use EOR3 instructions when available Ard Biesheuvel
2021-12-13 19:19 ` Catalin Marinas
2021-12-14  2:36 ` Nathan Chancellor
2021-12-14  8:19   ` Ard Biesheuvel
2021-12-14 11:05     ` Ard Biesheuvel
2021-12-14 11:36       ` Catalin Marinas [this message]
2021-12-14 12:57         ` Ard Biesheuvel
2021-12-15 15:15           ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YbiBuI0XvpWXqbki@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=llvm@lists.linux.dev \
    --cc=mark.rutland@arm.com \
    --cc=nathan@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).