From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78810C433EF for ; Tue, 14 Dec 2021 11:38:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QHjw4Xluu2uOxQSl5QTs7VUpo6uQEnXsEdX9fhDIWTg=; b=zxfz7CQG6Ahw5C hzg6pXz/TSVFV9mVNi9QhL0wSOOdSvZsoiq7HSvQ3KA4PKUr1c33hB85TQAf6/IPqFAq0IXrzXFZ7 GZhLCPBzdOoh9F41gVgpjNOjfsIz+q6lD3RayI+x8Zt+NwOySiZCSGn7Jrq4GbHwv+eKuneAbOi7N pj89GSDEygUHsBT2G6YUnSSOlCt9d6YDwuQGthdz2TstONZpN6gOKc1AhXlVYo7WGBUSROjNM1RZy OQH6IdebouDRXzV9e8+Op3Ev1iwB1CRsEz37ucmmSGL7S9kTpqxkQbsZpm63WnhpiUL6PVN9c0vIm /oVzPVwOBSA+84H7q1TQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx66j-00DiVf-T8; Tue, 14 Dec 2021 11:36:34 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx66g-00DiVK-D7 for linux-arm-kernel@lists.infradead.org; Tue, 14 Dec 2021 11:36:31 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DC543612E5; Tue, 14 Dec 2021 11:36:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9E65C34605; Tue, 14 Dec 2021 11:36:27 +0000 (UTC) Date: Tue, 14 Dec 2021 11:36:24 +0000 From: Catalin Marinas To: Ard Biesheuvel Cc: Nathan Chancellor , Arnd Bergmann , Linux ARM , Will Deacon , Mark Rutland , llvm@lists.linux.dev Subject: Re: [PATCH v2] arm64/xor: use EOR3 instructions when available Message-ID: References: <20211213140252.2856053-1-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211214_033630_532479_907B873B X-CRM114-Status: GOOD ( 27.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 14, 2021 at 12:05:34PM +0100, Ard Biesheuvel wrote: > On Tue, 14 Dec 2021 at 09:19, Ard Biesheuvel wrote: > > > > + Arnd > > > > On Tue, 14 Dec 2021 at 03:37, Nathan Chancellor wrote: > > > > > > Hi Ard, > > > > > > On Mon, Dec 13, 2021 at 03:02:52PM +0100, Ard Biesheuvel wrote: > > > > Use the EOR3 instruction to implement xor_blocks() if the instruction is > > > > available, which is the case if the CPU implements the SHA-3 extension. > > > > This is about 20% faster on Apple M1 when using the 5-way version. > > > > > > > > Signed-off-by: Ard Biesheuvel > > > > > > Our CI reported that this patch as commit ce9ba49a2460 ("arm64/xor: use > > > EOR3 instructions when available") in the arm64 tree breaks > > > allyesconfig: > > > > > > https://github.com/ClangBuiltLinux/continuous-integration2/runs/4514540083?check_suite_focus=true > > > > > > I also see this when building with GCC 11.2.0: > > > > > > WARNING: modpost: EXPORT symbol "xor_block_inner_neon" [vmlinux] version ... > > > Is "xor_block_inner_neon" prototyped in ? > > > aarch64-linux-gnu-ld: arch/arm64/lib/xor-neon.o: relocation R_AARCH64_ABS32 against `__crc_xor_block_inner_neon' can not be used when making a shared object > > > > I suspect this is another genksyms crash, preventing the > > __crc_xor_block_inner_neon symbol from ever being emitted. > > > > This is a recurring annoyance and I am not sure how to address this > > properly. Arnd might have some thoughts on the matter as well. > > I managed to reproduce this: it's not a crash but definitely a bug in > genksyms, as it simply fails to produce the output containing the > assignment of __crc_xor_block_inner_neon. > > Moving the definition of xor_block_inner_neon as below works around the issue. > > Catalin: would you like me to spin a v3? Or do your prefer to just > fold this into the existing one? I'll fold it in. Thanks. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel