From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E32BC433EF for ; Tue, 14 Dec 2021 13:43:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A1VbziH9ep0o4YcD4Q7UzjxCBrt3Us3158/8LGTInaA=; b=oBwIcDjNxfZuq/ CfHLfUpnixZzi5oApLrX6+fEUS0S5tADxhfWtca0YkH8hO/EZZEBqLXjLvcFbNgyXT+tPP2ZCobyM IvtCOpwpivnbmRFfycXuv7gE9+APKZknheP2WxugH8rC/EAcUVoLEKv7Z4UQ8dY+1oX112GttqDW3 5G4KfaKRvO/yhBeQ1acnZXbLWX5i7XG0bNC59ZWbpFT0A/MkhvztO1OeUwZ+clKBCwjL5NGUY0Fyq kCNABDkpix837wdca3KzWxNR56/GM1Y80OoJv5dU9a/UDOHvmdtm3XcTIXQr2R4kT4QSqd3Yo6Btc gH4hby3yhNlmUaLc4yug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx83n-00ECsr-Ib; Tue, 14 Dec 2021 13:41:39 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx83k-00ECrr-0J for linux-arm-kernel@lists.infradead.org; Tue, 14 Dec 2021 13:41:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+ZUy/3bMM7/nmZFCJ5b7/UZFV+jJUEvufcYBfP6xYjU=; b=GfKi/11PrvYEx70EAaVLotr8vc zwwEmFew961wkODoSjsPlgKLxJJLLuFRvPPz1AQYqv5k95pVFT/vVlL3cgulHFAX4S1nFSd274l6r BH76AFMYPU0k/fa2zxiiGVgoWJ+K452iLUuIDmJBjr8PZ5J+Jvl9bUK9Attte+ZymDz/hFgdU9GTc Dwgg19UYxQm42eDgFpTLLQ5iTPyaQJ5kVCWardrCjqQOiagnANJ3i923Or+klVnYckY6Ffpk/Z3Hu cZiA9PZs+ecltJtRGxvkTq8dfyy3s+RXpEUcGH3YeD+ydtVZraiXQRgD+4KAkM8OZL48mehP/0JBP oyAAc6qg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56274) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mx83g-0004z8-QE; Tue, 14 Dec 2021 13:41:32 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mx83d-0003YC-K6; Tue, 14 Dec 2021 13:41:29 +0000 Date: Tue, 14 Dec 2021 13:41:29 +0000 From: "Russell King (Oracle)" To: Andy Shevchenko Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Lunn , Sebastian Hesselbarth , Gregory Clement Subject: Re: [PATCH v1 1/1] ARM: orion/gpio: Get rid of unused first parameter in orion_gpio_init() Message-ID: References: <20211214133243.53199-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211214133243.53199-1-andriy.shevchenko@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211214_054136_066550_02E204E8 X-CRM114-Status: GOOD ( 10.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 14, 2021 at 03:32:43PM +0200, Andy Shevchenko wrote: > The OF node pointer is always NULL, get rid of unused parameter in > orion_gpio_init(). As a side effect it will allow to switch GPIO > library to the fwnode API, as well as in case of resurrecting it here > it should be fwnode_handle anyways. Please ensure the new code follows the existing style - especially in terms of wrapping. Some of us still use 80 columns as a general rule. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel