From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8724C433F5 for ; Tue, 14 Dec 2021 14:01:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AS9Rt1KKeY/5bsauNyGY+Wlv9PF9cwSk+knMTIOErm8=; b=N4HLcWKL0xQIyc o+gBbN1/57vpkdvFAyxbbx9KwYAVgvtyykkhks/TVh9LNREUub4tewUBF4/v6qjtjX7h98PwfxVxV dkiFgToGioIDNyF2hweq1xCtfACoXPS2JxtoaGgmnhD+Qjfm3upDIgMvZY/KBCkf2h3/zrvjp3rz8 zS/vAuK/BX+q+n6XAN2/LeUG9JYZjo5owgRlKobZEsErkJ0uxuideEpwjbBOWZ7eRVeDjoc3omDjk 6FiB0CZavCtjRk8ymo/x3GFMOBHUCbem289gG+deR0ERjQi4GnTMtMdOZAnFidsh/dYfsjseRyW+V r1vyxovBgH+JgvKAOCEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx8LP-00EFbY-3A; Tue, 14 Dec 2021 13:59:51 +0000 Received: from mga01.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx8LL-00EFaU-Jg for linux-arm-kernel@lists.infradead.org; Tue, 14 Dec 2021 13:59:48 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10197"; a="263120760" X-IronPort-AV: E=Sophos;i="5.88,205,1635231600"; d="scan'208";a="263120760" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2021 05:59:45 -0800 X-IronPort-AV: E=Sophos;i="5.88,205,1635231600"; d="scan'208";a="545173484" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2021 05:59:43 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mx8KN-0069FM-6D; Tue, 14 Dec 2021 15:58:47 +0200 Date: Tue, 14 Dec 2021 15:58:46 +0200 From: Andy Shevchenko To: "Russell King (Oracle)" Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Lunn , Sebastian Hesselbarth , Gregory Clement Subject: Re: [PATCH v1 1/1] ARM: orion/gpio: Get rid of unused first parameter in orion_gpio_init() Message-ID: References: <20211214133243.53199-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211214_055947_689837_AFE9EDD1 X-CRM114-Status: GOOD ( 16.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 14, 2021 at 01:41:29PM +0000, Russell King (Oracle) wrote: > On Tue, Dec 14, 2021 at 03:32:43PM +0200, Andy Shevchenko wrote: > > The OF node pointer is always NULL, get rid of unused parameter in > > orion_gpio_init(). As a side effect it will allow to switch GPIO > > library to the fwnode API, as well as in case of resurrecting it here > > it should be fwnode_handle anyways. > > Please ensure the new code follows the existing style - especially in > terms of wrapping. Some of us still use 80 columns as a general rule. > Thanks. Ah, okay, I will fix that for v2. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel