From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5421C433F5 for ; Tue, 14 Dec 2021 14:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LqBfbahw/Vz1KVu2aV0QR4W3tkSl0YxYxFs+fdC0dtY=; b=IhI4ZUPfEbiBjDm4eFrv2okqHv lIogm9b3e7YatSIsMox6qJ98iFxmGg/GC7lS1DY/nEEP9pMALvWbjsnsLDtJXi6kJUI3kq7SS9k6R b3hFuTsliXS1aeH9NoHL3UKQTlwwRhgXqGd4pU3ulSa9N6MVbE/6BUmkZGAaCPx8ssP+3VZLGMecL F7/NpluHKwXY2LW8U+g2lyYMihzbYg+JtVnoWGlvTNXteNWcW3CT22/yKZq0GJfrlAdB+mt8JT1aP htwUGA5voNqivDAm7QZuENL3ryf4Wx3HAK9HgZ6QVyJBy6MnpP/PGpyBP9IE6iJki6XXDzG/QSKRm +ej102+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx9G3-00EXu1-U1; Tue, 14 Dec 2021 14:58:24 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx9Fz-00EXsp-L6 for linux-arm-kernel@lists.infradead.org; Tue, 14 Dec 2021 14:58:21 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4F526B81A03; Tue, 14 Dec 2021 14:58:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C56F6C34605; Tue, 14 Dec 2021 14:58:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1639493897; bh=oMdlxXHv1FFR923y2C2HIyAH/LOsNMQ3F2dF06Y2ESY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MFoVTqKM/zaDePjx8VhqLcuqE/oG56sGSw4ckOJ+7KRPXsPSmAZnInMK/zYyWcaOG NW02vybYODeVsEFpvraqNpgHRKq+IlLFndhpTaTTmwfdypAIJ8Iuz6WNJkeiTz59M8 zITyD8BC/YZ1Tw1nIrWW/+UC9Y5t9RPScap6y6HSZ/x0lKw+xlmsNuR3ejp8EKhv9R Dcun0KFlkzudx89YtVmz5YJOrDklFTiF6TlUym+AUOBm7ZeTpoeee0M3L0jiZEEiHb GGegDOuzrRJcABTSTcus1vifC5FvCj1D9fXcRjvhZ8gwmv3Br0oF/fgRqfPuXB6b2H XTYh0Dv92WSPQ== Date: Tue, 14 Dec 2021 14:58:12 +0000 From: Mark Brown To: Ard Biesheuvel Cc: Will Deacon , Catalin Marinas , Mark Rutland , Linux ARM Subject: Re: [PATCH v3 2/2] arm64: Unconditionally override SYM_FUNC macros Message-ID: References: <20211208160819.3515958-1-broonie@kernel.org> <20211208160819.3515958-3-broonie@kernel.org> <20211213184654.GG12405@willie-the-truck> <20211214141022.GA14661@willie-the-truck> MIME-Version: 1.0 In-Reply-To: X-Cookie: No solicitors. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211214_065819_870550_BF80D1F6 X-CRM114-Status: GOOD ( 23.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3668838101461031800==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3668838101461031800== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="21pg29VIrZu/daWf" Content-Disposition: inline --21pg29VIrZu/daWf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 14, 2021 at 03:31:07PM +0100, Ard Biesheuvel wrote: > On Tue, 14 Dec 2021 at 15:28, Mark Brown wrote: > > > I already pointed out computed gotos, which are admittedly rare, but > > > there are other reasons why adhering to WYSIWYG is strongly preferred > > > for asm code IMO. > > The use case for this macro is for SYM_FUNC_START() which is going to be > > emitting the BTI without it really appearing directly in the code so I'm > > not sure how much I buy that TBH. I think you're pushing back on uses > > of the macro outside of linkage.h more than on what linkage.h is doing, > > that does make more sense to me. > Fair point, but we don't really have any control over where else BTI_C > may end up being used, no? It's also a macro, which should put people off, and there's precious little arm64 asm outside of arch/arm64 so I'm not sure how worried I am about that. > In any case, I don't think it's worth it blowing up the validation > matrix over this, so if we can emit the same code for all > configurations, we should IMO We could have been doing that since the BTI kernel support was originally merged... TBH I'm just really surprised everyone's pushing to generate worse code here, feels not the direction people usually go in. --21pg29VIrZu/daWf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmG4sQMACgkQJNaLcl1U h9BaIAf/R4m/6//F7Gk/pDTE+pHae+zrDqZzRUMcKV96eWEJwNK33C0vX5joXfwL dW0R4h8Ok0dvg7pJpGLuXsKYZ7YIeEYC6miw+Ao6VBerq3sdWssTHhsPn1wH51vE zKV2OPgvwY5f3642H/nVlPh1eFNXL/ybzEKNtrTJ2WzR89fGiAyzcOxheNr9g2KE 4hjJcxV5lK9Wc2zyL/OHCD0f/qesDSYCul4ZwuRCQcLwjSeHIcMkBK9Gqjm6Mm0I VAMU2QU7BErJz1ztNrWRm6O1hPw+Ypu3zIs/yvWv/KhrSfSnNAeaB9uvC42+F64D hejG61s9Bkbc6cZeA1x6P58iM9jwew== =yLpY -----END PGP SIGNATURE----- --21pg29VIrZu/daWf-- --===============3668838101461031800== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3668838101461031800==--