From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A64BC433EF for ; Wed, 15 Dec 2021 09:25:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Dl3UHTeZKiG+Gp+7pHDGLoH3UexynGgWVfcWfmqEBUU=; b=JY32GhQkVbuIRB FUUwB8KDB4uJeOZXwzAvdwnoEhDk1TCft4py8abp+wqHeeFM0MJib70VC8e7IgdC6xNpLVihXd1Tf +HB37HRTaBDKrbEkEm381zVkmjm54dYfF6Tev3AOfsIrRgf2gVYFgIlvtVc6S/UE7OeSiiWVmaXSt 7FYdU0D5uhCvp4pDe6XpHh6KfJPqoFpnZtxxwHCA1mej+90fqXZEfapP8B6fLBC9VVrzYzTpLME+P LAEUqKYipNX/DYcDqol/Gn4U45KgGL7k6spq36Ny8JTiNmUOF5hRSqrLcEcC3vV8yeYVS+MKTZbtq DnX0KUTw1/Y3Z3ZTRL1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxQWZ-00HUbu-Au; Wed, 15 Dec 2021 09:24:35 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxQWV-00HUaT-MR for linux-arm-kernel@lists.infradead.org; Wed, 15 Dec 2021 09:24:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 977C86D; Wed, 15 Dec 2021 01:24:30 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.66.121]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4D69C3F5A1; Wed, 15 Dec 2021 01:24:28 -0800 (PST) Date: Wed, 15 Dec 2021 09:24:22 +0000 From: Mark Rutland To: Catalin Marinas Cc: linux-kernel@vger.kernel.org, Borislav Petkov , Jiri Slaby , Josh Poimboeuf , Peter Zijlstra , ardb@kernel.org, broonie@kernel.org, dave.hansen@linux.intel.com, linux-arm-kernel@lists.infradead.org, maz@kernel.org, mingo@redhat.com, tabba@google.com, tglx@linutronix.de, will@kernel.org Subject: Re: [RFC PATCH 0/6] linkage: better symbol aliasing Message-ID: References: <20211206124715.4101571-1-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211215_012431_805653_0F922C12 X-CRM114-Status: GOOD ( 24.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 10, 2021 at 03:04:45PM +0000, Catalin Marinas wrote: > On Mon, Dec 06, 2021 at 12:47:09PM +0000, Mark Rutland wrote: > > This series aims to make symbol aliasing simpler and more consistent. > > The basic idea is to replace SYM_FUNC_START_ALIAS(alias) and > > SYM_FUNC_END_ALIAS(alias) with a new SYM_FUNC_ALIAS(alias, name), so > > that e.g. > > > > SYM_FUNC_START(func) > > SYM_FUNC_START_ALIAS(alias1) > > SYM_FUNC_START_ALIAS(alias2) > > ... asm insns ... > > SYM_FUNC_END(func) > > SYM_FUNC_END_ALIAS(alias1) > > SYM_FUNC_END_ALIAS(alias2) > > EXPORT_SYMBOL(alias1) > > EXPORT_SYMBOL(alias2) > > > > ... can become: > > > > SYM_FUNC_START(name) > > ... asm insns ... > > SYM_FUNC_END(name) > > > > SYM_FUNC_ALIAS(alias1, func) > > EXPORT_SYMBOL(alias1) > > > > SYM_FUNC_ALIAS(alias2, func) > > EXPORT_SYMBOL(alias2) > > > > This avoids repetition and hopefully make it easier to ensure > > consistency (e.g. so each function has a single canonical name and > > associated metadata). > > > > I'm sending this as an RFC since I want to check: > > > > a) People are happy with the idea in principle. > > > > b) People are happy with the implementation within . > > > > ... and I haven't yet converted the headers under tools/, which is > > largely a copy+paste job. > > I'm happy with the approach and acked the arm64 patches for the record. > Not sure how/when this series will get into mainline. Thanks! As to "when", I think I'm going to rework the series atop v5.17-rc1, so for now would you be happy to pick patch 3 ("arm64: remove __dma_*_area() aliases"): https://lore.kernel.org/linux-arm-kernel/20211206124715.4101571-4-mark.rutland@arm.com/ ... into the arm64 tree? That'a a pure cleanup with no dependency on the rest of the series. For the rest of the series I still need to to the mechanical work for tools/, there's a token-pasting issue on 32-bit arm, and I'd like to give this a long soak in -next, so earlier in the next window seems like a better bet. As for "how", I assume the core linkage bits will go via the tip tree, so I think it'd make sense for the (remaining) arch bits to go that way too. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel