From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D475C433EF for ; Thu, 16 Dec 2021 17:22:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LdMhGKOfyU5zvLJqrRWnzto+am+E0FIrIBq8m/XixSc=; b=Fom8LPM1WP3L8J AZB0Y+cTHlLM4Hq+K5XtvQnT0o8Vy5377yzHzpu88DGRLLwpv/S2qHq3jKfRiq0gAmBlQz7OdUDky wBKFMGnw+vvKZSN0SDoWpCyt2EizizUQ76HwocwOiwEwsryMZjt9BEwK4qCH6GJj/NzBcUPEa/Xau DTPbReHhv/LFAmqv6JX2Brj3UZtgUURujfK8d+8xbQEzGqEVqzPKbhh5wGlldQKnfxmy7ckok4UfD Y36m33oQRfK3P6KVxp7w2cyEima1ra30mok4AUT6nPZgYViioHnk/ynIDvVXwVPVOhGu153aW7yJA GDTAAfdKqAbjrz9nt60Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxuQ3-006rrx-Iw; Thu, 16 Dec 2021 17:19:52 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxu9C-006msI-Jt for linux-arm-kernel@lists.infradead.org; Thu, 16 Dec 2021 17:02:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dAv+6941GUlYCn6EN7S3a3W6nxnXx0JOcQPfX4r51CY=; b=ViGN84JwWl8YusSC3roViMSJqI d4KBKbOCiWtgMP14eQ1WFuo3TR7pnI+WklNzH1Pc7l+Cd8+u4CZu8sIyUjZI869Z4gccgqM7dEMKA dfbOThAhKTctKr3NzbJXVrlU6Ffah4fcP1dYDF1u4s7FUnJ8Qfs9h/TAwrKUvBJ4hHC3O7wrNMMaB wxkryS/IFlJrsr86eDAWqwu42fI5J+NQPRH/OStCEPI5fYuwkIV1AdjM7VIyv5CSn33WVv6nGf68F ig/WyHfTylJkKMKYvGLezN23t3agHoXBlip2c5Ng7mhpZZNv2pLt4DAGYMCwkgD01c52wO789BNws XPGrC8JQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56322) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mxu94-000875-DH; Thu, 16 Dec 2021 17:02:18 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mxu92-0005Yx-Fu; Thu, 16 Dec 2021 17:02:16 +0000 Date: Thu, 16 Dec 2021 17:02:16 +0000 From: "Russell King (Oracle)" To: Jakub Kicinski Cc: Michal Simek , Radhey Shyam Pandey , Sean Anderson , "David S. Miller" , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs Message-ID: References: <20211216071513.6d1e0f55@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211216071513.6d1e0f55@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211216_090226_699698_7A50DAC4 X-CRM114-Status: GOOD ( 13.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 16, 2021 at 07:15:13AM -0800, Jakub Kicinski wrote: > On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote: > > Convert axienet to use the phylink_pcs layer, resulting in it no longer > > being a legacy driver. > > > > One oddity in this driver is that lp->switch_x_sgmii controls whether > > we support switching between SGMII and 1000baseX. However, when clear, > > this also blocks updating the 1000baseX advertisement, which it > > probably should not be doing. Nevertheless, this behaviour is preserved > > but a comment is added. > > > > Signed-off-by: Russell King (Oracle) > > drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function parameter or member 'pcs' not described in 'axienet_local' Fixed that and the sha1 issue you raised in patch 2. Since both are "documentation" issues, I won't send out replacement patches until I've heard they've been tested on hardware though. Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel