From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8DDCC433EF for ; Fri, 31 Dec 2021 10:45:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C+V+Dg1JxBFRagq8TJKhjaxBFgsjNtTxdYPSvYzyzss=; b=qvjMqaJoFnmuFH Dm0iKoSan56ChBz1lW1qb00Cr26aN385BMO/O+gj5Fu8a6UoA3Vq95mxvm3IK2CCOgYmF6bLxLwqT EF7scJz1AoV+dD1cWOEJuuuqXc18lkjjDRlZFVlc6VX9aTssowTWVvQ82CXKg0WUNUMvhCtypqGj0 JRWo1SDvk79M/qRG7zYBshqNnw6+rdZfF9e0VoU1gdFweTyZTXMZPcTxYJqdt4FIXlBPIVppajeUd b8+KaJNjRZHCvpOKGmGjNvcPRjPcjUIKyvczGHUbJrz7Xh2lX1UfFuwGm9nWLnpaBeIFr8TBM1r85 r7VPW9rUccbM7yRXzkig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n3FOF-005xNY-G3; Fri, 31 Dec 2021 10:44:03 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n3FOC-005xMW-68 for linux-arm-kernel@lists.infradead.org; Fri, 31 Dec 2021 10:44:01 +0000 Received: by mail-wm1-x32f.google.com with SMTP id d198-20020a1c1dcf000000b0034569cdd2a2so14566293wmd.5 for ; Fri, 31 Dec 2021 02:43:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=bLUkTU6YF+8VLXQUQIWE9F/hQfPP+FolDFiTd3ZDtrs=; b=bmY1kbjIlV/sLw6YhqPG6UsoOX4iiCGCWwkkibgh5ixxQ8zdbpjVi0HUXeLfI9ELdE rGqCLvHCBDW+/qRxI1fur/cYvuGt7PU0tnaIw4dhjS+2KQ5ST5/V3bWySd8d1ZD6V/2b egZamqr04QzT8IhF2ZTU0idJTQSJHxetevaG04biYD4Su1cy+vYsJp4YWpSNkAvfvsXl WTYox+UlLJHQXCiyKl3bqRboxKW3PqBF7EEZGA3vTCIgF+xwMzBL9I8gX41UA40DV33s xZ4U7hvU6vmu7Qwm1ka5Xq2mp6K32Kmarc4UXIkOadVRR0TdjyHelHw0qtbnzli5tNlt p0AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=bLUkTU6YF+8VLXQUQIWE9F/hQfPP+FolDFiTd3ZDtrs=; b=m8tUEKAMCZFQz2c05rHjrapxIKcxwpM0cW6+JELp8vfY61SKgoCaGhh6NxgEj+9Ccz gx4a07S6GPcSZuqbOzAprijbmCdIkN5yutq5KFANyw5D/o2b29NWBop8SOVPjYB22Gdr DqwahyQq+8KDpRunM6vkxd/WWffmTIx+eARQHPPVG2NFc5/PXr0TdyX9rCCKRn/pZY2j MHaiaF7EkKdB0NzwR2hxvYO2pNNM4hhPsMUd/aQPg0RxEr6fLOwsm3dMm+o5V5etoPwI t/w2K9j4DZETbZqYcUo19AkBuGvy975YFQ36YsdZhg7rbHooM6op5jVTXTh4tMqNZMTH 2eMQ== X-Gm-Message-State: AOAM531LPc4RKkK68Nis8NkOR5Yy0qmxxjpgV48+ojPCCG7zrJcqC/9e IQds7s02ZlnyORCndm2WMLw= X-Google-Smtp-Source: ABdhPJwaB4oZMlIVWbJDarcy1yJ7NaobnlWBgzU0JfLp+wnpSa6WOB8j7cUNARKMaRDf+3/cuWS3cg== X-Received: by 2002:a05:600c:1991:: with SMTP id t17mr29701332wmq.21.1640947437988; Fri, 31 Dec 2021 02:43:57 -0800 (PST) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id b1sm29584285wrd.92.2021.12.31.02.43.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Dec 2021 02:43:57 -0800 (PST) Date: Fri, 31 Dec 2021 11:43:53 +0100 From: Corentin Labbe To: conleylee@foxmail.com Cc: davem@davemloft.net, kuba@kernel.org, mripard@kernel.org, wens@csie.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6] sun4i-emac.c: add dma support Message-ID: References: <20211228164817.1297c1c9@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211231_024400_268561_3057665D X-CRM114-Status: GOOD ( 15.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Le Wed, Dec 29, 2021 at 09:43:51AM +0800, conleylee@foxmail.com a =E9crit : > From: Conley Lee > = > Thanks for your review. Here is the new version for this patch. > = > This patch adds support for the emac rx dma present on sun4i. The emac > is able to move packets from rx fifo to RAM by using dma. > = > Change since v4. > - rename sbk field to skb > - rename alloc_emac_dma_req to emac_alloc_dma_req > - using kzalloc(..., GPF_ATOMIC) in interrupt context to avoid > sleeping > - retry by using emac_inblk_32bit when emac_dma_inblk_32bit fails > - fix some code style issues = > = > Change since v5. > - fix some code style issue > = Hello I just tested this on a sun4i-a10-olinuxino-lime I got: [ 2.922812] sun4i-emac 1c0b000.ethernet (unnamed net_device) (uninitiali= zed): get io resource from device: 0x1c0b000, size =3D 4096 [ 2.934512] sun4i-emac 1c0b000.ethernet (unnamed net_device) (uninitiali= zed): failed to request dma channel. dma is disabled [ 2.945740] sun4i-emac 1c0b000.ethernet (unnamed net_device) (uninitiali= zed): configure dma failed. disable dma. [ 2.957887] sun4i-emac 1c0b000.ethernet: eth0: at (ptrval), IRQ 19 MAC: = 02:49:09:40:ab:3d On which board did you test it and how ? Regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel