From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 481E1C433F5 for ; Mon, 20 Dec 2021 12:55:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1jCcgn759iOsCIkw7bV6lLz5rvLlc5qejN41HNFrs8Q=; b=hJW5EW17uI70//FpNM2AlSRrHA KbZCoHNasHCUeQfy6y4TNIkznKKvhCZAFJzobZK4dpNICZpeMYmEZ+Sy9k72uAw6vFYSr/DSf1awA QMcCL1EvWCL4ghBUWLaclQi8G+BfgHBisX0bSf7ZzcRPQNcs5jqN2u1w4RlsVYuEMJY13akDopYkd NyA94EDnSlFAW71DQBjvgDwM5iuRjNn+PkQjD+jD0UIU3yDyUlR0RP0tSWBbLaF3hEodhsXilp4ts RO3c6k1XtLKobXjcoXyoGN3XhDcbEsccS29e1hE0m79T7gPNtQPgkjKXbvYqfQwPUg2qxNnVHokHf kDu1mXWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzIBB-002Ohw-2h; Mon, 20 Dec 2021 12:54:13 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzIB7-002Ogr-0y; Mon, 20 Dec 2021 12:54:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 6B066CE1025; Mon, 20 Dec 2021 12:54:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC5C5C36AE8; Mon, 20 Dec 2021 12:54:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1640004843; bh=kzuh09N3lZQB4P3sI+KA33n3XKhJzPKm5UGyELBpO8U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GmeTQzmC7UyLbLb52JVSzYdlvvXfQ3/r2hvC/5bxUSlrNZlChIqHJFyg6O1tqKTKE gBnkeG1OTazQOzGv504GaUv1bZQf19l2u1qhn3inoxWjxY5fxnQe5VF3MYyfmyot4s p6UiVKbAhZlBdKHt7tOkQR3thKQPERpAunQThW2870fxstB5lVB7Baoa1T6FpRFo60 QaqOMahYD1AuMGst4548Dt/hXnTzVm+rl/9MxOf3o7yMDHVHeD1nGgQlwrfpTvx/8d C1bKCdiXNf34bhja5k68BZBwVS7vbHfdi4c2ZvFNuTiqTABJUI/Xh2a0fswB6TsRaZ APsJdlx8phUxg== Date: Mon, 20 Dec 2021 12:53:58 +0000 From: Mark Brown To: Sascha Hauer Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Heiko Stuebner , Michael Riesch , kernel@pengutronix.de, Robin Murphy Subject: Re: [PATCH 3/4] soc: rockchip: power-domain: Add regulator support Message-ID: References: <20211217130919.3035788-1-s.hauer@pengutronix.de> <20211217130919.3035788-4-s.hauer@pengutronix.de> <20211220094435.GU6003@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20211220094435.GU6003@pengutronix.de> X-Cookie: Christ was born in 4 B.C. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211220_045409_270260_CF53B86F X-CRM114-Status: GOOD ( 19.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5326997022159713972==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5326997022159713972== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XszC84mLEk37nJZH" Content-Disposition: inline --XszC84mLEk37nJZH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 20, 2021 at 10:44:35AM +0100, Sascha Hauer wrote: > Well, all true and on one specific board the regulator is indeed not > optional. However, on all other power domains that don't need a > regulator and all other boards and all other SoCs this driver is used we > now get: This seems unlikely to be board specific, if the chip requires power the chip requires power. If there are power domains that don't take external supplies then they shouldn't be requesting any regulators and should be fixed. > [ 0.185588] rk-power-domain rk-power-domain.8: supply power not found, using dummy regulator It seems vanishingly unlikely that the SoC takes a single supply called "power" shared by everything in the SoC but that is what the code appears to be requesting - the power domains should be requesting the supplies they actually use, and as ever the supplies should be named such that someone looking at the schematic can hook them up. The general recommendation is to use the names used in the datasheet. > I wonder if devm_regulator_get() is really the right function here. Or > should the message be dropped? No, the issue is that the client driver is badly written and needs to be fixed. In general it's probably better to have error handling than not. If you're getting lots of warnings about problems it's probably due to there being problems. --XszC84mLEk37nJZH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmHAfOYACgkQJNaLcl1U h9CAiAf/d7URmt7NhkFddipGuDRk/W4F+n2jP91AoaNVe99y7lDjy0GJJSX9zRZl OMeUAWcGZJ9H8c9eM/HJL5P3SBHsYJHNoWjiU586oFrNxboBTU693LlvKowt5or0 JCB8ypHP0eFVLCAiazgJjD68rWMtUm51AnsaKkr/ej2SN8SFG6eVVEP8VapKBfpr WMkrTTHORkhnuV7cp9mr9H5vprg88gBibRAjYuRlh92SPOug7UdCA0F23nRsH77X k40ZdPjEbnLCAlegY+Ns5zgvXAqczaiAyDBOvJZK1cD3YKeHRiZs4KeHg8ipLXd3 7T0MdsJVGXV6ekMP4tZG0eagDp2y/w== =cc56 -----END PGP SIGNATURE----- --XszC84mLEk37nJZH-- --===============5326997022159713972== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5326997022159713972==--