From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Thara Gopinath <thara.gopinath@linaro.org>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] cpufreq: qcom-cpufreq-hw: Avoid stack buffer for IRQ name
Date: Mon, 20 Dec 2021 15:43:31 -0800 [thread overview]
Message-ID: <YcEVIyZu/nfLSyfl@ripper> (raw)
In-Reply-To: <CAMZdPi9m_JJogxwT7k_0bzC9+gPxq9NHkuDF3T0HEj8EU-vd7w@mail.gmail.com>
On Mon 20 Dec 02:12 PST 2021, Loic Poulain wrote:
> > On 9/1/21 4:47 AM, Ard Biesheuvel wrote:
> > > Registering an IRQ requires the string buffer containing the name to
> > > remain allocated, as the name is not copied into another buffer.
> > >
> > > So let's add a irq_name field to the data struct instead, which is
> > > guaranteed to have the appropriate lifetime.
> > >
> > > Cc: Thara Gopinath <thara.gopinath@linaro.org>
> > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> > > Cc: Andy Gross <agross@kernel.org>
> > > Cc: linux-arm-msm@vger.kernel.org
> > > Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> >
> > Thanks for the fix.
> >
> > Reviewed-by: Thara Gopinath <thara.gopinath@linaro.org>
>
> Seems this patch has been overlooked. Would it be possible to resubmit
> it with a 'Fixes' tag?
>
This was resubmitted by Vladimir and Viresh replied that it's applied,
see:
https://lore.kernel.org/all/20211125065014.phkfugo2wptosrgv@vireshk-i7/
Regards,
Bjorn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-12-20 23:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 8:47 [PATCH] cpufreq: qcom-cpufreq-hw: Avoid stack buffer for IRQ name Ard Biesheuvel
2021-09-01 10:59 ` Steev Klimaszewski
2021-09-01 19:22 ` Thara Gopinath
2021-12-20 10:12 ` Loic Poulain
2021-12-20 23:43 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcEVIyZu/nfLSyfl@ripper \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=ardb@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=thara.gopinath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox