From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A84A8C433EF for ; Tue, 21 Dec 2021 06:21:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zSrbb2Pu4tEFDYjjS1GqvmdGuorWAE+Zjrrg6IbsHds=; b=X9kXkOBUrIBmRr xkOSIsX/+y6tkekK9/afIArtyNd29zBAaIwp2Y3ZOFJoyZVI3tRy6pmFv4wy7yqKrhCo7sZ8b6i0B 2D7mGPKFecj93f9dmNacGD2ZaKSYUdu6j0P2DrIH5oAR2foWOTeNQmXq5867okvTiZ07aj/ncRD9Q TrGj3fQNUTZV8vC1Oo0a6ral5jCq3IX/cX/uRR41LFQCuehVha/YY8Q9hrsAxlxlw5lPl7Lplw/UP qa3i5d844Ruoh4jIulYVbaz/J1VzO5gwk+/16DhmX3DyirpKL2tMVkUieN8sf/Z1GiZzIMRgMwlYM 4vVI7BSVslIuKG66Gj5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzYV6-005cOh-CQ; Tue, 21 Dec 2021 06:19:52 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzYV3-005cNd-9s; Tue, 21 Dec 2021 06:19:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A38876143A; Tue, 21 Dec 2021 06:19:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62232C36AE2; Tue, 21 Dec 2021 06:19:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1640067588; bh=sNp5KW8FciYVu7KbI/Elxa/BX747ZvrsGR5+FhLtjIk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VZcH5b57fUscJnA6P5MMxBLvC2bjVa75dma/Kd9sQ+IetW7UPmMeAOwh8zjokxS4w P6izh86sER6BJ4laszXI30ve5j0JbkoD2dojwGcT4ECHtt8lz70ZsmhrHpBGLojIhe XFwF1bR9V3f5IO76mlB/vLPbWnDiPhsAZaL3npyg= Date: Tue, 21 Dec 2021 07:19:45 +0100 From: Greg KH To: Gaston Gonzalez Cc: linux-staging@lists.linux.dev, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] staging: vc04_services: avoid the use of typedef for function pointers Message-ID: References: <7f681ccee713ef8600f40c765b6a59e119c6bf2c.1639858361.git.gascoar@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7f681ccee713ef8600f40c765b6a59e119c6bf2c.1639858361.git.gascoar@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211220_221949_452130_BEF0DB74 X-CRM114-Status: GOOD ( 17.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 20, 2021 at 06:29:12PM -0300, Gaston Gonzalez wrote: > Replace typedef bm2835_mmal_v4l2_ctrl_cb with equivalent declaration to > better align with the linux kernel coding style. > > Signed-off-by: Gaston Gonzalez > --- > .../vc04_services/bcm2835-camera/controls.c | 76 +++++++++---------- > 1 file changed, 35 insertions(+), 41 deletions(-) > > diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c > index b096a12387f7..7782742396fc 100644 > --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c > +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c > @@ -65,13 +65,6 @@ enum bm2835_mmal_ctrl_type { > MMAL_CONTROL_TYPE_CLUSTER, /* special cluster entry */ > }; > > -struct bm2835_mmal_v4l2_ctrl; > - > -typedef int(bm2835_mmal_v4l2_ctrl_cb)( > - struct bm2835_mmal_dev *dev, > - struct v4l2_ctrl *ctrl, > - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl); Function pointer typedefs are ok, if they are needed. > - > struct bm2835_mmal_v4l2_ctrl { > u32 id; /* v4l2 control identifier */ > enum bm2835_mmal_ctrl_type type; > @@ -84,7 +77,8 @@ struct bm2835_mmal_v4l2_ctrl { > u64 step; /* step size of the control */ > const s64 *imenu; /* integer menu array */ > u32 mmal_id; /* mmal parameter id */ > - bm2835_mmal_v4l2_ctrl_cb *setter; > + int (*bm2835_mmal_v4l2_ctrl_cb)(struct bm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, > + const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl); No need to rename this function pointer, why not keep it at "setter"? That would make this patch much smaller and more obvious. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel