From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3394C433F5 for ; Tue, 21 Dec 2021 15:08:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GW0xPplDHjE3kiz4XXrnaUfaWURbOJd2rfdl5feJ7BU=; b=kEXertY3xkLLBB MuR4EgwqPQzOIEjZXjN3KFQ517+0aU2UeydBaFpTz7LSW46XFACO4Aegzb74axKhk2bekCfYaEmcw S3MZVzkX7TMPFIm7Gq9TUykDYg19rhfzbTMcASnMjxH7hxn3B1+Ogigsf7aUJ9eCg7IVGVZcWTt+c ot9IKNjofOUuxkSePO0chBM4DSJjzcQzZeAuf/rK+yfIoP2QKLjhgQdmFtbzpNSS9qBSIkBr8GuaP n2DbwAxKHY+4ajsuQO8+pxeVSnFjd0q3UALOAIvAvJVPh8AlAnbo3frdREoctSYNhacrBuLmfNF1P idExardxnTnCs/V7tuIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzgio-007IVp-6i; Tue, 21 Dec 2021 15:06:36 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzgiZ-007IR0-DW for linux-arm-kernel@lists.infradead.org; Tue, 21 Dec 2021 15:06:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640099178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y2/5378vJkI/nGE10wiVmv6nrnuShHw+Qz8qvJTGnTc=; b=SFN2uXranBkf3/hI4NhGITupua/ZMj12QZSW9+Pp+QIThbPCSTGjQ01stntEBZqFfx0kaI vm3UiG/mzsrNItONVd4CPJbVl3sn6jZEk7HO/uCWHBSP1Ve5+tIN5eBQLHTMYplNjX0Vj8 c+vSBN1Ta9hX1/wFsAD6DbAzAamEpUc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-625-JV0mEnrrONiC2lrF4-Tmig-1; Tue, 21 Dec 2021 10:06:16 -0500 X-MC-Unique: JV0mEnrrONiC2lrF4-Tmig-1 Received: by mail-wm1-f71.google.com with SMTP id b20-20020a05600c4e1400b003457da1c91eso2219757wmq.4 for ; Tue, 21 Dec 2021 07:06:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=y2/5378vJkI/nGE10wiVmv6nrnuShHw+Qz8qvJTGnTc=; b=hZvBstU8Unl2Agceua1YLD+i9U+8HgcuPmh7g5XuiB53xh4NyVCxC3TXqYwRUQ2010 iG078PfcGfpXLADKRtipIKMI42aLuf49A4aKDcLFok7DYPnaURtVWT9xr3ER7NMzE/Ws hhbHv5GzZD+wZ9rZCL7cf3g/DR7eoPdZc5Me7sewGbBaM/UWwjscD2OVl7ku0wGSZow9 Mvyhid0kkXswp1aizTOEugmzq06XIxslz1owP9AsQ1KPRlLknavgExxwk6peFJOhgp8x qXUdhj9t4tqCdy0ALrJoyESDDuxxPH7BDvjBvlmcirZwOrfAa8TKJGe2/rO18aomlrE0 dSzg== X-Gm-Message-State: AOAM531Utm6UBRrskbtOYtAACUONSzZ1U3RFNaf1INLzzxXR9Ww63A+D ANkXKUV2qlaBzVJuTPUsuG8er6Kks/36/VSRv2qvDoY40GfPYZYj34JRlTHsGzYjt0lpAhiwMoG Ccq2oGsWjkKLDqVHB5Yh07QjDg/9MCpQgKnc= X-Received: by 2002:a05:6000:156b:: with SMTP id 11mr1089343wrz.261.1640099175700; Tue, 21 Dec 2021 07:06:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJzW2v8WERWGu+sSoYYkZhnbIfrNmbd8S4tpusx4TGNi3J5MHxBIJP6WocZBQnVYe+8cpWVYDg== X-Received: by 2002:a05:6000:156b:: with SMTP id 11mr1089322wrz.261.1640099175468; Tue, 21 Dec 2021 07:06:15 -0800 (PST) Received: from krava (nat-pool-brq-u.redhat.com. [213.175.37.12]) by smtp.gmail.com with ESMTPSA id w8sm18992648wre.106.2021.12.21.07.06.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Dec 2021 07:06:15 -0800 (PST) Date: Tue, 21 Dec 2021 16:06:13 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: German Gomez , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Alexandre Truong , John Garry , Will Deacon , Mathieu Poirier , Leo Yan , Mark Rutland , Alexander Shishkin , Namhyung Kim , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 6/6] perf arm64: inject missing frames if perf-record used "--call-graph=fp" Message-ID: References: <20211217154521.80603-1-german.gomez@arm.com> <20211217154521.80603-7-german.gomez@arm.com> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jolsa@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211221_070623_702197_E110F5B5 X-CRM114-Status: GOOD ( 31.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 21, 2021 at 11:17:03AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Dec 21, 2021 at 10:32:50AM +0100, Jiri Olsa escreveu: > > On Fri, Dec 17, 2021 at 03:45:20PM +0000, German Gomez wrote: > > > > SNIP > > > > > +} > > > + > > > +u64 get_leaf_frame_caller_aarch64(struct perf_sample *sample, struct thread *thread, int usr_idx) > > > +{ > > > + int ret; > > > + struct entries entries = {}; > > > + struct regs_dump old_regs = sample->user_regs; > > > + > > > + if (!get_leaf_frame_caller_enabled(sample)) > > > + return 0; > > > + > > > + /* > > > + * If PC and SP are not recorded, get the value of PC from the stack > > > + * and set its mask. SP is not used when doing the unwinding but it > > > + * still needs to be set to prevent failures. > > > + */ > > > + > > > + if (!(sample->user_regs.mask & SMPL_REG_MASK(PERF_REG_ARM64_PC))) { > > > + sample->user_regs.cache_mask |= SMPL_REG_MASK(PERF_REG_ARM64_PC); > > > + sample->user_regs.cache_regs[PERF_REG_ARM64_PC] = sample->callchain->ips[usr_idx+1]; > > > + } > > > + > > > + if (!(sample->user_regs.mask & SMPL_REG_MASK(PERF_REG_ARM64_SP))) { > > > + sample->user_regs.cache_mask |= SMPL_REG_MASK(PERF_REG_ARM64_SP); > > > + sample->user_regs.cache_regs[PERF_REG_ARM64_SP] = 0; > > > + } > > > + > > > + ret = unwind__get_entries(add_entry, &entries, thread, sample, 2); > > > > just curious, did you try this with both unwinders libunwind/libdw? > > > > any chance you could add arm specific test for this? > > > > otherwise it looks good to me > > Whole patchkit? yes, it's for the patchset jirka > > > Acked-by: Jiri Olsa > > > > thanks, > > jirka > > > > > > > + sample->user_regs = old_regs; > > > + > > > + if (ret || entries.length != 2) > > > + return ret; > > > + > > > + return callchain_param.order == ORDER_CALLER ? entries.stack[0] : entries.stack[1]; > > > +} > > > diff --git a/tools/perf/util/arm64-frame-pointer-unwind-support.h b/tools/perf/util/arm64-frame-pointer-unwind-support.h > > > new file mode 100644 > > > index 000000000000..32af9ce94398 > > > --- /dev/null > > > +++ b/tools/perf/util/arm64-frame-pointer-unwind-support.h > > > @@ -0,0 +1,10 @@ > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > +#ifndef __PERF_ARM_FRAME_POINTER_UNWIND_SUPPORT_H > > > +#define __PERF_ARM_FRAME_POINTER_UNWIND_SUPPORT_H > > > + > > > +#include "event.h" > > > +#include "thread.h" > > > + > > > +u64 get_leaf_frame_caller_aarch64(struct perf_sample *sample, struct thread *thread, int user_idx); > > > + > > > +#endif /* __PERF_ARM_FRAME_POINTER_UNWIND_SUPPORT_H */ > > > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > > > index 3eddad009f78..a00fd6796b35 100644 > > > --- a/tools/perf/util/machine.c > > > +++ b/tools/perf/util/machine.c > > > @@ -34,6 +34,7 @@ > > > #include "bpf-event.h" > > > #include // page_size > > > #include "cgroup.h" > > > +#include "arm64-frame-pointer-unwind-support.h" > > > > > > #include > > > #include > > > @@ -2710,10 +2711,13 @@ static int find_prev_cpumode(struct ip_callchain *chain, struct thread *thread, > > > return err; > > > } > > > > > > -static u64 get_leaf_frame_caller(struct perf_sample *sample __maybe_unused, > > > - struct thread *thread __maybe_unused, int usr_idx __maybe_unused) > > > +static u64 get_leaf_frame_caller(struct perf_sample *sample, > > > + struct thread *thread, int usr_idx) > > > { > > > - return 0; > > > + if (machine__normalize_is(thread->maps->machine, "arm64")) > > > + return get_leaf_frame_caller_aarch64(sample, thread, usr_idx); > > > + else > > > + return 0; > > > } > > > > > > static int thread__resolve_callchain_sample(struct thread *thread, > > > @@ -3114,14 +3118,19 @@ int machine__set_current_tid(struct machine *machine, int cpu, pid_t pid, > > > } > > > > > > /* > > > - * Compares the raw arch string. N.B. see instead perf_env__arch() if a > > > - * normalized arch is needed. > > > + * Compares the raw arch string. N.B. see instead perf_env__arch() or > > > + * machine__normalize_is() if a normalized arch is needed. > > > */ > > > bool machine__is(struct machine *machine, const char *arch) > > > { > > > return machine && !strcmp(perf_env__raw_arch(machine->env), arch); > > > } > > > > > > +bool machine__normalize_is(struct machine *machine, const char *arch) > > > +{ > > > + return machine && !strcmp(perf_env__arch(machine->env), arch); > > > +} > > > + > > > int machine__nr_cpus_avail(struct machine *machine) > > > { > > > return machine ? perf_env__nr_cpus_avail(machine->env) : 0; > > > diff --git a/tools/perf/util/machine.h b/tools/perf/util/machine.h > > > index a143087eeb47..665535153411 100644 > > > --- a/tools/perf/util/machine.h > > > +++ b/tools/perf/util/machine.h > > > @@ -208,6 +208,7 @@ static inline bool machine__is_host(struct machine *machine) > > > } > > > > > > bool machine__is(struct machine *machine, const char *arch); > > > +bool machine__normalize_is(struct machine *machine, const char *arch); > > > int machine__nr_cpus_avail(struct machine *machine); > > > > > > struct thread *__machine__findnew_thread(struct machine *machine, pid_t pid, pid_t tid); > > > -- > > > 2.25.1 > > > > > -- > > - Arnaldo > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel