From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E99E1C433EF for ; Tue, 21 Dec 2021 20:43:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZHk9cN4b9N4MnoZyiuY/B6EsmxVpUuqcSWRDFsd2qbg=; b=srp1FrK9T80meV my7eij99O1m7elsi5k4z3pFl3rhqGFLz9uyUeghcPZvAALRT+i4xWwriDkFmH+yfFxCJ7nxvWaVt7 0AEDqcrFf4cw8jfAHS5XkU2ak2/22TNAKzqacuAmlE6GF7Nif3sO0EBDa5IejyKCIxAbCVgtBd9v2 wlQpkLVGcy4Luu5LQpxw4gLSpCd+6GWKV83EXT5Y8WazJgevYG1yE/sTxecuxbraRkRbgCqEH7I7I nHVifVDQVnqHq94hlLq+PEySQPLqhvt2nnVJFk0iosWPOTL3wjr+i9SAn094irLUi6sFlsveYmo8l S6a15uz8mIogdFyb6NGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzlxI-008QWG-MH; Tue, 21 Dec 2021 20:41:52 +0000 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mzlxE-008QUB-Im; Tue, 21 Dec 2021 20:41:49 +0000 Received: by mail-qk1-x72f.google.com with SMTP id g28so244526qkk.9; Tue, 21 Dec 2021 12:41:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0L/zCdTzYL+bpasAbKxdwMufx6Ki92cX1lsoKE84Vow=; b=Th4r/bsQMnfzXLtz0OKCa8UfMb8HvudGBMXAYe5iT23P2800sYKRUunevTcnrnjKOW Xu72cQF+znRdJYd22sXrOx/OraCv7DB6XLZaP4HdEIIfZz5x67mkxYej8jogYcLTCLDd p8ykJf0v9nNWosEXLv5sb1FJvn4rBO9GYR9G+7uOt+L5ARuOVeXgopWr5oQXjFcH7aAm aGRIRWs5EDKb34aN6K3f2TFmFmgrFPgOneOMUH+b7ftIUjsoz46CKGpvAOyDPKvD2Jhp MwlJOD+kKZsiNcZ+VevuluRhsaXGUKmV6lgAKiFsPRaBWceSaZ6+ypVsfuU7MmjdojMA SyRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0L/zCdTzYL+bpasAbKxdwMufx6Ki92cX1lsoKE84Vow=; b=CoML9OC5egf1MaSRjLFg+HaaGVRcEIjMhjbARAGESxSeQfblsJHRo1VukjiNfhWr2l mHy2ADGITahEOe751uMJbGzZryPURWguaAij5/xEayGdLA6bbGTnSpc7UCHj3vgVUmZv rSNxk8w1tqkWtq+W5MFui96OifLPZOcNJX6pnT4UXQmkQpxA1Aiu+BgXZ0WyCx7UxqMh HtlDB24JKZ4VdxF+dc5EY9aw1yeQYano1hgP4obeMW4Cvc64rsd+SfR74PrW3T+PXvtS HkWWrrKCkQAMwBJhZE3RJbj8aTuiNPSheYFhop5JeUD/NvR0sk9G4DSxA/yhqFSS0YZZ 9Jbw== X-Gm-Message-State: AOAM530wNBODltC4v7lWeRSdjN+zunyJCeuY2cgmYF/UguxQs6KI2ekt JcgkeKggzaU3DjB/p1gcVnY= X-Google-Smtp-Source: ABdhPJygxTUYpfu/KJlTncs23BQYQ9IlPS+6EmdoAjQJ5no6Z/JqFkZRwEiDvjn0MaPp6ZMq2okYZQ== X-Received: by 2002:a05:620a:2494:: with SMTP id i20mr85971qkn.624.1640119307571; Tue, 21 Dec 2021 12:41:47 -0800 (PST) Received: from debianG ([190.191.20.243]) by smtp.gmail.com with ESMTPSA id n20sm50421qkp.65.2021.12.21.12.41.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Dec 2021 12:41:47 -0800 (PST) Date: Tue, 21 Dec 2021 17:41:46 -0300 From: Gaston Gonzalez To: Greg KH Cc: linux-staging@lists.linux.dev, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: Re: [PATCH 2/4] staging: vc04_services: avoid the use of typedef for function pointers Message-ID: References: <7f681ccee713ef8600f40c765b6a59e119c6bf2c.1639858361.git.gascoar@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211221_124148_653184_D6F5F140 X-CRM114-Status: GOOD ( 19.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 21, 2021 at 07:19:45AM +0100, Greg KH wrote: > On Mon, Dec 20, 2021 at 06:29:12PM -0300, Gaston Gonzalez wrote: > > Replace typedef bm2835_mmal_v4l2_ctrl_cb with equivalent declaration to > > better align with the linux kernel coding style. > > > > Signed-off-by: Gaston Gonzalez > > --- > > .../vc04_services/bcm2835-camera/controls.c | 76 +++++++++---------- > > 1 file changed, 35 insertions(+), 41 deletions(-) > > > > diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c > > index b096a12387f7..7782742396fc 100644 > > --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c > > +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c > > @@ -65,13 +65,6 @@ enum bm2835_mmal_ctrl_type { > > MMAL_CONTROL_TYPE_CLUSTER, /* special cluster entry */ > > }; > > > > -struct bm2835_mmal_v4l2_ctrl; > > - > > -typedef int(bm2835_mmal_v4l2_ctrl_cb)( > > - struct bm2835_mmal_dev *dev, > > - struct v4l2_ctrl *ctrl, > > - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl); > > Function pointer typedefs are ok, if they are needed. > > > - > > struct bm2835_mmal_v4l2_ctrl { > > u32 id; /* v4l2 control identifier */ > > enum bm2835_mmal_ctrl_type type; > > @@ -84,7 +77,8 @@ struct bm2835_mmal_v4l2_ctrl { > > u64 step; /* step size of the control */ > > const s64 *imenu; /* integer menu array */ > > u32 mmal_id; /* mmal parameter id */ > > - bm2835_mmal_v4l2_ctrl_cb *setter; > > + int (*bm2835_mmal_v4l2_ctrl_cb)(struct bm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, > > + const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl); > > No need to rename this function pointer, why not keep it at "setter"? > That would make this patch much smaller and more obvious. > Ok, will do that in v2. thanks, Gaston > thanks, > > greg k-h > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel