From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Serge Semin <fancer.lancer@gmail.com>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>
Subject: Re: [PATCH v1 1/3] spi: dln2: Propagate firmware node
Date: Wed, 22 Dec 2021 15:31:27 +0000 [thread overview]
Message-ID: <YcNEz2MaigJp0UAe@sirena.org.uk> (raw)
In-Reply-To: <20211222135423.62487-1-andriy.shevchenko@linux.intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 1381 bytes --]
On Wed, Dec 22, 2021 at 03:54:21PM +0200, Andy Shevchenko wrote:
> Propagate firmware node by using a specific API call, i.e. device_set_node().
This breaks at least an x86 allmodconfig build:
/mnt/kernel/drivers/spi/spi-dln2.c: In function 'dln2_spi_probe':
/mnt/kernel/drivers/spi/spi-dln2.c:691:32: error: implicit declaration of function 'dev_fwnode'; did you mean 'dev_of_node'? [-Werror=implicit-function-declaration]
691 | device_set_node(&master->dev, dev_fwnode(dev));
| ^~~~~~~~~~
| dev_of_node
/mnt/kernel/drivers/spi/spi-dln2.c:691:32: error: passing argument 2 of 'device_set_node' makes pointer from integer without a cast [-Werror=int-conversion]
691 | device_set_node(&master->dev, dev_fwnode(dev));
| ^~~~~~~~~~~~~~~
| |
| int
In file included from /mnt/kernel/include/linux/platform_device.h:13,
from /mnt/kernel/drivers/spi/spi-dln2.c:10:
/mnt/kernel/include/linux/device.h:854:64: note: expected 'struct fwnode_handle *' but argument is of type 'int'
854 | void device_set_node(struct device *dev, struct fwnode_handle *fwnode);
| ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
cc1: all warnings being treated as errors
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-22 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 13:54 [PATCH v1 1/3] spi: dln2: Propagate firmware node Andy Shevchenko
2021-12-22 13:54 ` [PATCH v1 2/3] spi: dw: " Andy Shevchenko
2021-12-22 13:54 ` [PATCH v1 3/3] spi: pxa2xx: " Andy Shevchenko
2021-12-22 15:31 ` Mark Brown [this message]
2021-12-22 15:51 ` [PATCH v1 1/3] spi: dln2: " Andy Shevchenko
2021-12-23 17:17 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcNEz2MaigJp0UAe@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=daniel@zonque.org \
--cc=fancer.lancer@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox