From: Vinod Koul <vkoul@kernel.org>
To: kernel test robot <lkp@intel.com>
Cc: Yifeng Zhao <yifeng.zhao@rock-chips.com>,
heiko@sntech.de, kbuild-all@lists.01.org, robh+dt@kernel.org,
jbx6244@gmail.com, devicetree@vger.kernel.org,
michael.riesch@wolfvision.net,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org
Subject: Re: [PATCH v5 3/4] phy: rockchip: add naneng combo phy for RK3568
Date: Thu, 23 Dec 2021 16:49:37 +0530 [thread overview]
Message-ID: <YcRbST7GDTNiZAkn@matsya> (raw)
In-Reply-To: <202112160605.2BqI0hlK-lkp@intel.com>
On 16-12-21, 06:47, kernel test robot wrote:
> Hi Yifeng,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on rockchip/for-next]
> [also build test ERROR on robh/for-next lee-mfd/for-mfd-next v5.16-rc5 next-20211214]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Yifeng-Zhao/Add-Naneng-combo-PHY-support-for-RK3568/20211215-180610
> base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
> config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20211216/202112160605.2BqI0hlK-lkp@intel.com/config)
> compiler: aarch64-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/0day-ci/linux/commit/5e4ddb08d86d5232174d88483f29e96272a4b6c0
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Yifeng-Zhao/Add-Naneng-combo-PHY-support-for-RK3568/20211215-180610
> git checkout 5e4ddb08d86d5232174d88483f29e96272a4b6c0
> # save the config file to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> drivers/phy/rockchip/phy-rockchip-naneng-combphy.c: In function 'rk3568_combphy_cfg':
> >> drivers/phy/rockchip/phy-rockchip-naneng-combphy.c:22:47: error: 'HZ_PER_MHZ' undeclared (first use in this function)
> 22 | #define REF_CLOCK_24MHz (24 * HZ_PER_MHZ)
> | ^~~~~~~~~~
You need to add the header to your driver for this
> drivers/phy/rockchip/phy-rockchip-naneng-combphy.c:490:14: note: in expansion of macro 'REF_CLOCK_24MHz'
> 490 | case REF_CLOCK_24MHz:
> | ^~~~~~~~~~~~~~~
> drivers/phy/rockchip/phy-rockchip-naneng-combphy.c:22:47: note: each undeclared identifier is reported only once for each function it appears in
> 22 | #define REF_CLOCK_24MHz (24 * HZ_PER_MHZ)
> | ^~~~~~~~~~
> drivers/phy/rockchip/phy-rockchip-naneng-combphy.c:490:14: note: in expansion of macro 'REF_CLOCK_24MHz'
> 490 | case REF_CLOCK_24MHz:
> | ^~~~~~~~~~~~~~~
>
>
> vim +/HZ_PER_MHZ +22 drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
>
> 20
> 21 #define BIT_WRITEABLE_SHIFT 16
> > 22 #define REF_CLOCK_24MHz (24 * HZ_PER_MHZ)
> 23 #define REF_CLOCK_25MHz (25 * HZ_PER_MHZ)
> 24 #define REF_CLOCK_100MHz (100 * HZ_PER_MHZ)
> 25
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-23 11:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 9:56 [PATCH v5 0/4] Add Naneng combo PHY support for RK3568 Yifeng Zhao
2021-12-15 9:56 ` [PATCH v5 1/4] dt-bindings: mfd: syscon: add naneng combo phy register compatible Yifeng Zhao
2021-12-15 9:56 ` [PATCH v5 2/4] dt-bindings: phy: rockchip: Add Naneng combo PHY bindings Yifeng Zhao
2021-12-15 9:56 ` [PATCH v5 3/4] phy: rockchip: add naneng combo phy for RK3568 Yifeng Zhao
2021-12-15 22:47 ` kernel test robot
2021-12-23 11:19 ` Vinod Koul [this message]
2021-12-15 9:56 ` [PATCH v5 4/4] arm64: dts: rockchip: add naneng combo phy nodes for rk3568 Yifeng Zhao
2021-12-16 12:19 ` Johan Jonker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcRbST7GDTNiZAkn@matsya \
--to=vkoul@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lkp@intel.com \
--cc=michael.riesch@wolfvision.net \
--cc=robh+dt@kernel.org \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).