From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56B1EC433EF for ; Thu, 13 Jan 2022 09:49:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=izrerR7GCXYvaYYfvgvEQGLRlDUAYG42THkCdTF2bk4=; b=x2hooyPmDcnl8I 8kAd6vnTZkRe91J5amxLG9BwqDmZgerPXzF1ZDQbfXqvQqjW9ozs20iVOzX96aDoHdmW2kYfP5eXP 10r5CU555O3moPyCNWflCAffOJBO50ET9MX9dW6JQT3KdBfNs7sGrdp+576rnLp26eQpzkyHOcn1n GUVI8omASgL3as7hstcllRfvIIB+K0ZkeJOElQTDpXphPw3dMlQ7tM3uCoHEwTGHq9b+2NK9mXqrW Y775G+wXMlH6za/RTv4Q9U7uKkzOgBUoEbCWsKS5bNn7OogffJtncKczLcf/jGsqfuTEtsTCf6zrV 8YkrgnqvRc6eMWV65+qQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7wi9-005J1v-56; Thu, 13 Jan 2022 09:48:01 +0000 Received: from mail-il1-x12e.google.com ([2607:f8b0:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7wi6-005J0G-1o for linux-arm-kernel@lists.infradead.org; Thu, 13 Jan 2022 09:47:59 +0000 Received: by mail-il1-x12e.google.com with SMTP id b1so5160346ilj.2 for ; Thu, 13 Jan 2022 01:47:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VWo9B0Tv8mi43ViWq+aiDlDVmkwKs71GLUZpT36kOp4=; b=OCPaMrLllRjPp0Q3sosTUuMWsMCfxUXcjgAnnv2JVOLJ7hkMIQmKJNzpLX4oeE3fWs lSwomygEO9uUL1/4mE4jHw8AMOvS3o+SRrDUnQw9uZD0NpLzs735YD8UIyb3YQpGYvUF bQsPo3MsajhcYkPhKGR8zMoyojl1NUGyD+5gW0aExAdbwMwxyjhjVOWqp7nkwGuwqM6T YyCFe+edDV8DL2ALzNAPvBc33BfNR4YtwNKnhDJQz6TLNDOIG4rDiE13fRgSh1uHfyqR wyzKz+wE/1lSZYpE5Zs8AQ0btVWIldQaceFKLCoV8hyqnKfM6YB5i8TWQgr31YUtAFcz xgjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VWo9B0Tv8mi43ViWq+aiDlDVmkwKs71GLUZpT36kOp4=; b=YlENrOGP+20LTN+Y9UbEQOtUONEttRAsqpYNv+RZvJxGk5fPMU1kU+UTRCT3Dz7lj4 Kl5aJseAjfrjKFIuEF0XO3GUJiJrURwIo2YmfkDhin7ZcCZlcFAknblob3nRFdoOdPPj 9T1EQt+Xd/1zPowGM8Q9WPo2B5YGb+/2nu6J7/55PvWDnqe7EdqTHZoVwDjC6RGCsieW 0TaUDJ/KWpuX+TO+d2pEi5rwF5r1JLSYXMPm8pyEKzchuk9rbV3oqYJBu5PspzdKov/i BhcErFxan0PghY68Zga2buiOinO72qS+ljwGa4sekV8qCnEx4ZdXx9pDnpkTCO+5Lnbx RHqw== X-Gm-Message-State: AOAM530xB6IFOZCqyDQYPqTx2dB3/suKIh8B/0AsUvhq8TrGunPYM1OP c/7w+8IWlzSXWtdpKpoWJMmXPw== X-Google-Smtp-Source: ABdhPJx0pnjkze3Ecby+3gkeeznELAZw2UJxt0ED2UO8PQR+olhMLA+rgGA4hoiD3ynF6pquSaR/aA== X-Received: by 2002:a92:c26c:: with SMTP id h12mr2016453ild.229.1642067275914; Thu, 13 Jan 2022 01:47:55 -0800 (PST) Received: from google.com ([2620:15c:183:200:ac2b:c4ef:2b56:374c]) by smtp.gmail.com with ESMTPSA id g6sm2357262iow.34.2022.01.13.01.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jan 2022 01:47:55 -0800 (PST) Date: Thu, 13 Jan 2022 02:47:51 -0700 From: Yu Zhao To: Mike Rapoport Cc: Andrew Morton , Linus Torvalds , Andi Kleen , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, page-reclaim@google.com, x86@kernel.org, Konstantin Kharlamov Subject: Re: [PATCH v6 8/9] mm: multigenerational lru: user interface Message-ID: References: <20220104202227.2903605-1-yuzhao@google.com> <20220104202227.2903605-9-yuzhao@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220113_014758_128870_2F77A245 X-CRM114-Status: GOOD ( 32.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 12, 2022 at 05:45:40PM +0200, Mike Rapoport wrote: > On Wed, Jan 12, 2022 at 01:35:52AM -0700, Yu Zhao wrote: > > On Mon, Jan 10, 2022 at 12:27:19PM +0200, Mike Rapoport wrote: > > > Hi, > > > > > > On Tue, Jan 04, 2022 at 01:22:27PM -0700, Yu Zhao wrote: > > > > Add /sys/kernel/mm/lru_gen/enabled as a runtime kill switch. > > > > > > > > Add /sys/kernel/mm/lru_gen/min_ttl_ms for thrashing prevention. > > > > Compared with the size-based approach, e.g., [1], this time-based > > > > approach has the following advantages: > > > > 1) It's easier to configure because it's agnostic to applications and > > > > memory sizes. > > > > 2) It's more reliable because it's directly wired to the OOM killer. > > > > > > > > Add /sys/kernel/debug/lru_gen for working set estimation and proactive > > > > reclaim. Compared with the page table-based approach and the PFN-based > > > > approach, e.g., mm/damon/[vp]addr.c, this lruvec-based approach has > > > > the following advantages: > > > > 1) It offers better choices because it's aware of memcgs, NUMA nodes, > > > > shared mappings and unmapped page cache. > > > > 2) It's more scalable because it's O(nr_hot_evictable_pages), whereas > > > > the PFN-based approach is O(nr_total_pages). > > > > > > > > Add /sys/kernel/debug/lru_gen_full for debugging. > > > > > > > > [1] https://lore.kernel.org/lkml/20211130201652.2218636d@mail.inbox.lv/ > > > > > > > > Signed-off-by: Yu Zhao > > > > Tested-by: Konstantin Kharlamov > > > > --- > > > > Documentation/vm/index.rst | 1 + > > > > Documentation/vm/multigen_lru.rst | 62 +++++ > > > > > > The description of user visible interfaces should go to > > > Documentation/admin-guide/mm > > > > > > Documentation/vm/multigen_lru.rst should have contained design description > > > and the implementation details and it would be great to actually have such > > > document. > > > > Will do, thanks. > > > > > > include/linux/nodemask.h | 1 + > > > > mm/vmscan.c | 415 ++++++++++++++++++++++++++++++ > > > > 4 files changed, 479 insertions(+) > > > > create mode 100644 Documentation/vm/multigen_lru.rst > > > > > > > > diff --git a/Documentation/vm/index.rst b/Documentation/vm/index.rst > > > > index 6f5ffef4b716..f25e755b4ff4 100644 > > > > --- a/Documentation/vm/index.rst > > > > +++ b/Documentation/vm/index.rst > > > > @@ -38,3 +38,4 @@ algorithms. If you are looking for advice on simply allocating memory, see the > > > > unevictable-lru > > > > z3fold > > > > zsmalloc > > > > + multigen_lru > > > > diff --git a/Documentation/vm/multigen_lru.rst b/Documentation/vm/multigen_lru.rst > > > > new file mode 100644 > > > > index 000000000000..6f9e0181348b > > > > --- /dev/null > > > > +++ b/Documentation/vm/multigen_lru.rst > > > > @@ -0,0 +1,62 @@ > > > > +.. SPDX-License-Identifier: GPL-2.0 > > > > + > > > > +===================== > > > > +Multigenerational LRU > > > > +===================== > > > > + > > > > +Quick start > > > > +=========== > > > > +Runtime configurations > > > > +---------------------- > > > > +:Required: Write ``1`` to ``/sys/kernel/mm/lru_gen/enable`` if the > > > > + feature wasn't enabled by default. > > > > > > Required for what? This sentence seem to lack context. Maybe add an > > > overview what is Multigenerational LRU so that users will have an idea what > > > these knobs control. > > > > Apparently I left an important part of this quick start in the next > > patch, where Kconfig options are added. I'm wonder whether I should > > squash the next patch into this one. > > I think documentation deserves a separate patch. Will do. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel