From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2395EC433F5 for ; Tue, 11 Jan 2022 20:48:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IQdemYi7w/2fQBv7MyOLk3ytixVXcEhrRvFSs9KMLc8=; b=kR2UcGA/p9NonI rf76FS7C6AgUFlMJhUqBeeVK+0barH9ZGz2uFZCCLtMjdUSZ+QmMfWzn7yKWfVpu3JJ5w8EvRI31o pqkuuOzA3iW4SFcSLINQS4hwpdeW3bfNtF0Uq8+NWfnB5dneS3Pi66yfHajQkRsCz91gv56eD5JMF p9sf/4X5x0y1XOMkhgRLaWMHOmmuOPimE+whmRrKvUg3hHemkGmAhAzd3v00jNoIo6TuZIc/ITroR zfaE1lQtsE64/zDg2hm/4UT6p9zHWjNu/GS4d2t76NiJlHyXI85o8PgmcCpaL+E/06oYaOT0NDlLC onxLgVR1rksunNslkHIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7O35-0006ed-Nk; Tue, 11 Jan 2022 20:47:19 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7O32-0006dm-9u for linux-arm-kernel@bombadil.infradead.org; Tue, 11 Jan 2022 20:47:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=pJC6pHtd1XfWt7KHGP9e4hbQvbFuTZUkQ2FcHXMUHTk=; b=jKO667mbid4+93qb8AS4ER/WGV YXcNc0yAYatzav5yb+8Qx8E8tKlYpIAenn3LsAsyOvUHJmknG/1vup1GlpssK2YJgJ45uuRc6uI8w nFUvv6HMLhdjgYQxfEiovHtbxE3IESjdPhwsKmRIe3qbQJ9IUvln5sTqrxRadBpXMwoxptBnuQH78 dcfNBTPUDTx+xSUdjfTfK1JiQjuVIzeV0NWKViam2ikBDCp/nuK9BttaLceSjRcYd+jYzqesHqwkv mKxwl65nYdJDq8XIipUDSr97/w8Rdr/JKpTlGUNPPjx20Crzy2IomqEv/s8V0pFKq6fTmeYjX4diW LFs7s83w==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7O30-000fRJ-NX; Tue, 11 Jan 2022 20:47:15 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 2368C40714; Tue, 11 Jan 2022 17:47:11 -0300 (-03) Date: Tue, 11 Jan 2022 17:47:11 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Andi Kleen , Jiri Olsa , Namhyung Kim , John Garry , Kajol Jain , "Paul A . Clarke" , Riccardo Mancini , Kan Liang , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Vineet Singh , James Clark , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, zhengjun.xing@intel.com, eranian@google.com Subject: Re: [PATCH v4 48/48] perf cpumap: Give CPUs their own type. Message-ID: References: <20220105061351.120843-1-irogers@google.com> <20220105061351.120843-49-irogers@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Tue, Jan 11, 2022 at 05:01:10PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Jan 11, 2022 at 11:16:16AM -0800, Ian Rogers escreveu: > > On Mon, Jan 10, 2022 at 11:50 AM Arnaldo Carvalho de Melo wrote: > > > Em Tue, Jan 04, 2022 at 10:13:51PM -0800, Ian Rogers escreveu: > > > > A common problem is confusing CPU map indices with the CPU, by wrap= ping > > > > the CPU with a struct then this is avoided. This approach is simila= r to > > > > atomic_t. > > > > > > This one needed this to build with BUILD_BPF_SKEL=3D1, please check, = I'll > > > soon push this to tmp.perf/perf_cpu so that you can take a look and t= est > > > it. > > Thanks Arnaldo, I did eye-ball one issue where cpu_map__default_new's > > behavior would be impacted (nr would be 1 rather than nr_cpus). The > > fix is: > > = > > --- a/tools/lib/perf/cpumap.c > > +++ b/tools/lib/perf/cpumap.c > > @@ -18,7 +18,7 @@ static struct perf_cpu_map *perf_cpu_map__alloc(int n= r_cpus) > > if (!cpus) > > return NULL; > > = > > - cpus->nr =3D 1; > > + cpus->nr =3D nr_cpus; > > refcount_set(&cpus->refcnt, 1); > > return cpus; > > } > = > > Could you add that into this patch as well? > = > Sure. > = > I=B4m now running perf-test after each of those csets, so far so good. This is what I'm running now after doing a 'git rebase -i start-of-your-patchkit' with all set to 'edit'. Will take a while :-) # cat ~/bin/perf-test-build #!/bin/bash while true ; do rm -rf /tmp/build/perf ; sudo -u acme mkdir /tmp/build/perf sudo -u acme make -k BUILD_BPF_SKEL=3D1 PYTHON=3Dpython3 O=3D/tmp/build/pe= rf -C tools/perf install-bin || exit 1 cd .. perf test || exit 2 cd - sudo -u acme git rebase --continue || exit 0 done - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel