linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Priit Laes <plaes@plaes.org>
To: rinni@inventati.org
Cc: Maxime Ripard <maxime@cerno.tech>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	"linux-sunxi@googlegroups.com" <linux-sunxi@googlegroups.com>
Subject: Re: [linux-sunxi] [PATCH RESEND v3] arm64: dts: allwinner: a64: olinuxino: Enable audio
Date: Wed, 12 Jan 2022 09:09:24 +0000	[thread overview]
Message-ID: <Yd6axIURzudUq5Ah@plaes.org> (raw)
In-Reply-To: <87654fd3-6007-6067-1851-7bc4b6de2f05@inventati.org>

On Tue, Jan 11, 2022 at 09:08:23PM +0100, 'Philip Rinn' via linux-sunxi wrote:
> Enable the audio hardware on the Olimex A64-OLinuXino board family.
> Tested on the A64-OLinuXino-2Ge8G-IND variant.

I have similar patch in one of my "long forgotten branches", but I'm not 100%
sure whether the cpvdd-supply is required for codec_analog. IIRC, sound worked
for me without the issues on A64-Olinuxino board (Rev D).

'cpvdd-supply = <&reg_eldo1>' for codec_analog

And we also need to enable these configuration options in the defconfig:

+CONFIG_SND_SUN8I_CODEC=m
+CONFIG_SND_SUN50I_CODEC_ANALOG=m


> 
> Signed-off-by: Philip Rinn <rinni@inventati.org>
> 
> ---
> 
> 
> Changes in v2: added missing &sound {...} part
> Changes in v3: removed HDMI audio part as requested by Jernej Škrabec
> 
>  arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts    | 30 +++++++++++++++++++
> 
>  1 file changed, 30 insertions(+)
> 
> 
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> 
> index ec7e2c0e82c1..6f2674bb1b7f 100644
> 
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> 
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
> 
> @@ -58,6 +58,15 @@ wifi_pwrseq: wifi_pwrseq {
> 
>  	};
> 
>  };
> 
> 
> +&codec {
> 
> +	status = "okay";
> 
> +};
> 
> +
> 
> +&codec_analog {
> 
> +	cpvdd-supply = <&reg_eldo1>;
> 
> +	status = "okay";
> 
> +};
> 
> +
> 
>  &cpu0 {
> 
>  	cpu-supply = <&reg_dcdc2>;
> 
>  };
> 
> @@ -74,6 +83,10 @@ &cpu3 {
> 
>  	cpu-supply = <&reg_dcdc2>;
> 
>  };
> 
> 
> +&dai {
> 
> +	status = "okay";
> 
> +};
> 
> +
> 
>  &de {
> 
>  	status = "okay";
> 
>  };
> 
> @@ -328,6 +341,23 @@ &simplefb_hdmi {
> 
>  	vcc-hdmi-supply = <&reg_dldo1>;
> 
>  };
> 
> 
> +&sound {
> 
> +	simple-audio-card,aux-devs = <&codec_analog>;
> 
> +	simple-audio-card,widgets = "Microphone", "Microphone Jack Left",
> 
> +		    "Microphone", "Microphone Jack Right",
> 
> +		    "Headphone", "Headphone Jack";
> 
> +	simple-audio-card,routing = "Left DAC", "DACL",
> 
> +		    "Right DAC", "DACR",
> 
> +		    "Headphone Jack", "HP",
> 
> +		    "ADCL", "Left ADC",
> 
> +		    "ADCR", "Right ADC",
> 
> +		    "Microphone Jack Left", "MBIAS",
> 
> +		    "MIC1", "Microphone Jack Left",
> 
> +		    "Microphone Jack Left", "HBIAS",
> 
> +		    "MIC2", "Microphone Jack Right";
> 
> +	status = "okay";
> 
> +};
> 
> +
> 
>  &uart0 {
> 
>  	pinctrl-names = "default";
> 
>  	pinctrl-0 = <&uart0_pb_pins>;
> 
> -- 
> 
> 2.34.1
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/87654fd3-6007-6067-1851-7bc4b6de2f05%40inventati.org.




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-01-12  9:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-28 16:28 [PATCH v3] arm64: dts: allwinner: a64: olinuxino: Enable audio Philip Rinn
2021-12-28 20:28 ` Philip Rinn
2022-01-11 20:08 ` [PATCH RESEND " Philip Rinn
2022-01-12  8:48   ` Maxime Ripard
2022-01-12 15:49     ` Philip Rinn
2022-03-24 16:28       ` [linux-sunxi] " Philip Rinn
2022-03-26  6:45         ` Jernej Škrabec
2022-04-07  2:49       ` Samuel Holland
2022-04-07  5:02         ` Jernej Škrabec
2022-04-07 15:51         ` [PATCH v4] " Philip Rinn
2022-04-07 22:06           ` Samuel Holland
2022-04-10 18:23             ` Jernej Škrabec
2022-05-08 17:38               ` Milan P. Stanić
2022-01-12  9:09   ` Priit Laes [this message]
2022-01-12 15:29     ` [linux-sunxi] [PATCH RESEND v3] " Philip Rinn
2022-01-13  6:59       ` Jernej Škrabec
2022-01-13 16:37         ` Philip Rinn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yd6axIURzudUq5Ah@plaes.org \
    --to=plaes@plaes.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime@cerno.tech \
    --cc=rinni@inventati.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).