From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EABB5C433F5 for ; Tue, 4 Jan 2022 13:49:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z5qGL83AyRMkvQNhw+FPW+6zuhMrNYApU1IEH1vsazc=; b=Jv0frLx7o3PlD5 AMO27v6bpvb89os44bB+XaC8b0FN1fnqtDTxZE1rVdr3bh99Tma3wqH1PCeS5lP0MsbCYO0GISCRl G9S2TOsLNdPoA2VmsV/uQA9DAz5ewTxWW2kmneT1oh2A1FF+t3Pb24dQV5nw76rBPBETzwKHvGubL 5FKZPBWi98jp26+YQjvFhK4l38ozPGgxfokYi96V9zOOMnB3hHHHKA/VA4oQmWvFYklmNHnBUK43j yO1KnBkmspXwVITiYhBhdBG5mc4Whe7/g2oaZBW2KJK8UlL/Ih0Y+EAs1Y3DeXcB4mei2j7o43DlW CujvtI41RwWcx5aIOWNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4kAe-00Ba6W-Aa; Tue, 04 Jan 2022 13:48:14 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4k9b-00BZhz-Pa for linux-arm-kernel@lists.infradead.org; Tue, 04 Jan 2022 13:47:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641304027; x=1672840027; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=giCDfeerhSB/M4N2G4n+FT62UWoiMv/yX0S2mawmUU4=; b=S4B/gEl8yIsDVUVPetNhDcwbKuwLxux6Q0Mo9BGvx4dgwen0bWTrI3J5 IxnoAxlOaTYVtY1wCnD4WtYwfucGRUOP4OpMc6qnNy8AsB2qtdQVrAEHj PaWFkkBFpyVgUYqA8uXvGquIfKZ0FwxmUbWpd90/6Sr48xNxhmxA/l4// UrTYDomKCEnx+QnocHjbekQmgwr4LoDZj+1M0YS77WkqVA3M5zifQ4uP2 IV0cAZ3Z+YlgcQ+Q1FjkPRYjsvsUal+A4AfWv9d+g8a3n3XHqxV0hWLwV eqJ1cuMQoFdtxSyJQO0/ofIFHO3jiYwOBIUNvOewjr4rD2W0xItIBODRf A==; X-IronPort-AV: E=McAfee;i="6200,9189,10216"; a="242431062" X-IronPort-AV: E=Sophos;i="5.88,261,1635231600"; d="scan'208";a="242431062" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2022 05:47:07 -0800 X-IronPort-AV: E=Sophos;i="5.88,261,1635231600"; d="scan'208";a="488198643" Received: from smile.fi.intel.com ([10.237.72.61]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2022 05:47:05 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1n4k8J-006DjC-Hk; Tue, 04 Jan 2022 15:45:47 +0200 Date: Tue, 4 Jan 2022 15:45:47 +0200 From: Andy Shevchenko To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, James Morse , Alexandru Elisei , Suzuki K Poulose Subject: Re: [PATCH v1 1/1] KVM: arm64: vgic: Replace kernel.h with the necessary inclusions Message-ID: References: <20211222165552.69288-1-andriy.shevchenko@linux.intel.com> <8735mk1pgt.wl-maz@kernel.org> <87iluzvcn4.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87iluzvcn4.wl-maz@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220104_054707_898429_152595C2 X-CRM114-Status: GOOD ( 23.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 04, 2022 at 01:44:31PM +0000, Marc Zyngier wrote: > On Wed, 22 Dec 2021 19:14:28 +0000, > Andy Shevchenko wrote: > > On Wed, Dec 22, 2021 at 08:25:43PM +0200, Andy Shevchenko wrote: > > > On Wed, Dec 22, 2021 at 06:09:22PM +0000, Marc Zyngier wrote: > > > > On Wed, 22 Dec 2021 16:55:52 +0000, > > > > Andy Shevchenko wrote: > > > > > > > > > > When kernel.h is used in the headers it adds a lot into dependency hell, > > > > > especially when there are circular dependencies are involved. > > > > > > > > Which circular dependencies? What problem are you solving? > > > > > > In particular moving bitmap_*alloc() APIs to the headers. > > > > > > But this may be a side effect of what I realized during the attempts > > > of solving that issue. In any case there is no need to take entire > > > mess of kernel.h in another header. > > > > For the record `make headerdep` doesn't make any difference with > > or without this patch. But I consider it's better not to use kernel.h > > in the headers due to a full mess behind it. > > Can you then please write a commit message that matches what this is > actually doing instead of mentioning a problem that doesn't seem to > exist? Sure, thanks for review! -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel