From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20F0CC433EF for ; Tue, 4 Jan 2022 22:52:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rknNGQaeIGeTVlHeStnAuiHlCTW/zXQVmxf21VwIiPs=; b=ZkGAFNy+3x+DuE 2Axr083OygV1DlzdV9nGjEbKTLtnF2W3to8fEmFeX6rV+BrdBX21jn2O0CSkdU3HxacuNrUxADcbn ACGSn053scqASSAREjB2yFoHaF+2UjEL8aMeaauS4VOoiKyurT/G0AcKcKM+cq5SYLsGiwTd/vHb5 aFFGQk4kuebJFjBNhZ1zwOk5ty7p3ZDIiiIlojtju1rNEU/sjHTbJduoNytrqm+V08YDJNM3jxwhF gjnH/KvUimYYYEmTAaiIVZEHUfPsaqFSTlD2y8yKOt2sORzy80sxhIBJljBSZH3RBrV8xTAgQciPl DFllwjNgnLuIlRvpCtVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4sdy-00D4RP-Il; Tue, 04 Jan 2022 22:51:02 +0000 Received: from mail-oi1-f176.google.com ([209.85.167.176]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4sdu-00D4Qb-L3; Tue, 04 Jan 2022 22:51:00 +0000 Received: by mail-oi1-f176.google.com with SMTP id m6so61620985oim.2; Tue, 04 Jan 2022 14:50:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=u4kviz+vXJjA0Xr/GvLPvVjzKhQXUWXW9U7sAVz/Kws=; b=lxSps1Js6EnqEHwMyrGuxo3jFdIaHGty0GUdR3VUZyKToRE0BmXziG8cr75ytNOMz/ AJqysJXhETztxtV/RO/4RGfLoNFg9Rl9cG8fWcZbjJtUzHSp+e+bxD4hQsp8RyCS+JLW cL7bpHiIlhzORbiTxUWR33+OvwV6hX0DG4duaBcDVl++ywxkBubzn6J7pxPdJ4M4nehm 7gt2ZTKPgd2u1NPsrHXWpCFM6N1ZOzwW76BG6aVija5S9mJxQfI4jBXLCWtvPep0TPo4 tEhP/ZyiPG9WqeAIDTeol9MESwj3Q4W8Vwxy6H+m9jg8yEIXcDRBA2F3Lj2E9K8rjivA VdYg== X-Gm-Message-State: AOAM5317WLcsE6PT29B1fERU8GPCHgBTTy6OyuNxEufTYhN+FVblFf79 fQGf3nDAKHeY9ZPXTeBcWg== X-Google-Smtp-Source: ABdhPJwNFO/5L0PEn5FdLvaYheNkhb4dr8Lab3trw39GjJ7qdog3DNOeJn9PGF5FSEP9yNDsP3qu6A== X-Received: by 2002:aca:2b07:: with SMTP id i7mr390628oik.141.1641336657260; Tue, 04 Jan 2022 14:50:57 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id bh12sm10157694oib.25.2022.01.04.14.50.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jan 2022 14:50:56 -0800 (PST) Received: (nullmailer pid 1599613 invoked by uid 1000); Tue, 04 Jan 2022 22:50:55 -0000 Date: Tue, 4 Jan 2022 16:50:55 -0600 From: Rob Herring To: Stefan Wahren Cc: Vinod Koul , Florian Fainelli , Nicolas Saenz Julienne , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, dmaengine@vger.kernel.org, Phil Elwell , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lukas Wunner , linux-rpi-kernel@lists.infradead.org Subject: Re: [PATCH RFC 02/11] dt-bindings: dma: Convert brcm,bcm2835-dma to json-schema Message-ID: References: <1640606743-10993-1-git-send-email-stefan.wahren@i2se.com> <1640606743-10993-3-git-send-email-stefan.wahren@i2se.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1640606743-10993-3-git-send-email-stefan.wahren@i2se.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220104_145058_731570_18EDE202 X-CRM114-Status: GOOD ( 30.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 27, 2021 at 01:05:36PM +0100, Stefan Wahren wrote: > This convert the BCM2835 DMA bindings to YAML format. > > Signed-off-by: Stefan Wahren > --- > .../devicetree/bindings/dma/brcm,bcm2835-dma.txt | 83 ---------------- > .../devicetree/bindings/dma/brcm,bcm2835-dma.yaml | 107 +++++++++++++++++++++ > 2 files changed, 107 insertions(+), 83 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt > create mode 100644 Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml > > diff --git a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt > deleted file mode 100644 > index b6a8cc0..0000000 > --- a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt > +++ /dev/null > @@ -1,83 +0,0 @@ > -* BCM2835 DMA controller > - > -The BCM2835 DMA controller has 16 channels in total. > -Only the lower 13 channels have an associated IRQ. > -Some arbitrary channels are used by the firmware > -(1,3,6,7 in the current firmware version). > -The channels 0,2 and 3 have special functionality > -and should not be used by the driver. > - > -Required properties: > -- compatible: Should be "brcm,bcm2835-dma". > -- reg: Should contain DMA registers location and length. > -- interrupts: Should contain the DMA interrupts associated > - to the DMA channels in ascending order. > -- interrupt-names: Should contain the names of the interrupt > - in the form "dmaXX". > - Use "dma-shared-all" for the common interrupt line > - that is shared by all dma channels. > -- #dma-cells: Must be <1>, the cell in the dmas property of the > - client device represents the DREQ number. > -- brcm,dma-channel-mask: Bit mask representing the channels > - not used by the firmware in ascending order, > - i.e. first channel corresponds to LSB. > - > -Example: > - > -dma: dma@7e007000 { > - compatible = "brcm,bcm2835-dma"; > - reg = <0x7e007000 0xf00>; > - interrupts = <1 16>, > - <1 17>, > - <1 18>, > - <1 19>, > - <1 20>, > - <1 21>, > - <1 22>, > - <1 23>, > - <1 24>, > - <1 25>, > - <1 26>, > - /* dma channel 11-14 share one irq */ > - <1 27>, > - <1 27>, > - <1 27>, > - <1 27>, > - /* unused shared irq for all channels */ > - <1 28>; > - interrupt-names = "dma0", > - "dma1", > - "dma2", > - "dma3", > - "dma4", > - "dma5", > - "dma6", > - "dma7", > - "dma8", > - "dma9", > - "dma10", > - "dma11", > - "dma12", > - "dma13", > - "dma14", > - "dma-shared-all"; > - > - #dma-cells = <1>; > - brcm,dma-channel-mask = <0x7f35>; > -}; > - > - > -DMA clients connected to the BCM2835 DMA controller must use the format > -described in the dma.txt file, using a two-cell specifier for each channel. > - > -Example: > - > -bcm2835_i2s: i2s@7e203000 { > - compatible = "brcm,bcm2835-i2s"; > - reg = < 0x7e203000 0x24>; > - clocks = <&clocks BCM2835_CLOCK_PCM>; > - > - dmas = <&dma 2>, > - <&dma 3>; > - dma-names = "tx", "rx"; > -}; > diff --git a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml > new file mode 100644 > index 0000000..44cb83f > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml > @@ -0,0 +1,107 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dma/brcm,bcm2835-dma.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: BCM2835 DMA controller > + > +maintainers: > + - Nicolas Saenz Julienne > + > +description: | Don't need '|' unless there is formatting to preserve. > + The BCM2835 DMA controller has 16 channels in total. > + Only the lower 13 channels have an associated IRQ. > + Some arbitrary channels are used by the firmware > + (1,3,6,7 in the current firmware version). > + The channels 0,2 and 3 have special functionality > + and should not be used by the driver. Re-wrap the lines. > + > +allOf: > + - $ref: "dma-controller.yaml#" > + > +properties: > + compatible: > + const: brcm,bcm2835-dma > + > + reg: > + maxItems: 1 > + > + interrupts: > + description: > + Should contain the DMA interrupts associated to the DMA channels in > + ascending order. > + minItems: 1 > + maxItems: 16 > + > + interrupt-names: > + minItems: 1 > + maxItems: 16 The names must be defined. You can do: items: pattern: ... > + > + "#dma-cells": > + const: 1 > + description: > > + DMA clients must use the format described in dma.txt, giving a phandle Please read dma.txt. > + to the DMA controller while the second cell in the dmas property of the Cells don't include the phandle, so 'second cell' is odd. Reword all this to be just what is specific to this binding. > + client device represents the DREQ number. > + > + brcm,dma-channel-mask: > + description: > + Bit mask representing the channels not used by the firmware in > + ascending order, i.e. first channel corresponds to LSB. > + $ref: /schemas/types.yaml#/definitions/uint32-array > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - "#dma-cells" > + - brcm,dma-channel-mask > + > +additionalProperties: false > + > +examples: > + - | > + dma: dma-controller@7e007000 { > + compatible = "brcm,bcm2835-dma"; > + reg = <0x7e007000 0xf00>; > + interrupts = <1 16>, > + <1 17>, > + <1 18>, > + <1 19>, > + <1 20>, > + <1 21>, > + <1 22>, > + <1 23>, > + <1 24>, > + <1 25>, > + <1 26>, > + /* dma channel 11-14 share one irq */ > + <1 27>, > + <1 27>, > + <1 27>, > + <1 27>, > + /* unused shared irq for all channels */ > + <1 28>; > + interrupt-names = "dma0", > + "dma1", > + "dma2", > + "dma3", > + "dma4", > + "dma5", > + "dma6", > + "dma7", > + "dma8", > + "dma9", > + "dma10", > + "dma11", > + "dma12", > + "dma13", > + "dma14", > + "dma-shared-all"; > + #dma-cells = <1>; > + brcm,dma-channel-mask = <0x7f35>; > + }; > + > +... > -- > 2.7.4 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel