From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4F80C433EF for ; Wed, 5 Jan 2022 10:17:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aL48dAF5VjjM0danD7cjWPSAtyx0tZpRDxK9K4GkAFE=; b=dSUEmHvIEGb26d kJUQqtWo1gsaEhCTOvWY0L8YJpKYJzWtSHSFpueQG7FomRqyPxCq9XfPjvgyzE5wmjdNeeXApbwj9 WlG9e+aXqH4K4I6F0mcS8uk6YbvjbChVerb/cltbTlTMxUqDzrwT3vO+obmEd5TzUSscpkPzd+9Kd PBgj3hsjL5zEFr6w9jiHbZLaWipCZQUAeSarj4+zT79I6TPBcLUs6WCyKZB/WVf+ZVxrWnZhNod2y uJBbD8erT0HzQxf/kYeKJXbYRK5x15weSrkYsTcxafbckwylhuk2DA4SSCwJKtCUkVi6clOuaM7UB CbGb4kiCIppiiRjU8rDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n53Kq-00EUnm-QT; Wed, 05 Jan 2022 10:16:00 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n53Km-00EUmh-EU for linux-arm-kernel@lists.infradead.org; Wed, 05 Jan 2022 10:15:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B1BD361650; Wed, 5 Jan 2022 10:15:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A140C36AE9; Wed, 5 Jan 2022 10:15:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1641377755; bh=LfNhQg+xRqmZe8b0diDkdlYo/hMV3uNLgHV9f5TP2jc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P9ozdcOBmSV5H8YeZ9xdYlCKmAjejscrggNvonzPWctYLaYODDRgJxXfrWbA9NbOq Iml1Sd4zM3E1g1TBII+62x4ziUCx+uwBlUsF/GL+v2h4S2tCXl7S5hFb4nywdWM76a pgtu0PWFZEOOZ2OFAGgTFsqEY12YD/0WYxYU9nKs= Date: Wed, 5 Jan 2022 11:15:52 +0100 From: Greg KH To: Richard Zhu Cc: l.stach@pengutronix.de, bhelgaas@google.com, broonie@kernel.org, lorenzo.pieralisi@arm.com, jingoohan1@gmail.com, festevam@gmail.com, stable@vger.kernel.org, linux-pci@vger.kernel.org, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH v5 0/6] PCI: imx6: refine codes and add compliance tests mode support Message-ID: References: <1641368602-20401-1-git-send-email-hongxing.zhu@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1641368602-20401-1-git-send-email-hongxing.zhu@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220105_021556_595181_6FC3165E X-CRM114-Status: GOOD ( 24.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 05, 2022 at 03:43:16PM +0800, Richard Zhu wrote: > This series patches refine pci-imx6 driver and do the following changes. > - Encapsulate the clock enable into one standalone function > - Add the error propagation from host_init > - Balance the usage of the regulator and clocks when link never came up > - Add the compliance tests mode support > > Main changes from v4 to v5: > - Since i.MX8MM PCIe support had been merged. Based on Lorenzo's git repos, > rebase and resend the patch-set. > > Main changes from v3 to v4: > - Regarding Mark's comments, delete the regulator_is_enabled() check. > - Squash #3 and #6 of v3 patch into #5 patch of v4 set. > > Main changes from v2 to v3: > - Add "Reviewed-by: Lucas Stach " tag into > first two patches. > - Add a Fixes tag into #3 patch. > - Split the #4 of v2 to two patches, one is clock disable codes move, > the other one is the acutal clock unbalance fix. > - Add a new host_exit() callback into dw_pcie_host_ops, then it could be > invoked to handle the unbalance issue in the error handling after > host_init() function when link is down. > - Add a new host_exit() callback for i.MX PCIe driver to handle this case > in the error handling after host_init. > > Main changes from v1 to v2: > Regarding Lucas' comments. > - Move the placement of the new imx6_pcie_clk_enable() to avoid the > forward declarition. > - Seperate the second patch of v1 patch-set to three patches. > - Use the module_param to replace the kernel command line. > Regarding Bjorn's comments: > - Use the cover-letter for a multi-patch series. > - Correct the subject line, and refine the commit logs. For example, > remove the timestamp of the logs. > > drivers/pci/controller/dwc/pci-imx6.c | 197 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------- > drivers/pci/controller/dwc/pcie-designware-host.c | 5 ++- > drivers/pci/controller/dwc/pcie-designware.h | 1 + > 3 files changed, 128 insertions(+), 75 deletions(-) > > [PATCH v5 1/6] PCI: imx6: Encapsulate the clock enable into one > [PATCH v5 2/6] PCI: imx6: Add the error propagation from host_init > [PATCH v5 3/6] PCI: imx6: PCI: imx6: Move imx6_pcie_clk_disable() > [PATCH v5 4/6] PCI: dwc: Add dw_pcie_host_ops.host_exit() callback > [PATCH v5 5/6] PCI: imx6: Fix the regulator dump when link never came > [PATCH v5 6/6] PCI: imx6: Add the compliance tests mode support This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel