From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 610D0C433F5 for ; Thu, 6 Jan 2022 13:49:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OUmuh2OXLaDHuNYziGgIEvVIpT6HM7zlWMsSzs8ZJRo=; b=dLfDysJTiOt2DK whZ6na9eqgEF1gQkOsxqxawQu7S7CMi2R/BkMNENw5tr2oMKBp6TF3lSv4i5ZSVQa0+x+uAjJl878 SE8vIM9COB9VfEKN36KHpAeIbN8JzVSPkLM1uJH2rlLMuFS4PNTOsBtlUtCy6JQO2oRcynkauRFBh CcznB2KN3c4zYu/l4XvYugKe0iZxCYyML8lJbPsr2P0ERM8O3PP7g33V68TOfsGveeKXl9pfSzfK/ /MLMSL/9KCUyVCjVFTpcjUhsraEe1Hl0o0rf5Nz0PSzuEyU1TYP6myvBkS/NPr0tRyYw5ueYrbmb1 D1EMR3YYPQdC4WTd/iPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5T84-000EjV-Fo; Thu, 06 Jan 2022 13:48:32 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5T81-000Eie-VE; Thu, 06 Jan 2022 13:48:31 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A3DD161BF3; Thu, 6 Jan 2022 13:48:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 339F6C36AE0; Thu, 6 Jan 2022 13:48:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1641476908; bh=PgXH7pcqFif2gxuO4rbqz6wSChAqn48shM3SxiUmUc8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bUJB1LC8OdYWaAtdDetmhNfk9T2fupxPyVFah2O2U6xNY2GZHUzo5HhF6PQh2c+XI HGrOMeuAefThvEGXv94w1C7ybvtmytGnZOZoMKVmq/YqNLf0JjFCAS0XXKUxZD5jQN URWn4SoDy6rBXCMMuuxlFqsTTcJA2l/GLryptexg= Date: Thu, 6 Jan 2022 14:48:25 +0100 From: Greg KH To: Gaston Gonzalez Cc: linux-staging@lists.linux.dev, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, len.baker@gmx.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] staging: vc04_services: rename macros BM2835_MMAL_VERSION and BM2835_MMAL_MODULE_NAME Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220106_054830_094380_8D175585 X-CRM114-Status: GOOD ( 15.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 05, 2022 at 05:35:47PM -0300, Gaston Gonzalez wrote: > In the kernel, all names related to the chip BCM2835 are always named > bcm2835_*. To avoid confusion, and to make things more consistent, > rename the macros BM2835_MMAL_VERSION and BM2835_MMAL_MODULE_NAME > accordingly. > > While at it, some realignments were made to improve readability. > > Suggested-by: Stefan Wahren > Signed-off-by: Gaston Gonzalez > --- > .../vc04_services/bcm2835-camera/bcm2835-camera.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c > index aaf529f2186c..c729b1b7de71 100644 > --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c > +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c > @@ -33,8 +33,8 @@ > #include "mmal-parameters.h" > #include "bcm2835-camera.h" > > -#define BM2835_MMAL_VERSION "0.0.2" > -#define BM2835_MMAL_MODULE_NAME "bcm2835-v4l2" > +#define BCM2835_MMAL_VERSION "0.0.2" MODULE_VERSION means nothing when the code is in the kernel tree, this shold just be removed entirely. > +#define BCM2835_MMAL_MODULE_NAME "bcm2835-v4l2" KBUILD_MODULE_NAME provides this, please delete this and just use that instead. This can be 2 different commits because of this. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel