From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F00A5C433F5 for ; Fri, 7 Jan 2022 07:26:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6u/G+0GuhOIFw7RFhvTh97Rm/K6fSqg6Xb8DP2WSzV4=; b=1bmO9Cec9V0IMt En2X/kRiEk8/4Fk5VfpJPQVzNiA6hXHi/sSkwDXL/aZPPiC2FHvQL/G9seqE6N2qUdAZtwdT8uXah xV1or6hgyInMrb6bcO94PpOXXgkcdY2CCor6SxR69KbSfw6z1BbOF0ywpA+567YxjAOo1Nj7N1W8G w18a4+ewX3p+YMZBbHKKnjUCy8Nfq7sfIDShO04AA6eooM9ZXv9zYI2cOL58RuWSOamOo1E8ByUNC uxlHh9Srrj8tiWMBlvM7Dtu0SgHDI8tm4OtjV6qQd1Qvtdt5jk5x8a8HGEL0oVi+zXn/htS39+Ktx BV10COy4G6NPIFMeLKXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5jci-002j5V-7R; Fri, 07 Jan 2022 07:25:16 +0000 Received: from mail-io1-xd30.google.com ([2607:f8b0:4864:20::d30]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5jce-002j4A-Tl for linux-arm-kernel@lists.infradead.org; Fri, 07 Jan 2022 07:25:14 +0000 Received: by mail-io1-xd30.google.com with SMTP id y11so6067654iod.6 for ; Thu, 06 Jan 2022 23:25:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Dt5wFTIivnEVZNJ35QfigYoIPkloAu9LxIwiM8cfNlM=; b=KEUgoAw/F9G/n+DL3vPDPzqUuCnfnBzCRczFO16S99KbAcoAyrV9Vpb2AD74ahCjh8 uf8VigJL/FmZUKO+jofCVvFOHZuM7q+xtWDz53MAO4BA0Mn2zHV0OH6UxkAKRJl5TaAY SUMPxqRnmW04h8A9GnZu7raeMdpapoBAMIqGKj4vLsfHIqnGc4ROdp9a0I4kXG2ahw9d XRUltLOLGcfkj+RMWNT+3kyWS7LdregbHr/zh8eNY6EorURFTH4Egx1INGlForVlX1BH p2w0dBHu+Ap8teOi/dGdqzp8u93hW6oyVDaMJTA4hopr+3AasJCRGO7TSKgwVQ4jSC74 LOgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Dt5wFTIivnEVZNJ35QfigYoIPkloAu9LxIwiM8cfNlM=; b=mgLTHqMsm4ZyFeonizBkmwyqWZ4IuwOar1ynoyQornZze1smE+0zAV/2WPGFVi2K5F LYgjNh8ugryrWOAagFYleuS0TP7SD+EaKEqmWdYooO2qEiHT6YRffEucdKdwIrKPpHVm udpLYHpi1wFtN2pdVzbSEWdvcrxUQ2bb+7IC8Icm5e+CNp9xEBUnFN40lbWfrdUeRz/d RyXkBeUEUN6XTJaaFMhm4uoJCaJVH8+cKxcZNIn1jVYO3kuKIDxmemQ90YmWAoSIc9oe lfBHLbhJAKT+ZNpbaRJJMD36ZNpvG5hbsNvU7YvRXpbNZ/zYGjBjqzEEslRCCHHkoiR4 TuBQ== X-Gm-Message-State: AOAM5329vKkUbUN/IFTEnB71fh5ggpj14sseDD4VuDaBnU0QPWJ8HWg6 +1WB087quBNNrPoF8JZOPaIoVA== X-Google-Smtp-Source: ABdhPJz3x1HWzD5i0AVExGboPsVu371NgLICgXvka4rbxX4XJLCTLcI+ZJ0R+n6BnSvFqM8bGhULrw== X-Received: by 2002:a5e:9905:: with SMTP id t5mr26785346ioj.16.1641540311737; Thu, 06 Jan 2022 23:25:11 -0800 (PST) Received: from google.com ([2620:15c:183:200:2e0a:5e5e:fac:e07b]) by smtp.gmail.com with ESMTPSA id g1sm2528097ila.26.2022.01.06.23.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jan 2022 23:25:11 -0800 (PST) Date: Fri, 7 Jan 2022 00:25:07 -0700 From: Yu Zhao To: Will Deacon Cc: Andrew Morton , Linus Torvalds , Andi Kleen , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Rik van Riel , Vlastimil Babka , Ying Huang , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, page-reclaim@google.com, x86@kernel.org, Konstantin Kharlamov Subject: Re: [PATCH v6 1/9] mm: x86, arm64: add arch_has_hw_pte_young() Message-ID: References: <20220104202227.2903605-1-yuzhao@google.com> <20220104202227.2903605-2-yuzhao@google.com> <20220105104526.GA3015@willie-the-truck> <20220106103009.GA4420@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220106103009.GA4420@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220106_232512_995828_ECF5963A X-CRM114-Status: GOOD ( 26.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jan 06, 2022 at 10:30:09AM +0000, Will Deacon wrote: > On Wed, Jan 05, 2022 at 01:47:08PM -0700, Yu Zhao wrote: > > On Wed, Jan 05, 2022 at 10:45:26AM +0000, Will Deacon wrote: > > > On Tue, Jan 04, 2022 at 01:22:20PM -0700, Yu Zhao wrote: > > > > diff --git a/arch/arm64/tools/cpucaps b/arch/arm64/tools/cpucaps > > > > index 870c39537dd0..56e4ef5d95fa 100644 > > > > --- a/arch/arm64/tools/cpucaps > > > > +++ b/arch/arm64/tools/cpucaps > > > > @@ -36,6 +36,7 @@ HAS_STAGE2_FWB > > > > HAS_SYSREG_GIC_CPUIF > > > > HAS_TLB_RANGE > > > > HAS_VIRT_HOST_EXTN > > > > +HW_AF > > > > HW_DBM > > > > KVM_PROTECTED_MODE > > > > MISMATCHED_CACHE_TYPE > > > > > > As discussed in the previous threads, we really don't need the complexity > > > of the additional cap for the arm64 part. Please can you just use the > > > existing code instead? It's both simpler and, as you say, it's equivalent > > > for existing hardware. > > > > > > That way, this patch just ends up being a renaming exercise and we're all > > > good. > > > > No, renaming alone isn't enough. A caller needs to disable preemption > > before calling system_has_hw_af(), and I don't think it's reasonable > > to ask this caller to do it on x86 as well. > > > > It seems you really prefer not to have HW_AF. So the best I can > > accommodate, considering other potential archs, e.g., risc-v (I do > > plan to provide benchmark results on risc-v, btw), is: > > > > static inline bool arch_has_hw_pte_young(bool local) > > { > > bool hw_af; > > > > if (local) { > > WARN_ON(preemptible()); > > return cpu_has_hw_af(); > > } > > > > preempt_disable(); > > hw_af = system_has_hw_af(); > > preempt_enable(); > > > > return hw_af; > > } > > > > Or please give me something else I can call without disabling > > preemption, sounds good? > > Sure thing, let me take a look. Do you have your series on a public git > tree someplace? Thanks! This patch (updated) on Gerrit: https://linux-mm-review.googlesource.com/c/page-reclaim/+/1500/1 And the entire series: git fetch https://linux-mm.googlesource.com/page-reclaim refs/changes/08/1508/1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel