From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C2A4C433EF for ; Fri, 7 Jan 2022 13:42:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ygdzy6cBmCLTTeMkrER8QEa84uCDpLiIn8k53PiGuK8=; b=LCw7sjWCADJEoE EoSc4xnfGqu6Vk/pNBVeQF31X3t9em0KMJDrsWk65EMn2qAgx2ewU8h52+fUI13M9jOdD7JhKTMFh gwd18W9PLq3Dk4N0EjF5gMsZjwID8WBvNkPtrnHDOHRkeSdWanQbWV6n9G/3vGpI7I18sZHxFWriK CDIo32PgkYLFp44peDyjtbtv7AXmyqU7IPzLsBpN9JSYdjBa41z4uTPN3ovnbDUk/cuh/9eUeHPfv EwZpX8NLOmakKPM/eRiX3fz38HVwnIicZndWHcwTSfWqEhRjT5q9uiHGVZsveIZUkBZzpDXmFKXbZ R4Q7QyRFdg6FFu4E1z8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5pU7-0040kF-2G; Fri, 07 Jan 2022 13:40:47 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5pU3-0040jF-Li for linux-arm-kernel@lists.infradead.org; Fri, 07 Jan 2022 13:40:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=roykdlR5flEhZ6dRP2lKS2E2FMz0xnDr1kND8pmlxs8=; b=SA0dUA/xwGm9nAtScJUYjToRNo NMR4bFnQ1Z/eF4oYZ4shzg1y3vdHlWFRS9G3WDnhIIr+1WYcwGid3tgGXB3y9ExsMkkMtwKfcAuG7 5YAD2BI6mlj2ZB2sJT5FAMWPjUihBEioZf1EXm3LIQrRPC/rfTFXR3Cq/MVBQ9gG6PkcnspvND1id bnLG/E6vc3FlO6LT6Tua/RKW+PS6S3uh3XcOTeC6/A92CZt0OJSqdgR5BWs6wQpaoQPWU6UPKRR1+ dTvg7tirAnw6u+aJGyJ2twhP4t5mTECFpEFheIzAqqn+EWUSRpO+AWdMz/h6On2Pq1yb4V1sTs6z0 ZmiUk+hQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56612) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1n5pTh-0001Sz-EV; Fri, 07 Jan 2022 13:40:21 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1n5pTS-0001y8-QO; Fri, 07 Jan 2022 13:40:06 +0000 Date: Fri, 7 Jan 2022 13:40:06 +0000 From: "Russell King (Oracle)" To: Wong Vee Khee Cc: Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , Maxime Coquelin , Andrew Lunn , "David S. Miller" , Heiner Kallweit , Jakub Kicinski , Jose Abreu , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org Subject: Re: [PATCH CFT net-next 0/6] net: stmmac/xpcs: modernise PCS support Message-ID: References: <20211217055729.GA14835@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211217055729.GA14835@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220107_054043_880759_5BCD8E2E X-CRM114-Status: GOOD ( 32.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 17, 2021 at 01:57:29PM +0800, Wong Vee Khee wrote: > On Thu, Dec 16, 2021 at 01:11:40PM +0000, Russell King (Oracle) wrote: > > Hi, > > > > This series updates xpcs and stmmac for the recent changes to phylink > > to better support split PCS and to get rid of private MAC validation > > functions. > > > > This series is slightly more involved than other conversions as stmmac > > has already had optional proper split PCS support. > > > > The patches: > > > > 1) Provide a function to query the xpcs for the interface modes that > > are supported. > > > > 2) Populates the MAC capabilities and switches stmmac_validate() to use > > phylink_get_linkmodes(). We do not use phylink_generic_validate() yet > > as (a) we do not always have the supported interfaces populated, and > > (b) the existing code does not restrict based on interface. There > > should be no functional effect from this patch. > > > > 3) Populates phylink's supported interfaces from the xpcs when the xpcs > > is configured by firmware and also the firmware configured interface > > mode. Note: this will restrict stmmac to only supporting these > > interfaces modes - stmmac maintainers need to verify that this > > behaviour is acceptable. > > > > 4) stmmac_validate() tail-calls xpcs_validate(), but we don't need it to > > now that PCS have their own validation method. Convert stmmac and > > xpcs to use this method instead. > > > > 5) xpcs sets the poll field of phylink_pcs to true, meaning xpcs > > requires its status to be polled. There is no need to also set the > > phylink_config.pcs_poll. Remove this. > > > > 6) Switch to phylink_generic_validate(). This is probably the most > > contravertial change in this patch set as this will cause the MAC to > > restrict link modes based on the interface mode. From an inspection > > of the xpcs driver, this should be safe, as XPCS only further > > restricts the link modes to a subset of these (whether that is > > correct or not is not an issue I am addressing here.) For > > implementations that do not use xpcs, this is a more open question > > and needs feedback from stmmac maintainers. > > > > Please review and test this series. Thanks! > > > > Tested this patch series on my Intel Elkhart Lake setup with Marvell > 88E1510 PHY. > > Everything works perfectly! Can I take that as a tested-by please? It would be good to get some feedback from other stmmac users, since I believe stmmac is used in multiple different configurations. Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel