From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5164FC433F5 for ; Fri, 7 Jan 2022 14:01:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9Mhc1zopSVOgBtfcSPl+u0E6MdALfEAre9O6Q+oPFUk=; b=OQ+q24tY209n9H +ireyKbvMMB65uNimSweAoMFdIcnBg+Su9ayqRsUgo4NRZAuuLgEXSzcMxcMQXD1FLx4aeCAg6Rn0 YtpVp/8bRBu1rkLeae5B7zr/siNoPoJC7kqg8+bNKGPue9xNBKI+gO+ZLtNVSGn55OGEyrW3X3rTQ xbrCda6n1UCbJaPA+8hbsGBnk0mgsaTnApvtjQT4qhH+u1rtHXvEXHgB68N6YOjiwu+LoVsKdPbtC dNnekq2ikd0YgyuE5zBB/NvG5FiU91WuTsVQu3B0+gVnhViE6LBmNYF6pxgimyQXnAlwscKlpBeov HyGZ2Z6rK/z68+53I/BA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5pme-0045c3-RG; Fri, 07 Jan 2022 13:59:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5pmb-0045bP-Co for linux-arm-kernel@lists.infradead.org; Fri, 07 Jan 2022 13:59:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 691D613A1; Fri, 7 Jan 2022 05:59:52 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.7.134]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D51F33F774; Fri, 7 Jan 2022 05:59:51 -0800 (PST) Date: Fri, 7 Jan 2022 13:59:49 +0000 From: Mark Rutland To: Andre Przywara Cc: linux-arm-kernel@lists.infradead.org, Jaxson Han Subject: Re: [boot-wrapper PATCH v2 9/9] avoid dtc warnings on re-compiling DTB Message-ID: References: <20211222181607.1203191-1-andre.przywara@arm.com> <20211222181607.1203191-10-andre.przywara@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211222181607.1203191-10-andre.przywara@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220107_055953_507804_36A1CF76 X-CRM114-Status: GOOD ( 22.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 22, 2021 at 06:16:07PM +0000, Andre Przywara wrote: > When we add the PSCI nodes to the provided DTB, we use dtc to de-compile > the blob first, then re-compile it with our nodes and properties added. > > In our input DTB the proper phandle references have already been lost, > all we see in the DTB is phandle properties in the target node, and some > numbers in the clocks and gpios properties: > =========== > clk24mhz { > compatible = "fixed-clock"; > #clock-cells = <0x00>; > clock-frequency = <0x16e3600>; > clock-output-names = "v2m:clk24mhz"; > -> phandle = <0x05>; > }; > ... > serial@90000 { > compatible = "arm,pl011", "arm,primecell"; > reg = <0x90000 0x1000>; > interrupts = <0x05>; > -> clocks = <0x05 0x05>; > clock-names = "uartclk", "apb_pclk"; > }; > =========== > dtc warns that those numbers might be wrong: > ========= > :177.6-27: Warning (clocks_property): > /bus@8000000/motherboard-bus@8000000/iofpga-bus@300000000/serial@90000: > clocks: cell 0 is not a phandle reference > .... > ========= > The proper solution would be to use references (&v2m_clk24mhz) instead, > as there are in the source .dts file, but we don't have that information > anymore, and cannot easily recover it. > > To avoid the lengthy list of warnings, just drop those checks from the > dtc compilation run. This disables more checks than we want or need, but > we somewhat trust in the original DTB to be sane, so that should be > fine. > > Signed-off-by: Andre Przywara Thanks; applied. Mark. > --- > Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile.am b/Makefile.am > index 3d8128f..430b4a9 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -160,7 +160,7 @@ model.lds: $(LD_SCRIPT) Makefile > $(CPP) $(CPPFLAGS) -ansi -DPHYS_OFFSET=$(PHYS_OFFSET) -DMBOX_OFFSET=$(MBOX_OFFSET) -DKERNEL_OFFSET=$(KERNEL_OFFSET) -DFDT_OFFSET=$(FDT_OFFSET) -DFS_OFFSET=$(FS_OFFSET) $(XEN) -DXEN_OFFSET=$(XEN_OFFSET) -DKERNEL=$(KERNEL_IMAGE) -DFILESYSTEM=$(FILESYSTEM) -DTEXT_LIMIT=$(TEXT_LIMIT) -P -C -o $@ $< > > fdt.dtb: $(KERNEL_DTB) Makefile > - ( $(DTC) -O dts -I dtb $(KERNEL_DTB) ; echo "/ { $(CHOSEN_NODE) $(PSCI_NODE) }; $(CPU_NODES)" ) | $(DTC) -O dtb -o $@ - > + ( $(DTC) -O dts -I dtb $(KERNEL_DTB) ; echo "/ { $(CHOSEN_NODE) $(PSCI_NODE) }; $(CPU_NODES)" ) | $(DTC) -O dtb -o $@ -Wno-clocks_property -Wno-gpios_property - > > # The filesystem archive might not exist if INITRD is not being used > .PHONY: all clean $(FILESYSTEM) > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel