From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: conleylee@foxmail.com
Cc: davem@davemloft.net, mripard@kernel.org, wens@csie.org,
jernej.skrabec@gmail.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] sun4i-emac.c: enable emac tx dma
Date: Sun, 9 Jan 2022 21:45:01 +0100 [thread overview]
Message-ID: <YdtJTQJJ4aEUcp/D@Red> (raw)
In-Reply-To: <tencent_E4BA4D6105A46CCC1E8AEF48057EA5FE5B08@qq.com>
Le Sun, Jan 09, 2022 at 05:17:55PM +0800, conleylee@foxmail.com a écrit :
> From: conley <conleylee@foxmail.com>
>
> Hello
> I am reading the R40 user manual and trying to create a new path to enable
> emac tx dma channel. According to the figure 8-21(TX Operation Diagram),
> I try to enable emac tx dma channel by the follow steps:
> 1. enable tx dma mode
> 2. set packet lengths
> 2. move data from skb to tx fifo by using dma in xmit function.
> 3. start transfer from tx fifo to phy in dma tx done callback
>
> But it doesn't work. emac tx interrupt and dma finished interrupt are
> raised, but no packets are transmitted (I test it by tcpdump).
> Do you know how to configure the emac tx dma correctly? Thanks ~
>
Hello
Here are my thoughts to help you:
- Your email is not a real patch, but an ask for help, so you should not use [ PATCH ] in the subject.
- If it was a patch, "v1" is not necessary
- Your patch below is doing too many unrelated different things, it is hard to see the DMA TX enable part
- I think you could first send a preliminary patch which adds all EMAC_INT_CTL_TX_xxx which are already used by the driver (to reduce the diff)
- Without the DTB change, it is hard to see the whole picture, did you correctly use the right dma number for an easy example.
- Knowing also the board (and so PHY, modes etc...) could help
- I think your priority should not to add TX, but to fix reported problems to your initial patch (build warnings/error https://marc.info/?l=linux-arm-kernel&m=164159846213585&w=2) since your work on TX will need to be applied after this.
- For the previous point, always build test with at least 2 different 32/64 arch. And if possible a total different arch (like x86_64).
Anyway, I will try to test your patch on my a10 board
Regards
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-09 20:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_95A0609A0DC523F7DDAE60A8746EABAA8905@qq.com>
2021-12-28 11:42 ` [PATCH v5] sun4i-emac.c: add dma support conleylee
2021-12-29 0:48 ` Jakub Kicinski
2021-12-29 1:43 ` [PATCH v6] " conleylee
2021-12-30 2:00 ` patchwork-bot+netdevbpf
2022-05-30 4:51 ` Corentin Labbe
2022-05-30 18:48 ` Jakub Kicinski
2022-05-30 18:55 ` Corentin Labbe
2021-12-31 10:43 ` Corentin Labbe
[not found] ` <tencent_57960DDC83F43DA3E0A2F47DEBAD69A4A005@qq.com>
2022-01-02 17:38 ` Corentin Labbe
[not found] ` <tencent_67023336008FE777A58293D2D32DEFA69107@qq.com>
2022-01-03 11:42 ` Corentin Labbe
2022-01-03 12:21 ` Conley Lee
2022-01-09 9:17 ` [PATCH v1] sun4i-emac.c: enable emac tx dma conleylee
2022-01-09 20:45 ` Corentin Labbe [this message]
2022-01-10 7:47 ` Conley Lee
2022-01-07 23:34 ` [PATCH v6] sun4i-emac.c: add dma support Kees Cook
2022-01-08 2:34 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YdtJTQJJ4aEUcp/D@Red \
--to=clabbe.montjoie@gmail.com \
--cc=conleylee@foxmail.com \
--cc=davem@davemloft.net \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).