From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09030C433EF for ; Mon, 10 Jan 2022 08:33:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aYRhH7vx4vpy99fMZVl9mWdqNZw6IwtRXvYb5pOeqiI=; b=ow5csqW2iMHZHK iTtlVW/+8jjXaOngEr7oh2W6j2zEWM5NIrtaqjqjkv39zZZlUGB7JjBpZarzbVASed+9I1qyzieAe J0M+Mnf83qK0f0L+/7fF5CtP2tvGg4CSWrLGDZRNvayTGFareGKZzDDcQ130fAWavsIxEQidAYyRj 3cOFv07I+1rRj7LUNiJ/4W4m7zXfrTCzZmy8Ht5xh+m/FQ5R562uPUBUqKnVH0RbdCNstCg+Q9M3X JMsyl4TKIKnekMNA2DVuY8K7vfordQy6zkE0IOVxxT2gXy2/pe6p6xfNxo0jyz1Bc5U7pgCZo5U15 IpZNBNtxw0Fe/UuY8OZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6q6U-009tOR-8p; Mon, 10 Jan 2022 08:32:34 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6q6P-009tMf-Eb for linux-arm-kernel@lists.infradead.org; Mon, 10 Jan 2022 08:32:30 +0000 Received: by mail-wr1-x436.google.com with SMTP id s1so25231810wra.6 for ; Mon, 10 Jan 2022 00:32:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=yFitxr4LUHEFQN8u7AKlHp0fvIKgsL3O7SmilxAJ8Oc=; b=CXOEf99IK1mY3GLkw9GNvYdr52AtX0sZMVWOs/Eiq9CczPEXduaMo0vlZ2qoyix+ph 0HwVXJdikHrXDcBaY1MKHpxOOxeLw09kQyeVsbCcZt43PJ1XSK5Pet1Z8ozgKmVpm7sk jimUATnPEcup3fkeXwB2FdnZne6nKMCJUTp4OufurHBJwmziB0TTFfY3NDFByIepaT3V RdrCOpAGT00LFFkJYvKdIpevYNUxJtZgGBAWnWyolq7+p1gfZL6jXrlj4MaNtWnKrOXr eO41HoxSseMHTJBHd+r2UFovE99zVb3HOKjTpYYaNYcj8FO6+mTmGYs+6TXCVzJ5rkmY UH6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=yFitxr4LUHEFQN8u7AKlHp0fvIKgsL3O7SmilxAJ8Oc=; b=Z91wqYWjbl9lzuw2mv7G/Zk9oJlXeZq1rQXrOdrbfjMKDMSIKp6P79KBVgegzA3CUc IHh3NmzmG001Rswq3/hF7hcMJ/XIr4AkeZ67h+4JEuFCzf+N2INKp7aB2d0L2+zd68EK qUtu0fJmaYbcIGNz/rflbegyz6U5LTk9+6x5KP7OOPAoC53UKWjl2SXEsusK6Mux3laL bs7N5eHSL4WwxgTTWWRxJMdA5qU+Z2AlKkb1Fz0Oj9lxDFKbXQLU469l23j6w3PpUdNU WMOlTGP+wufAUVw+shNdpkhwfiuJFxSrU84hJ9bXicwbCRJ0EsA/WAt8kkqnZjO6kTC2 wpDQ== X-Gm-Message-State: AOAM531M2c5gb4w8c7B/7YUP+xYxOL6JyJFHf0EbjBxIbCJ8Ux2dx16I JzF0QuY52KnQ8tJ/SYrkbhY= X-Google-Smtp-Source: ABdhPJxH9vwRdImfYpgveDGSsQDl1xCE7+/AHH07mUQMvxC03h6+c+jz8nziUVPvFgWhNlvookMM2A== X-Received: by 2002:a5d:650f:: with SMTP id x15mr62949067wru.57.1641803547569; Mon, 10 Jan 2022 00:32:27 -0800 (PST) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id y4sm6192515wrd.50.2022.01.10.00.32.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jan 2022 00:32:27 -0800 (PST) Date: Mon, 10 Jan 2022 09:32:24 +0100 From: Corentin Labbe To: conleylee@foxmail.com Cc: davem@davemloft.net, kuba@kernel.org, mripard@kernel.org, wens@csie.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] sun4i-emac: replace magic number with marcos Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220110_003229_530582_EBC0DBB0 X-CRM114-Status: GOOD ( 12.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Le Mon, Jan 10, 2022 at 03:23:07PM +0800, conleylee@foxmail.com a =E9crit : > From: conley > = > - sun4i-emac.h: add register related marcos > - sun4i-emac.c: replace magic number with marco > = > *** BLURB HERE *** > = > conley (2): > sun4i-emac.h: add register related marcos > sun4i-emac.c: replace magic number with macro > = > drivers/net/ethernet/allwinner/sun4i-emac.c | 26 ++++++++++----------- > drivers/net/ethernet/allwinner/sun4i-emac.h | 18 ++++++++++++++ > 2 files changed, 31 insertions(+), 13 deletions(-) > = Hello The from should be your real name. You miss commit message. The subject should be "net: allwinner: xxxx" or "net: ethernet: sun4i-emac:= xxxx" You did a typo marcos/macros If you add a changelog, either put it in cover letter or below "---" in pat= ch along git stats (changelog should not be part of commit message). I think both patch should be merged. Regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel