From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A267EC433EF for ; Mon, 10 Jan 2022 18:53:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1ytl+Eoovb968uB8v2CDmIUR/fdgyoxEbdOftQLgzNY=; b=z8o5J2aZlvsdXn 1Rqq7mnsQctoyFuYa+Dr+Us3ttC3rdTfstz47Ij89DMB3H3/VmkifkS899SZoJOOpfHAOFSUquuf7 tsr6Dx2jIIQ5p4xj7WyOKGWvvaY2IJD1kHNyoFCxYT3jfN+mGocxn5xMDCXn+Ja/4MKH3Lndgxrcm ZViAOm2NnSUG1cJtVwul9e4mR32mKnQm+DnMzgkh/4uu5Zmq+jfCECEXH4s6Ee0JD7UiNq9lDxxya VofGaFuyqWj/7Tx1ZMFrDjjGEGFXz8C30DgaV+0aYVCrC93E/Q9dH0wgPdRtxHZGPHNXFACeAO8WU wbuVDYdOEDA12/RJo8vw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6zmE-00CrjV-Gs; Mon, 10 Jan 2022 18:52:18 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6zmC-00Crii-Vi for linux-arm-kernel@bombadil.infradead.org; Mon, 10 Jan 2022 18:52:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JpY/WacAqncRfHRgHQyWQo+F4gXhYkTZmz4oX+h0X/Y=; b=PtIa05l2fpZ43UpLqIrLL5B30H vcwYoXxyqKKuPjFB4LWoFmVjsoGR/7q10Sa3q0A8CGOeZ9jOoIoeURm8r9AiSHZvZd+OdearWNwuI P7zWb2QZW9RFFdTB7IKzYP3E7ZYxgwNUL+N+Z3c7l8TVm0fsUoRiins9Sc/nmo6nn2L6H3WIjQQlW +6tI4CUP05NrhXhiYkhQeXe2p3lWRp26/RGQswBk4cTYynrIJZ0u/zJxK4vsOQUBk/5QGZ/4wvohn 5O6ablcsj9atMdbA0LjjTEQQYOwZ9JA2JLRvooEI8gb57M1O6kgxxVFcYwQYUFkyMNqXkWlzOdM91 w3dVrSrg==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6zmB-002eay-1u; Mon, 10 Jan 2022 18:52:15 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id B44B440B92; Mon, 10 Jan 2022 15:52:11 -0300 (-03) Date: Mon, 10 Jan 2022 15:52:11 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: John Garry , Andi Kleen , Jiri Olsa , Namhyung Kim , Kajol Jain , "Paul A . Clarke" , Riccardo Mancini , Kan Liang , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Vineet Singh , James Clark , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, zhengjun.xing@intel.com, eranian@google.com Subject: Re: [PATCH v4 02/48] perf stat: Add aggr creators that are passed a cpu. Message-ID: References: <20220105061351.120843-1-irogers@google.com> <20220105061351.120843-3-irogers@google.com> <57ab982e-ecc1-3f49-c580-0a251e29698b@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Mon, Jan 10, 2022 at 09:36:49AM -0800, Ian Rogers escreveu: > On Mon, Jan 10, 2022 at 9:10 AM John Garry wrote: > > > > On 05/01/2022 06:13, Ian Rogers wrote: > > > > > > +struct aggr_cpu_id cpu_map__get_socket(struct perf_cpu_map *map, int idx, > > > + void *data) > > > +{ > > > + if (idx < 0 || idx > map->nr) > > > + return cpu_map__empty_aggr_cpu_id(); > > > + > > > + return cpu_map__get_socket_aggr_by_cpu(map->map[idx], data); > > > +} > > > + > > > > > > This is later deleted in the series. Can the series be reworked so that > > we don't add stuff and then later delete it? One reason for that > > approach is that we don't spend time reviewing something which will be > > deleted, especially in such a big series... > > Hi John, > > I think you are asking to squash: > https://lore.kernel.org/lkml/20220105061351.120843-8-irogers@google.com/ > into this change. There are other similar related changes that may > also be squashed. The changes are trying to introduce a new API and > then add changes to switch over to using it. This is with a view to > making bisection easier, have each change only do 1 thing and so on. I > believe the format of the patches is house style, but it is fine to > squash changes together too. Having sent patches to Arnaldo and having > had them split I'm reluctant to do a v5 with them squashed without him > expressing a preference. Right, sometimes this is needed, I'm getting the patchkit now to test build it in my containers and will go patch by patch reviewing. - Arnaldo > Thanks, > Ian > > > If it really makes sense to do it this way then fine. > > > > Thanks, > > John -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel