From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EC97C433F5 for ; Tue, 25 Jan 2022 06:42:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CEgdD0YlTia4VeOIkT+gWg3cNZ8qH8LFM5cBW+oeqcA=; b=fuqo/zAi6Z+BjX ie2q2flDw4iyb0WniMxbRyyMgMsQe+/0QQEH5ssT2KpsI9UW3T9wlAg1lOhQ2FrlsywmwlpMn7NBK DrXw6XRNQy4YOQTzFbBVhaJPO+DIcxfOwU8+ujgeepASI2HMBXKzA1bQm540OW4AbKI77xEVhCr5a b5cYkfgLC9NkK8XSYBg0MDzLOiP7K+yIoynxoo0G14q+VUsIdPVQXJyrUp0efExVwhWvhoEhZMExO lTH5RnjwoaJn9edLSRVayJ1Atepk3zpsQTWGGfhz91kYvg9JqGyOBal9GX86FN3Mjrv9MCT/2KVIU /5XrF0r3TTy3/vF+LWJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCFVZ-006a2E-AW; Tue, 25 Jan 2022 06:40:49 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCFVV-006a1u-GT for linux-arm-kernel@lists.infradead.org; Tue, 25 Jan 2022 06:40:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0597560FF4; Tue, 25 Jan 2022 06:40:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A039C340E0; Tue, 25 Jan 2022 06:40:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643092844; bh=Lwx8mO5mMqVbKGdRGLJ5Wq0V96nxImmH2K5npNDXyPo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aDYbJ54OdpYQH01sLWo6acgjo8qZxxsj5hf0BEz/3pM17AdmYDd79I60lzTIhUpBK tZ/Zd0fkpj1zZVVnwb8BY7KdPS6sn/d8iGvu3AGEeoa8s5JGpLsc/+8QoBTSn5sy4K 87ue1vH1zG2J+UYhwUx8uABQlsy4hNN5IXf1XY2azdir6SF+kaA/SlosgGa2efuaF1 dIS+zic5ikcm9DkMo/w3YJOlOas99uUHjhYpq45XLImKkrP2s48ipbUuHkqZ+T5XT0 RNiRAINIfyy47CjENgEG8forPLg5AJ7Rng/PFlnhr63dgLAxKNdpQ53/wntdqWq2Oa QILBRw3Jb5mgA== Date: Mon, 24 Jan 2022 22:40:42 -0800 From: Eric Biggers To: "Jason A. Donenfeld" Cc: Linux ARM , Linux Crypto Mailing List , Linux Kernel Mailing List , llvm@lists.linux.dev, Nick Desaulniers , Sami Tolvanen , Nathan Chancellor , Herbert Xu , Miles Chen , Ard Biesheuvel Subject: Re: [PATCH v2] lib/crypto: blake2s: avoid indirect calls to compression function for Clang CFI Message-ID: References: <20220119135450.564115-1-Jason@zx2c4.com> <20220124192849.14755-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220124192849.14755-1-Jason@zx2c4.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220124_224045_636050_F3CDA4FD X-CRM114-Status: GOOD ( 11.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 24, 2022 at 08:28:49PM +0100, Jason A. Donenfeld wrote: > blake2s_compress_generic is weakly aliased by blake2s_generic. The Don't you mean "weakly aliased by blake2s_compress"? > Fixes: 6048fdcc5f26 ("lib/crypto: blake2s: include as built-in") > Reported-by: Miles Chen > Tested-by: Miles Chen > Tested-by: Nathan Chancellor > Link: https://github.com/ClangBuiltLinux/linux/issues/1567 > Cc: Nick Desaulniers > Cc: Sami Tolvanen > Cc: Ard Biesheuvel > Signed-off-by: Jason A. Donenfeld > --- Otherwise this looks fine, though it's unfortunate this is needed. You can add: Reviewed-by: Eric Biggers > Changes v1->v2: > - Wrapped columns at 80 for Eric. It is the recommended coding style, so not just for me :-) - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel