From: Catalin Marinas <catalin.marinas@arm.com>
To: Kevin Bracey <kevin@bracey.fi>
Cc: linux-arm-kernel@lists.infradead.org,
Ard Biesheuvel <ardb@kernel.org>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH v2 4/4] arm64: accelerate crc32_be
Date: Tue, 18 Jan 2022 09:51:41 +0000 [thread overview]
Message-ID: <YeaNrUGYAbW/Jy4m@arm.com> (raw)
In-Reply-To: <20220113165807.2735949-5-kevin@bracey.fi>
On Thu, Jan 13, 2022 at 06:58:07PM +0200, Kevin Bracey wrote:
> It makes no sense to leave crc32_be using the generic code while we
> only accelerate the little-endian ops.
>
> Even though the big-endian form doesn't fit as smoothly into the arm64,
> we can speed it up and avoid hitting the D cache.
>
> Tested on Cortex-A53. Without acceleration:
>
> crc32: CRC_LE_BITS = 64, CRC_BE BITS = 64
> crc32: self tests passed, processed 225944 bytes in 192240 nsec
> crc32c: CRC_LE_BITS = 64
> crc32c: self tests passed, processed 112972 bytes in 21360 nsec
>
> With acceleration:
>
> crc32: CRC_LE_BITS = 64, CRC_BE BITS = 64
> crc32: self tests passed, processed 225944 bytes in 53480 nsec
> crc32c: CRC_LE_BITS = 64
> crc32c: self tests passed, processed 112972 bytes in 21480 nsec
>
> Signed-off-by: Kevin Bracey <kevin@bracey.fi>
> Tested-by: Ard Biesheuvel <ardb@kernel.org>
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-01-18 9:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 16:58 [PATCH v2 0/4] arm64: accelerate crc32_be Kevin Bracey
2022-01-13 16:58 ` [PATCH v2 1/4] lib/crc32.c: remove unneeded casts Kevin Bracey
2022-01-13 16:58 ` [PATCH v2 2/4] lib/crc32.c: Make crc32_be weak for arch override Kevin Bracey
2022-01-13 16:58 ` [PATCH v2 3/4] lib/crc32test.c: correct printed bytes count Kevin Bracey
2022-01-13 16:58 ` [PATCH v2 4/4] arm64: accelerate crc32_be Kevin Bracey
2022-01-18 7:46 ` Ard Biesheuvel
2022-01-18 9:51 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeaNrUGYAbW/Jy4m@arm.com \
--to=catalin.marinas@arm.com \
--cc=ardb@kernel.org \
--cc=kevin@bracey.fi \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).