From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, arnd@arndb.de,
linus.walleij@linaro.org, stable@vger.kernel.org
Subject: Re: [PATCH] ARM: Thumb2: align ALT_UP() sections sufficiently
Date: Tue, 18 Jan 2022 11:21:20 +0000 [thread overview]
Message-ID: <YeaisFN1ru7suF1Y@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220118102756.1259149-1-ardb@kernel.org>
On Tue, Jan 18, 2022 at 11:27:56AM +0100, Ard Biesheuvel wrote:
> When building for Thumb2, the .alt.smp.init sections that are emitted by
> the ALT_UP() patching code may not be 32-bit aligned, even though the
> fixup_smp_on_up() routine expects that. This results in alignment faults
> at module load time, which need to be fixed up by the fault handler.
>
> So let's align those sections explicitly, and avoid this from occurring.
Are you seeing a problem that this patch fixes?
This really should not matter. .alt.smp.init contents are always a whole
number of 32-bit words. These are gathered by the linker into the
.init.smpalt section, so the contents should always be a whole number
of 32-bit words.
This follows the .init.tagtable section, which is also a 32-bit word
aligned structure built by the linker... which follows the
.init.arch.info section and .init.proc.info sections which all have
32-bit alignment requirements.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-18 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 10:27 [PATCH] ARM: Thumb2: align ALT_UP() sections sufficiently Ard Biesheuvel
2022-01-18 11:21 ` Russell King (Oracle) [this message]
2022-01-18 11:32 ` Ard Biesheuvel
2022-01-18 11:35 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeaisFN1ru7suF1Y@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).