From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A910BC433EF for ; Fri, 21 Jan 2022 22:46:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r1zU+s62n9ODTV3kjXbOF4UMcJi4Wae2ZF5q+eaTJVA=; b=SR/rzBNPzfThfh bm5ggglEapNXd7DhwC5F5Deh5DgPhVo4f5REe39ymQBlqwRwQGerbCeTHAQoD9/GMwunVrGub3jjE cZKCiWrrqWO9/U79MWYFaZ7iKgXdNDjufXgXxSt5e9bNlYy6jEo2oxXlUIaLTuCls7MCQDqKBzLgq o0eA+0mAYtjWMOLTO7+2TkP2BO9GfI2X/dPy8yBHq6Lb8K8mdY+WclSYN/BCTdh4xy5nRIO9I67v6 nU07FOQGNWuu0XRi7ewqdigr0Llv+kKWO2KjrwqKYwasThMBHDhhID2R+UKFIfItZugAKliAtOWBd 81dnKBVaL9XkcqJ03Rkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nB2ez-00GCdx-SR; Fri, 21 Jan 2022 22:45:34 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nB2ew-00GCcU-9F; Fri, 21 Jan 2022 22:45:31 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9F37525B; Fri, 21 Jan 2022 23:45:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1642805123; bh=MTvhs1Ji3raiFOvOg+D9/nZXJCTIHgAe9pLcbHUqokA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vOlt4XVRAgTLlKVZ8KyU5yTSTLG60rdslIJRDihqW7EhDcVE6ayoUEZ/HiQBD5fO6 MtgAvIhAdtFYrBl/y8FfwSM93KP+NlW2zGer8XRgy+fHJjZaXkaNCYDn6dn6M7hkIH RFHQK/2tu80u5DbhwgUQcrkhV5asm/soaBjWlKxY= Date: Sat, 22 Jan 2022 00:45:07 +0200 From: Laurent Pinchart To: Jean-Michel Hautbois Cc: dave.stevenson@raspberrypi.com, devicetree@vger.kernel.org, kernel-list@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, lukasz@jany.st, mchehab@kernel.org, naush@raspberrypi.com, robh@kernel.org, tomi.valkeinen@ideasonboard.com Subject: Re: [RFC PATCH v2 5/7] ARM: dts: bcm2711: Add unicam CSI nodes Message-ID: References: <20220121081810.155500-1-jeanmichel.hautbois@ideasonboard.com> <20220121081810.155500-6-jeanmichel.hautbois@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220121081810.155500-6-jeanmichel.hautbois@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220121_144530_508478_05FA58F3 X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jean-Michel, Thank you for the patch. On Fri, Jan 21, 2022 at 09:18:08AM +0100, Jean-Michel Hautbois wrote: > Add both MIPI CSI-2 nodes in the core bcm2711 tree. Use the 3-cells > interrupt declaration, corresponding clocks and default as disabled. > > Signed-off-by: Jean-Michel Hautbois > --- > arch/arm/boot/dts/bcm2711.dtsi | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > > diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi > index dff18fc9a906..077141df7024 100644 > --- a/arch/arm/boot/dts/bcm2711.dtsi > +++ b/arch/arm/boot/dts/bcm2711.dtsi > @@ -3,6 +3,7 @@ > > #include > #include > +#include > > / { > compatible = "brcm,bcm2711"; > @@ -293,6 +294,36 @@ hvs: hvs@7e400000 { > interrupts = ; > }; > > + csi0: csi1@7e800000 { The node name should be csi@7e800000, not csi1@7e800000. Now, this will probably cause issues with the firmware that looks for csi1 (and csi0 ?) to hand over control of the Unicam CSI-2 receiver to the kernel. I wonder if this is something that could be handled by a firmware update, to also recognize nodes named "csi" ? > + compatible = "brcm,bcm2835-unicam"; > + reg = <0x7e800000 0x800>, > + <0x7e802000 0x4>; > + interrupts = ; > + clocks = <&clocks BCM2835_CLOCK_CAM0>, > + <&firmware_clocks 4>; > + clock-names = "lp", "vpu"; > + power-domains = <&power RPI_POWER_DOMAIN_UNICAM0>; > + #address-cells = <1>; > + #size-cells = <0>; > + #clock-cells = <1>; Why do you need #address-cells, #size-cells and #clock-cells ? They're not mentioned in the binding. > + status="disabled"; Missing spaces around the =. Same comment for the next node. > + }; > + > + csi1: csi1@7e801000 { > + compatible = "brcm,bcm2835-unicam"; > + reg = <0x7e801000 0x800>, > + <0x7e802004 0x4>; > + interrupts = ; > + clocks = <&clocks BCM2835_CLOCK_CAM1>, > + <&firmware_clocks 4>; > + clock-names = "lp", "vpu"; > + power-domains = <&power RPI_POWER_DOMAIN_UNICAM1>; > + #address-cells = <1>; > + #size-cells = <0>; > + #clock-cells = <1>; > + status="disabled"; > + }; > + > pixelvalve3: pixelvalve@7ec12000 { > compatible = "brcm,bcm2711-pixelvalve3"; > reg = <0x7ec12000 0x100>; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel