From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CC5AC433EF for ; Fri, 21 Jan 2022 23:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QCVqhHM0aNQTjxJFPAZB7pYgzBGuGjIZNydONJ1cezk=; b=iQIzqqOSUHj+Fk +K05kq8f1ltowteofmz/VuoRGwJdOFnz7mUOW5HZfafEUz2F6InizpQ6M20TPllotvJgr1t6XZyfO 2TjkUFT9NOMRX2caPjQrkow5sEb5ef2J2Cv03AP+I6LTWb9nabMkp66UELj3T9K090mOXVFjgdFJa c7mmI9VBnd87det4xQShWyAW3Hs28U2Ny0Pfx7Jva2nDqrtnK9lAoxh8Tdzt/nK1977yXLjZufkD+ eueUCyxyYscxpSIQUdX9QVuhrhT0V0AMOFCkxsRYQEqDRzGnJJRxyMZtlvBZX/w7pH8kYksX28CZI YrZKW4iGwvDTo2Dp7R9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nB3Me-00GF4l-7s; Fri, 21 Jan 2022 23:30:40 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nB3Ma-00GF4C-IK; Fri, 21 Jan 2022 23:30:38 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DEDB2E51; Sat, 22 Jan 2022 00:30:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1642807834; bh=KQ0Hr6Z8amphyQBRIxQGNR2EMiK2F+TIpQNXyIvXSnU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JIimzzy/LjjhsE3p8veM0Sm4rXiTtpXNGJLkP1CAs50k152YuJNikpAe1c3lwISU+ JFi3wApfsc1aACQDKyg0HF2Xo179226KiFpwY7XCmcsiZtFbJzRvrQFxxj0Ovf0QqD I3z3PxeANtDBd75h0bAWq5UupifCqpAvsM6MN+eM= Date: Sat, 22 Jan 2022 01:30:17 +0200 From: Laurent Pinchart To: Jean-Michel Hautbois Cc: dave.stevenson@raspberrypi.com, devicetree@vger.kernel.org, kernel-list@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, lukasz@jany.st, mchehab@kernel.org, naush@raspberrypi.com, robh@kernel.org, tomi.valkeinen@ideasonboard.com Subject: Re: [RFC PATCH v2 7/7] media: bcm283x: Include the imx219 node Message-ID: References: <20220121081810.155500-1-jeanmichel.hautbois@ideasonboard.com> <20220121081810.155500-8-jeanmichel.hautbois@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220121081810.155500-8-jeanmichel.hautbois@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220121_153036_781385_8734234D X-CRM114-Status: GOOD ( 19.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jean-Michel, Thank you for the patch. On Fri, Jan 21, 2022 at 09:18:10AM +0100, Jean-Michel Hautbois wrote: > Configure the csi1 endpoint, add the imx219 node and connect it through > the i2c mux. This is not meant to be upstreamed, is it ? Please say so very loudly in the commit message. > Signed-off-by: Jean-Michel Hautbois > --- > MAINTAINERS | 1 + > arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 1 + > arch/arm/boot/dts/bcm283x-rpi-imx219.dtsi | 102 ++++++++++++++++++++++ > 3 files changed, 104 insertions(+) > create mode 100644 arch/arm/boot/dts/bcm283x-rpi-imx219.dtsi > > diff --git a/MAINTAINERS b/MAINTAINERS > index b17bb533e007..56544ac98d69 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3684,6 +3684,7 @@ M: Raspberry Pi Kernel Maintenance > L: linux-media@vger.kernel.org > S: Maintained > F: Documentation/devicetree/bindings/media/brcm,bcm2835-unicam.yaml > +F: arch/arm/boot/dts/bcm283x* > F: drivers/media/platform/bcm2835/ > > BROADCOM BCM47XX MIPS ARCHITECTURE > diff --git a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts > index 4432412044de..f7625b70fe57 100644 > --- a/arch/arm/boot/dts/bcm2711-rpi-4-b.dts > +++ b/arch/arm/boot/dts/bcm2711-rpi-4-b.dts > @@ -4,6 +4,7 @@ > #include "bcm2711-rpi.dtsi" > #include "bcm283x-rpi-usb-peripheral.dtsi" > #include "bcm283x-rpi-wifi-bt.dtsi" > +#include "bcm283x-rpi-imx219.dtsi" Let's use an overlay instead. > > / { > compatible = "raspberrypi,4-model-b", "brcm,bcm2711"; > diff --git a/arch/arm/boot/dts/bcm283x-rpi-imx219.dtsi b/arch/arm/boot/dts/bcm283x-rpi-imx219.dtsi > new file mode 100644 > index 000000000000..f2c6a85fd731 > --- /dev/null > +++ b/arch/arm/boot/dts/bcm283x-rpi-imx219.dtsi > @@ -0,0 +1,102 @@ > +// SPDX-License-Identifier: GPL-2.0 > +#include > + > +/ { > + compatible = "brcm,bcm2835"; > + > + imx219_vdig: fixedregulator@1 { > + compatible = "regulator-fixed"; > + regulator-name = "imx219_vdig"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + imx219_vddl: fixedregulator@2 { > + compatible = "regulator-fixed"; > + regulator-name = "imx219_vddl"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + }; > + > + imx219_clk: imx219_clk { > + #clock-cells = <0>; > + compatible = "fixed-clock"; > + clock-frequency = <24000000>; > + clock-output-names = "24MHz-clock"; > + }; > + > + cam1_reg: cam1_reg { > + compatible = "regulator-fixed"; > + regulator-name = "imx219_vana"; > + enable-active-high; > + status = "okay"; > + gpio = <&expgpio 5 GPIO_ACTIVE_HIGH>; > + }; This regulator belongs to the board dtsi. Same for the I2C mux below (but not the imx219 of course). > + > + i2c0mux { > + compatible = "i2c-mux-pinctrl"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + i2c-parent = <&i2c0>; > + > + pinctrl-names = "i2c0", "i2c_csi_dsi"; > + pinctrl-0 = <&i2c0_gpio0>; > + pinctrl-1 = <&i2c0_gpio44>; > + > + i2c@0 { > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + i2c@1 { > + reg = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + imx219: sensor@10 { > + compatible = "sony,imx219"; > + reg = <0x10>; > + status = "okay"; > + > + clocks = <&imx219_clk>; > + clock-names = "xclk"; > + > + VANA-supply = <&cam1_reg>; /* 2.8v */ > + VDIG-supply = <&imx219_vdig>; /* 1.8v */ > + VDDL-supply = <&imx219_vddl>; /* 1.2v */ > + > + rotation = <0>; > + orientation = <0>; > + > + port { > + imx219_0: endpoint { > + remote-endpoint = <&csi1_ep>; > + clock-lanes = <0>; > + data-lanes = <1 2>; > + clock-noncontinuous; > + link-frequencies = /bits/ 64 <456000000>; > + }; > + }; > + }; > + }; > + }; > +}; > + > +&csi1 { > + status="okay"; > + num-data-lanes = <2>; > + port { > + csi1_ep: endpoint { > + remote-endpoint = <&imx219_0>; > + data-lanes = <1 2>; > + clock-lanes = <0>; > + }; > + }; > +}; > + > +&i2c0 { > + /delete-property/ pinctrl-names; > + /delete-property/ pinctrl-0; > +}; > + -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel