From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28850C433F5 for ; Fri, 4 Feb 2022 18:47:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AQLClQH8zQDE8/2895j6XUFHheIXiXl8LkGjl+Dsm3Y=; b=ySrMQDRqchzMHg /1RCIfm7jnbOYY+L6m1190cBBrLujyWxm6iequtannLdUG+Bxl1a2nHKq2gCQTVm9SZkna1EbaU9u HO+cpDUYs+9/EvU31c/KZnSyYV3nyyHy//QvUIi0gPQNsyHAkYiLFIDcGyphMIN+OxBWp4p8+Pnix 1KaMpYEen+R9oc2Mc6lk8vNhUWz7agqlMS/4v9BxddZusA5NCxA+07VWiwOAQhRL7NqGGeM5QAshp FY57j6fBSuTwEptINY4KepGKiRVZdIPpY8IK/bRB9gLNVkDzhPUzCiZgof3RGvvcVqE0StZprz1R+ PTWmYY6feDFBB1HKyaUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nG3bY-005Cmp-Ng; Fri, 04 Feb 2022 18:46:44 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nG3bV-005Clq-GW for linux-arm-kernel@lists.infradead.org; Fri, 04 Feb 2022 18:46:42 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 175C161C0A; Fri, 4 Feb 2022 18:46:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 984CEC004E1; Fri, 4 Feb 2022 18:46:37 +0000 (UTC) Date: Fri, 4 Feb 2022 18:46:34 +0000 From: Catalin Marinas To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, ardb@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, frederic@kernel.org, james.morse@arm.com, joey.gouly@arm.com, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de, valentin.schneider@arm.com, will@kernel.org Subject: Re: [PATCH v2 6/7] arm64: entry: centralize premeption decision Message-ID: References: <20220204150557.434610-1-mark.rutland@arm.com> <20220204150557.434610-7-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220204150557.434610-7-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220204_104641_614882_F2E20A05 X-CRM114-Status: GOOD ( 15.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 04, 2022 at 03:05:56PM +0000, Mark Rutland wrote: > For historical reasons, the decision of whether or not to preempt is > spread across arm64_preempt_schedule_irq() and __el1_irq(), and it would > be clearer if this were all in one place. > > Also, arm64_preempt_schedule_irq() calls lockdep_assert_irqs_disabled(), > but this is redundant, as we have a subsequent identical assertion in > __exit_to_kernel_mode(), and preempt_schedule_irq() will > BUG_ON(!irqs_disabled()) anyway. > > This patch removes the redundant assertion and centralizes the > preemption decision making within arm64_preempt_schedule_irq(). > > Other than the slight change to assertion behaviour, there should be no > functional change as a result of this patch. > > Signed-off-by: Mark Rutland > Cc: Catalin Marinas > Cc: James Morse > Cc: Joey Gouly > Cc: Valentin Schneider > Cc: Will Deacon Acked-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel