From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 681D8C433F5 for ; Sat, 5 Feb 2022 04:09:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GuQpzn8p67Tvvlspwzk3lSi4mQ+/N78Q4WXYLb9E1S0=; b=SNfVMsqG2h0iOP kuHMONGLXLLShnUC2OP3pCX0EFmLno7mw9MzpcpwpQK59RWlv4o6jJJ+3opU69DduhFERPDSl6qJN HPoNcqa8da3z3qBgRl7malrDgE9csRqFRbfl89Q9XHs+jGGbPzQ+27bkqMRnyzj3ymA7EHRvZUajc ZgyN5t5zDmUVsGv57zwcdd0pwefCMZHUmLvtuXlRN8hcSzBQckxI4meshc/QtBoTyi2R4a0UjXcfG flbNjjd5SqhLljqzrAXFfHU6e31CGxML2Hkalqu6UpTg70j427H4ae/U88BSL1rZI3JbWjIYIKMCG 59Lbvv3NXLDKnfwbfW3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nGCMq-0064LC-76; Sat, 05 Feb 2022 04:08:08 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nGCMl-0064KT-OX for linux-arm-kernel@lists.infradead.org; Sat, 05 Feb 2022 04:08:05 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 36155472; Sat, 5 Feb 2022 05:08:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1644034082; bh=e1aTQvNM4hVzRyloYjTRlsEtW0afmvAm7HLX4Fs1Ma8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QSjTUQiwzZKyZA/WJv94gjiAUtdSJaR8wH1rNWJe++R4+j84rpLaxUO6GhyMGpkJ+ GWRFdDogOBRUmv9EnjdNJJrK7sVomBLuwFNTbKiI7tJj5hyVfdYF0hFY3BaXzgqZFv pIu5I18goC5kTRPPrqP4/n2ZKgwZI2QpOtYQLk/Q= Date: Sat, 5 Feb 2022 06:07:37 +0200 From: Laurent Pinchart To: Alexander Stein Cc: Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rui Miguel Silva , Dorota Czaplejewicz , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/8] media: imx: Fail conversion if pixel format not supported Message-ID: References: <20220204121514.2762676-1-alexander.stein@ew.tq-group.com> <20220204121514.2762676-5-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220204121514.2762676-5-alexander.stein@ew.tq-group.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220204_200804_002953_5AE8BAF4 X-CRM114-Status: GOOD ( 19.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexander and Dorota, Thank you for the patch. On Fri, Feb 04, 2022 at 01:15:10PM +0100, Alexander Stein wrote: > From: Dorota Czaplejewicz > > imx_media_find_mbus_format has NULL as a valid return value, > therefore the caller should take it into account. > > Signed-off-by: Dorota Czaplejewicz > Signed-off-by: Alexander Stein > --- > drivers/staging/media/imx/imx-media-utils.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c > index 32aaa2e81bea..e0a256a08c3b 100644 > --- a/drivers/staging/media/imx/imx-media-utils.c > +++ b/drivers/staging/media/imx/imx-media-utils.c > @@ -544,6 +544,9 @@ static int imx56_media_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix, > cc = imx_media_find_mbus_format(code, PIXFMT_SEL_YUV); The code passed to the function comes from the previous line: imx_media_enum_mbus_formats(&code, 0, PIXFMT_SEL_YUV); As far as I can tell, this is guaranteed to return a code that will result in imx_media_find_mbus_format() returning a non-NULL pointer. > } > > + if (!cc) > + return -EINVAL; > + > /* Round up width for minimum burst size */ > width = round_up(mbus->width, 8); > -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel