From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71871C433F5 for ; Sat, 5 Feb 2022 03:28:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oG601bPnfmntAFywwTRNi+hC6PyVPq8KlskvN1fftvA=; b=NflMCWBFv9qeH9 PaGxGgZ8UE4AnMGgyyj7WaqASX8oLFbh6bKEpTd6rDNAGkYkjdJgTcjPACVGPCUAi51xpf0O87pa5 jYBdZtIKy/jJ58Orqc8QOmD6uiQrsSY5GToBmvb6TwmFhasTPVE+6CGND+R3Jt7yezFCcNXdlkJHi U4sQR4h9EGeWgwZzZYo9F4Fgwr0+9x92jCROOdiMOWmuSFAJ4FNliQH2TkicfDi/1JF1B5c101P46 QF3wdhz+ZZuxyloANg9Es+m6A0WYopwbfoduWvUSgao3EPhW8WhFR/c27VupBlu9JhNIFpifMY8zg /aeudNIAXRrU5kERgqrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nGBj3-0061FL-VI; Sat, 05 Feb 2022 03:27:02 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nGBiz-0061Dc-KK for linux-arm-kernel@lists.infradead.org; Sat, 05 Feb 2022 03:26:59 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 15DE7472; Sat, 5 Feb 2022 04:26:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1644031616; bh=M+Z2tUMN6VKAi5ODQ4SChm7l3WTsONh75s17OSEBxAU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ShcgrnsG329P7DXt11eyuTz/9Ab3J050Cau5KA/N8B/U6OwxUZxMLqxcM23fYGM1B 4LzXVSMoWzzbhYY8U3A2dHLK2HVA7Y1oVNBd73EU+SnyLe1tN7bC0Jxs2MJcAuAMwc e0ZoOTYoSyqRqU3EAA2rMUQ/U7f6s1f6BieYamBc= Date: Sat, 5 Feb 2022 05:26:31 +0200 From: Laurent Pinchart To: Alexander Stein Cc: Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rui Miguel Silva , Dorota Czaplejewicz , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/8] media: imx: imx7_mipi_csis: store colorspace in set_fmt as well Message-ID: References: <20220204121514.2762676-1-alexander.stein@ew.tq-group.com> <20220204121514.2762676-6-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220204121514.2762676-6-alexander.stein@ew.tq-group.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220204_192658_393838_07B8C341 X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexander, Thank you for the patch. On Fri, Feb 04, 2022 at 01:15:11PM +0100, Alexander Stein wrote: > Without this the default (SMPTE 170M) from init_cfg stays unchanged. > Even after configuring 'srgb' colorspace (or 'raw') > $ media-ctl -V "'csis-32e30000.mipi-csi':0 [colorspace:srgb]" > the colorspace does not change at all: > $ media-ctl --get-v4l2 "'csis-32e30000.mipi-csi':0" > [fmt:SRGGB10_1X10/1920x1080 field:none colorspace:smpte170m xfer:709 > ycbcr:601 quantization:lim-range] > > Signed-off-by: Alexander Stein > --- > drivers/staging/media/imx/imx7-mipi-csis.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c > index a22d0e6b3d44..7b0e57efcf82 100644 > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > @@ -1062,6 +1062,7 @@ static int mipi_csis_set_fmt(struct v4l2_subdev *sd, > fmt->code = csis_fmt->code; > fmt->width = sdformat->format.width; > fmt->height = sdformat->format.height; > + fmt->colorspace = sdformat->format.colorspace; Looks good, but shouldn't you also store the other colorspace-related fields (ycbcr_enc, quantization and xfer_func) ? > sdformat->format = *fmt; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel