From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Steve Longerbeam <slongerbeam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Rui Miguel Silva <rmfrfs@gmail.com>,
Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/8] media: imx: utils: Add more Bayer formats
Date: Sat, 5 Feb 2022 05:31:36 +0200 [thread overview]
Message-ID: <Yf3vmMP6EfjyeXOb@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220204121514.2762676-8-alexander.stein@ew.tq-group.com>
Hi Alexander,
Thank you for the patch.
On Fri, Feb 04, 2022 at 01:15:13PM +0100, Alexander Stein wrote:
> Without this the ioctl VIDIOC_ENUM_FMT will not list the 10/12/14-Bit
> Bayer formats. This in return results in
> "v4l2-ctl --set-fmt-video pixelformat='RG10'" failing to set the
> pixelformat as it is not enumerated as supported format.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Do IPUv3-based SoCs support 10-, 12- and 14-bit formats ? If so,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> This adds the following formats to `v4l2-ctl --list-formats`
> [...]
> [18]: 'BG10' (10-bit Bayer BGBG/GRGR)
> [19]: 'GB10' (10-bit Bayer GBGB/RGRG)
> [20]: 'BA10' (10-bit Bayer GRGR/BGBG)
> [21]: 'RG10' (10-bit Bayer RGRG/GBGB)
> [22]: 'BG12' (12-bit Bayer BGBG/GRGR)
> [23]: 'GB12' (12-bit Bayer GBGB/RGRG)
> [24]: 'BA12' (12-bit Bayer GRGR/BGBG)
> [25]: 'RG12' (12-bit Bayer RGRG/GBGB)
> [26]: 'BG14' (14-bit Bayer BGBG/GRGR)
> [27]: 'GB14' (14-bit Bayer GBGB/RGRG)
> [28]: 'GR14' (14-bit Bayer GRGR/BGBG)
> [29]: 'RG14' (14-bit Bayer RGRG/GBGB)
> [...]
>
> drivers/staging/media/imx/imx-media-utils.c | 72 +++++++++++++++++++++
> 1 file changed, 72 insertions(+)
>
> diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c
> index e0a256a08c3b..ea56c82d3b32 100644
> --- a/drivers/staging/media/imx/imx-media-utils.c
> +++ b/drivers/staging/media/imx/imx-media-utils.c
> @@ -130,6 +130,78 @@ static const struct imx_media_pixfmt pixel_formats[] = {
> .cs = IPUV3_COLORSPACE_RGB,
> .bpp = 8,
> .bayer = true,
> + }, {
> + .fourcc = V4L2_PIX_FMT_SBGGR10,
> + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SBGGR10_1X10),
> + .cs = IPUV3_COLORSPACE_RGB,
> + .bpp = 10,
> + .bayer = true,
> + }, {
> + .fourcc = V4L2_PIX_FMT_SGBRG10,
> + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGBRG10_1X10),
> + .cs = IPUV3_COLORSPACE_RGB,
> + .bpp = 10,
> + .bayer = true,
> + }, {
> + .fourcc = V4L2_PIX_FMT_SGRBG10,
> + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGRBG10_1X10),
> + .cs = IPUV3_COLORSPACE_RGB,
> + .bpp = 10,
> + .bayer = true,
> + }, {
> + .fourcc = V4L2_PIX_FMT_SRGGB10,
> + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SRGGB10_1X10),
> + .cs = IPUV3_COLORSPACE_RGB,
> + .bpp = 10,
> + .bayer = true,
> + }, {
> + .fourcc = V4L2_PIX_FMT_SBGGR12,
> + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SBGGR12_1X12),
> + .cs = IPUV3_COLORSPACE_RGB,
> + .bpp = 12,
> + .bayer = true,
> + }, {
> + .fourcc = V4L2_PIX_FMT_SGBRG12,
> + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGBRG12_1X12),
> + .cs = IPUV3_COLORSPACE_RGB,
> + .bpp = 12,
> + .bayer = true,
> + }, {
> + .fourcc = V4L2_PIX_FMT_SGRBG12,
> + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGRBG12_1X12),
> + .cs = IPUV3_COLORSPACE_RGB,
> + .bpp = 12,
> + .bayer = true,
> + }, {
> + .fourcc = V4L2_PIX_FMT_SRGGB12,
> + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SRGGB12_1X12),
> + .cs = IPUV3_COLORSPACE_RGB,
> + .bpp = 12,
> + .bayer = true,
> + }, {
> + .fourcc = V4L2_PIX_FMT_SBGGR14,
> + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SBGGR14_1X14),
> + .cs = IPUV3_COLORSPACE_RGB,
> + .bpp = 14,
> + .bayer = true,
> + }, {
> + .fourcc = V4L2_PIX_FMT_SGBRG14,
> + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGBRG14_1X14),
> + .cs = IPUV3_COLORSPACE_RGB,
> + .bpp = 14,
> + .bayer = true,
> + }, {
> + .fourcc = V4L2_PIX_FMT_SGRBG14,
> + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGRBG14_1X14),
> + .cs = IPUV3_COLORSPACE_RGB,
> + .bpp = 14,
> + .bayer = true,
> + }, {
> + .fourcc = V4L2_PIX_FMT_SRGGB14,
> + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SRGGB14_1X14),
> + .cs = IPUV3_COLORSPACE_RGB,
> + .bpp = 14,
> + .bayer = true,
> }, {
> .fourcc = V4L2_PIX_FMT_SBGGR16,
> .codes = IMX_BUS_FMTS(
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-05 3:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 12:15 [PATCH 0/8] imx7/imx8mm media / csi patches Alexander Stein
2022-02-04 12:15 ` [PATCH 1/8] media: imx: Store the type of hardware implementation Alexander Stein
2022-02-05 3:21 ` Laurent Pinchart
2022-02-07 9:22 ` (EXT) " Alexander Stein
2022-02-08 1:26 ` Laurent Pinchart
2022-02-04 12:15 ` [PATCH 2/8] media: imx: Forward " Alexander Stein
2022-02-05 3:41 ` Laurent Pinchart
2022-02-04 12:15 ` [PATCH 3/8] media: imx: Use dedicated format handler for i.MX7/8 Alexander Stein
2022-02-05 4:04 ` Laurent Pinchart
2022-02-07 12:08 ` (EXT) " Alexander Stein
2022-02-04 12:15 ` [PATCH 4/8] media: imx: Fail conversion if pixel format not supported Alexander Stein
2022-02-05 4:07 ` Laurent Pinchart
2022-02-05 7:51 ` Dorota Czaplejewicz
2022-02-07 9:52 ` (EXT) " Alexander Stein
2022-02-08 1:14 ` Laurent Pinchart
2022-02-04 12:15 ` [PATCH 5/8] media: imx: imx7_mipi_csis: store colorspace in set_fmt as well Alexander Stein
2022-02-05 3:26 ` Laurent Pinchart
2022-02-07 9:55 ` (EXT) " Alexander Stein
2022-02-04 12:15 ` [PATCH 6/8] media: imx: imx7_media-csi: Add support for additional Bayer patterns Alexander Stein
2022-02-05 3:40 ` Laurent Pinchart
2022-02-07 10:01 ` (EXT) " Alexander Stein
2022-02-04 12:15 ` [PATCH 7/8] media: imx: utils: Add more Bayer formats Alexander Stein
2022-02-05 3:31 ` Laurent Pinchart [this message]
2022-02-07 10:35 ` (EXT) " Alexander Stein
2022-02-04 12:15 ` [PATCH 8/8] [DNI] arm64: dts: tqma8mqml: add IMX327 MIPI-CSI overlay Alexander Stein
2022-02-05 3:16 ` [PATCH 0/8] imx7/imx8mm media / csi patches Laurent Pinchart
2022-02-07 8:59 ` (EXT) " Alexander Stein
2022-02-08 1:20 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yf3vmMP6EfjyeXOb@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=dorota.czaplejewicz@puri.sm \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rmfrfs@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).