From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56599C433F5 for ; Sat, 5 Feb 2022 03:33:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=15ZX3tVA56j/1gIogFeix9L9XmrFvmy42wm80B0r4Ms=; b=kUEKeK9gpBT+1U CtImjWfSmSkHNhN7YiHsdMpgRCl0+XnJRftafqFqsMJNZ6t4pNQ0Aktzesa5xPpwEnW/uXBC5Ausg UvhxnrWdHVG6+MvVIiFOr9efMaKUQDZcdylRy4xUAxH7LAFDY6/gvv5mYqnjx2JwB7odcb0QKojEs WvqtqHBhvqxDIfeGx3McKA9sDqe9lLpQy4NASlucHYsUzfVkUP5BE0IgiIq2c1dpwXjeRBp2Ciy9q iuTQteG64DvmsQxfheV9fXNqpAxiVB2kq63cwCzPpKdr6lRSDL127Wtedkr47L4V3dhvOJvK3UboM 3uip27zWONXHes/C3qWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nGBny-0061uZ-7C; Sat, 05 Feb 2022 03:32:06 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nGBnu-0061tv-Ko for linux-arm-kernel@lists.infradead.org; Sat, 05 Feb 2022 03:32:04 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 13910472; Sat, 5 Feb 2022 04:32:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1644031921; bh=SrkGQlf2EU1eLY/+UA1XooxeJOZ8W6H/0uZw7v2rA08=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=axBERtk2GYLbaU4jANuPSUKctb5hTkxD98/2XceNnmb/zbr06saHj5alzjf+Joqy6 pNLwUxWLjDJcfukkBn9wmULjjs53WTD3QVJSd1SjAOWqtHkhGyCSaS+Q0iaa0SFnCs s/ITgEM1a7aEFCvDGoYkqPuhrjMgCe80JBhZ1tpk= Date: Sat, 5 Feb 2022 05:31:36 +0200 From: Laurent Pinchart To: Alexander Stein Cc: Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rui Miguel Silva , Dorota Czaplejewicz , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/8] media: imx: utils: Add more Bayer formats Message-ID: References: <20220204121514.2762676-1-alexander.stein@ew.tq-group.com> <20220204121514.2762676-8-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220204121514.2762676-8-alexander.stein@ew.tq-group.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220204_193202_845954_BB19CF63 X-CRM114-Status: GOOD ( 17.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexander, Thank you for the patch. On Fri, Feb 04, 2022 at 01:15:13PM +0100, Alexander Stein wrote: > Without this the ioctl VIDIOC_ENUM_FMT will not list the 10/12/14-Bit > Bayer formats. This in return results in > "v4l2-ctl --set-fmt-video pixelformat='RG10'" failing to set the > pixelformat as it is not enumerated as supported format. > > Signed-off-by: Alexander Stein Do IPUv3-based SoCs support 10-, 12- and 14-bit formats ? If so, Reviewed-by: Laurent Pinchart > --- > This adds the following formats to `v4l2-ctl --list-formats` > [...] > [18]: 'BG10' (10-bit Bayer BGBG/GRGR) > [19]: 'GB10' (10-bit Bayer GBGB/RGRG) > [20]: 'BA10' (10-bit Bayer GRGR/BGBG) > [21]: 'RG10' (10-bit Bayer RGRG/GBGB) > [22]: 'BG12' (12-bit Bayer BGBG/GRGR) > [23]: 'GB12' (12-bit Bayer GBGB/RGRG) > [24]: 'BA12' (12-bit Bayer GRGR/BGBG) > [25]: 'RG12' (12-bit Bayer RGRG/GBGB) > [26]: 'BG14' (14-bit Bayer BGBG/GRGR) > [27]: 'GB14' (14-bit Bayer GBGB/RGRG) > [28]: 'GR14' (14-bit Bayer GRGR/BGBG) > [29]: 'RG14' (14-bit Bayer RGRG/GBGB) > [...] > > drivers/staging/media/imx/imx-media-utils.c | 72 +++++++++++++++++++++ > 1 file changed, 72 insertions(+) > > diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c > index e0a256a08c3b..ea56c82d3b32 100644 > --- a/drivers/staging/media/imx/imx-media-utils.c > +++ b/drivers/staging/media/imx/imx-media-utils.c > @@ -130,6 +130,78 @@ static const struct imx_media_pixfmt pixel_formats[] = { > .cs = IPUV3_COLORSPACE_RGB, > .bpp = 8, > .bayer = true, > + }, { > + .fourcc = V4L2_PIX_FMT_SBGGR10, > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SBGGR10_1X10), > + .cs = IPUV3_COLORSPACE_RGB, > + .bpp = 10, > + .bayer = true, > + }, { > + .fourcc = V4L2_PIX_FMT_SGBRG10, > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGBRG10_1X10), > + .cs = IPUV3_COLORSPACE_RGB, > + .bpp = 10, > + .bayer = true, > + }, { > + .fourcc = V4L2_PIX_FMT_SGRBG10, > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGRBG10_1X10), > + .cs = IPUV3_COLORSPACE_RGB, > + .bpp = 10, > + .bayer = true, > + }, { > + .fourcc = V4L2_PIX_FMT_SRGGB10, > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SRGGB10_1X10), > + .cs = IPUV3_COLORSPACE_RGB, > + .bpp = 10, > + .bayer = true, > + }, { > + .fourcc = V4L2_PIX_FMT_SBGGR12, > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SBGGR12_1X12), > + .cs = IPUV3_COLORSPACE_RGB, > + .bpp = 12, > + .bayer = true, > + }, { > + .fourcc = V4L2_PIX_FMT_SGBRG12, > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGBRG12_1X12), > + .cs = IPUV3_COLORSPACE_RGB, > + .bpp = 12, > + .bayer = true, > + }, { > + .fourcc = V4L2_PIX_FMT_SGRBG12, > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGRBG12_1X12), > + .cs = IPUV3_COLORSPACE_RGB, > + .bpp = 12, > + .bayer = true, > + }, { > + .fourcc = V4L2_PIX_FMT_SRGGB12, > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SRGGB12_1X12), > + .cs = IPUV3_COLORSPACE_RGB, > + .bpp = 12, > + .bayer = true, > + }, { > + .fourcc = V4L2_PIX_FMT_SBGGR14, > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SBGGR14_1X14), > + .cs = IPUV3_COLORSPACE_RGB, > + .bpp = 14, > + .bayer = true, > + }, { > + .fourcc = V4L2_PIX_FMT_SGBRG14, > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGBRG14_1X14), > + .cs = IPUV3_COLORSPACE_RGB, > + .bpp = 14, > + .bayer = true, > + }, { > + .fourcc = V4L2_PIX_FMT_SGRBG14, > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SGRBG14_1X14), > + .cs = IPUV3_COLORSPACE_RGB, > + .bpp = 14, > + .bayer = true, > + }, { > + .fourcc = V4L2_PIX_FMT_SRGGB14, > + .codes = IMX_BUS_FMTS(MEDIA_BUS_FMT_SRGGB14_1X14), > + .cs = IPUV3_COLORSPACE_RGB, > + .bpp = 14, > + .bayer = true, > }, { > .fourcc = V4L2_PIX_FMT_SBGGR16, > .codes = IMX_BUS_FMTS( -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel