From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3ED30C4332F for ; Tue, 25 Jan 2022 16:34:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9fe02W5r+o4VxhHGJnlyR/IxitLfFSA5Uj08YUl14Jk=; b=fsB4V82tRY0vSZ lQerCDtpARwgDDsOyYO1mvhXvlnzf4hm0uoXXY8z7ls2FdtGqHQM69IJmovjdCF58EdNeIl5wxwhE i08Q47jCqMxjNX6QtGn+dgsChJTE0ykFu1ieYnFgFdwd7C4cvIlY4GoPg+j0JFu7VRcYNqzeg93vp a3TrfnTJF72Kq4AP1+xnka7PQk/yXuUZgAyRcKrwF9xRIgpbn9HKXRhBXw9OVo3S9J8sBrLS9IqpJ CfhLVPdw2TDCS/KuKRutno0cQFOgpTGvafDFWXq6u1uJ9RVWl2G/GzH0eNZF6ucv6CasPFq12+Q3s Wgf0z89dMXLVYZVMUxaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCOlQ-008gvi-Ja; Tue, 25 Jan 2022 16:33:48 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCOlM-008gsj-Gw for linux-arm-kernel@lists.infradead.org; Tue, 25 Jan 2022 16:33:45 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 83D8C1FB; Tue, 25 Jan 2022 08:33:43 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.1.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 393E73F766; Tue, 25 Jan 2022 08:33:42 -0800 (PST) Date: Tue, 25 Jan 2022 16:33:39 +0000 From: Mark Rutland To: Mark Brown Cc: linux-arm-kernel@lists.infradead.org, andre.przywara@arm.com, jaxson.han@arm.com, robin.murphy@arm.com, vladimir.murzin@arm.com, wei.chen@arm.com Subject: Re: [bootwrapper PATCH v3 01/15] aarch64: correct ZCR_EL3.LEN initialization Message-ID: References: <20220125150057.3936090-1-mark.rutland@arm.com> <20220125150057.3936090-2-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220125_083344_631246_455F57AB X-CRM114-Status: GOOD ( 15.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 25, 2022 at 03:59:38PM +0000, Mark Brown wrote: > On Tue, Jan 25, 2022 at 03:00:43PM +0000, Mark Rutland wrote: > > > As the same time, rename ZCR_EL3_LEN_MASK to ZCR_EL3_LEN_MAX, as it is > > used as a value rather than as a bit mask. > > Well, it's both and we do call it a mask in both the kernel and TF-A > too... Here specifically in the boot-wrapper I'm just using it as a value, so I don't see that those are relevant? The idea was to be consistent with the __ naming, and avoiding the "why are you programming a mask as the value" questions from last time around, where the unambiguous options are: a) Use __ definition, as here. b) Use __MASK, and add comments at each usage as to why we use a mask as a value, to explain why that isn't a bug. c) Have both __MASK and some value definition, and use some insertion helper to insert the value. ... and I went with (a) because it was the simplest. Is there a problem with this? Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel