From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A02EC433F5 for ; Tue, 25 Jan 2022 18:51:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ot7K0wFNkxu0sbDU9pRJ2T/0sZk95QLoFWnjoSlAa5A=; b=KsQNeACS3XNls+ 3J72efpl+mBInwUh+YY82GwIjOv97aPgIq88rBOw5b7J37B/gANURsZQW/qTi0iH5U7kLpa0HMJs8 XLu7AitnEK3w1j8hDXhDPviyb/TqYSAAsDrwwV063tm9ncAYnR6gofnX7XackQJf0ccCAKsKWPqDg eZxStbiwWSWUeSbUEIESkWLOyVNR6zATt10Uc9kgk8fRd8rbKl5FHc4UMXiWhKAicFZxo5uS2N0Lw GQXSc0a+KAEOVM5/S7uRy99uqPx/NAeBLrkkCAOoWePYaLXl7s85irChwCGQJ3tOf2ymHP/wF6uou SfUA6PBGh9+i95yQCIIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCQu4-009G9d-FB; Tue, 25 Jan 2022 18:50:52 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCQu0-009G8q-Vu for linux-arm-kernel@lists.infradead.org; Tue, 25 Jan 2022 18:50:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D14B7615E6; Tue, 25 Jan 2022 18:50:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E9E1C340E0; Tue, 25 Jan 2022 18:50:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643136647; bh=dlASoV/4lF867bA7sGuPYeGD/FvkmE6iuFIQvCJWTbQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NbtMbjCyLHXfxCtuuXx0wAiqzOL+hLc5Y7tbneRktp48TGDQJBngekACp0qixhHkX sV7OyhLY5/i6lL3+ekLOr+SX4sf1K8p+z0P8GUxpINaluCfWWhgDRraq6jVS3HDMgz 6RGxwB6uS7G4UinVI5f25gKe6kfI+4B18VLULszG0ZhMQMFQewA8+4bw4R2bpApKRH Ummj6K1MaOvSMOfQzEiepanYgwfT7WfR4nz/YNtXxdH3qEGcD4uv+iNkQZoUq9NDMW 8eMwUCNBOqHUUQuYteo3bU/3g+60G9EKhGgcSU6CVyGW0Piga3gehzDz63Dy9mncg1 HMOXvTfYD7a+g== Date: Tue, 25 Jan 2022 11:50:43 -0700 From: Nathan Chancellor To: Ard Biesheuvel , Kees Cook Cc: linux-arm-kernel@lists.infradead.org, Nick Desaulniers , llvm@lists.linux.dev Subject: Re: [PATCH] ARM: stackprotector: prefer compiler for TLS based per-task protector Message-ID: References: <20211021142516.1843042-1-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211021142516.1843042-1-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220125_105049_115549_A5D89D97 X-CRM114-Status: GOOD ( 18.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 21, 2021 at 04:25:16PM +0200, Ard Biesheuvel wrote: > Currently, we implement the per-task stack protector for ARM using a GCC > plugin, due to lack of native compiler support. However, work is > underway to get this implemented in the compiler, which means we will be > able to deprecate the GCC plugin at some point. > > In the meantime, we will need to support both, where the native compiler > implementation is obviously preferred. So let's wire this up in Kconfig > and the Makefile. > > Cc: Kees Cook > Cc: Nick Desaulniers > Signed-off-by: Ard Biesheuvel I see this patch in the KSPP tree as commit 151bbc8be85e ("ARM: stackprotector: prefer compiler for TLS based per-task protector"), which breaks booting aspeed_g5_defconfig in QEMU with clang-14. It seems like this patch depends on Ard's patch "ARM: decompressor: disable stack protector" [1]; applying that on top of next-20220125 allows me to boot again. This patch is still queued up in Russell's devel-stable branch as commit f05eb1d24eb5 ("ARM: stackprotector: prefer compiler for TLS based per-task protector") so perhaps this patch should be dropped from the KSPP tree? I assume once Ard's recent fixes series [2] is applied to devel-stable, it will be added back to for-next? [1]: https://lore.kernel.org/r/20220124174744.1054712-9-ardb@kernel.org/ [2]: https://lore.kernel.org/r/20220125091453.1475246-1-ardb@kernel.org/ Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel